All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Igor Mammedov <imammedo@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages
Date: Fri, 21 Mar 2014 17:08:06 +0100	[thread overview]
Message-ID: <87mwgjh6vt.fsf@elfo.mitica> (raw)
In-Reply-To: <532C5F71.60108@redhat.com> (Paolo Bonzini's message of "Fri, 21 Mar 2014 16:49:05 +0100")

Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 21/03/2014 16:45, Dr. David Alan Gilbert ha scritto:
>>> > So it looks like your patch could also fix the problem Juan reported
>>> > at http://article.gmane.org/gmane.comp.emulators.qemu/247462 -- but
>>> > perhaps only on hosts where !KVM || TARGET_PAGE_SIZE==getpagesize().
>> Possibly yes; I think that would cause gaps in the bitmap to have
>> the same effect as the hot unplug.
>
> It would be nice to revive that patch, because without it you risk
> getting bad performance from migration of hotplugged memory.  On-board
> RAM typically gets low ram_addr_t's that are aligned, but the 128K (32
> pages) ROM and the 64K VGA BIOS will ruin the alignment and cause
> migration to use the slow paths to migrate hotplugged memory above
> them.

Agreed.  I had forgot that optimization that we had to get out.

The problem (for my use case) was VGA, that was dirtying continously
memory that was not aligned.  Size was not big, but was using bit-by-bit
operations, when we could use bitmap ones.

Later, Juan.

  reply	other threads:[~2014-03-21 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 10:58 [Qemu-devel] [PATCH 1/1] Count used RAMBlock pages for migration_dirty_pages Dr. David Alan Gilbert (git)
2014-03-21 13:11 ` Juan Quintela
2014-03-21 13:22   ` Dr. David Alan Gilbert
2014-03-21 15:15     ` Paolo Bonzini
2014-03-21 15:45       ` Dr. David Alan Gilbert
2014-03-21 15:49         ` Paolo Bonzini
2014-03-21 16:08           ` Juan Quintela [this message]
2014-03-21 13:44 ` 陈梁
2014-03-21 14:41   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwgjh6vt.fsf@elfo.mitica \
    --to=quintela@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=dgilbert@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.