From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932779Ab1EUCek (ORCPT ); Fri, 20 May 2011 22:34:40 -0400 Received: from ozlabs.org ([203.10.76.45]:37216 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755302Ab1EUCeA (ORCPT ); Fri, 20 May 2011 22:34:00 -0400 From: Rusty Russell To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Carsten Otte , Christian Borntraeger , linux390@de.ibm.com, Martin Schwidefsky , Heiko Carstens , Shirley Ma , lguest@lists.ozlabs.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, Krishna Kumar , Tom Lendacky , steved@us.ibm.com, habanero@linux.vnet.ibm.com Subject: Re: [PATCHv2 06/14] virtio: add api for delayed callbacks In-Reply-To: <8f343dcaa996f6b10499468c49508ba9d6fb6f5a.1305846412.git.mst@redhat.com> References: <8f343dcaa996f6b10499468c49508ba9d6fb6f5a.1305846412.git.mst@redhat.com> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Sat, 21 May 2011 12:03:35 +0930 Message-ID: <87mxigu6io.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 May 2011 02:11:14 +0300, "Michael S. Tsirkin" wrote: > Add an API that tells the other side that callbacks > should be delayed until a lot of work has been done. > Implement using the new event_idx feature. > > Note: it might seem advantageous to let the drivers > ask for a callback after a specific capacity has > been reached. However, as a single head can > free many entries in the descriptor table, > we don't really have a clue about capacity > until get_buf is called. The API is the simplest > to implement at the moment, we'll see what kind of > hints drivers can pass when there's more than one > user of the feature. > > Signed-off-by: Michael S. Tsirkin Yes, I've applied this (and the next one which uses it in virtio_net), despite my reservations about the API. But that is fixable... Thanks, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCHv2 06/14] virtio: add api for delayed callbacks Date: Sat, 21 May 2011 12:03:35 +0930 Message-ID: <87mxigu6io.fsf@rustcorp.com.au> References: <8f343dcaa996f6b10499468c49508ba9d6fb6f5a.1305846412.git.mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Krishna Kumar , Carsten Otte , lguest-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Shirley Ma , kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, habanero-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Heiko Carstens , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, steved-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, Christian Borntraeger , Tom Lendacky , Martin Schwidefsky , linux390-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org To: "Michael S. Tsirkin" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: In-Reply-To: <8f343dcaa996f6b10499468c49508ba9d6fb6f5a.1305846412.git.mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, 20 May 2011 02:11:14 +0300, "Michael S. Tsirkin" wrote: > Add an API that tells the other side that callbacks > should be delayed until a lot of work has been done. > Implement using the new event_idx feature. > > Note: it might seem advantageous to let the drivers > ask for a callback after a specific capacity has > been reached. However, as a single head can > free many entries in the descriptor table, > we don't really have a clue about capacity > until get_buf is called. The API is the simplest > to implement at the moment, we'll see what kind of > hints drivers can pass when there's more than one > user of the feature. > > Signed-off-by: Michael S. Tsirkin Yes, I've applied this (and the next one which uses it in virtio_net), despite my reservations about the API. But that is fixable... Thanks, Rusty.