All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux-rockchip <linux-rockchip-bounces@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.or>
Subject: [bug?] 85d2a31fe4d9 ("media: rkisp1: Drop IRQF_SHARED") breaks ISP1 on RK3399
Date: Sun, 17 Dec 2023 22:14:34 +0300	[thread overview]
Message-ID: <87o7eo8vym.fsf@gmail.com> (raw)

Hi!

Rockchip ISP1 is broken for me on a custom rk3399-based board in the
latest media_stage. Relevant dmesg fragment:

    rkisp1 ff910000.isp0: Adding to iommu group 2
    genirq: Flags mismatch irq 42. 00000004 (rkisp1) vs. 00000084 (ff914000.iommu)
    rkisp1 ff910000.isp0: request irq failed: -16
    rkisp1: probe of ff910000.isp0 failed with error -16
    rkisp1 ff920000.isp1: Adding to iommu group 3
    genirq: Flags mismatch irq 43. 00000004 (rkisp1) vs. 00000084 (ff924000.iommu)
    rkisp1 ff920000.isp1: request irq failed: -16
    rkisp1: probe of ff920000.isp1 failed with error -16

According to rk3399.dtsi, isp interrupts are shared with correponding
mmu interrupts (isp0 with isp0_mmu, isp1 with isp1_mmu), so the subject
commit breaks devm_request_irq. Reverting it fixes the issue for me.

If I'm just missing something, sorry for the noise.

--
Best regards,
Mikhail Rudenko

             reply	other threads:[~2023-12-17 19:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-17 19:14 Mikhail Rudenko [this message]
2023-12-18  1:53 ` [bug?] 85d2a31fe4d9 ("media: rkisp1: Drop IRQF_SHARED") breaks ISP1 on RK3399 Laurent Pinchart
2023-12-18  7:55   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7eo8vym.fsf@gmail.com \
    --to=mike.rudenko@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.or \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip-bounces@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.