From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04323C433EF for ; Sat, 21 May 2022 10:40:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 491FD16F2; Sat, 21 May 2022 12:39:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 491FD16F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653129632; bh=QsjF1pujAO7MW8EcVnv8ig3u9KTbk6Bjmk/88oc81u4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dBNiFo/JeorZ3IMmo8kqFw7AErw2e+J8p+VH3L82Gl5N74TRJDRhOV6FC2bj60VeB DAISMGH0X9PHIe4ZXxYkHIfzz7Y1Ofdm00F63yWMoZhgftMCw+q6ejC7ix2caaJiGB wJRMQFzHbPz3Vea0uP11BH/6s5+iQhR9Lrcj27lk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DEFC0F80153; Sat, 21 May 2022 12:39:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 26C28F8015B; Sat, 21 May 2022 12:39:41 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B26EFF80105 for ; Sat, 21 May 2022 12:39:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B26EFF80105 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="RQOeM8Er"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AdTlD9HC" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1A26921B90; Sat, 21 May 2022 10:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653129578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ReXa6gekTyDvKdLnc790nEALr3l/XMJezrJSp6WQ/7Y=; b=RQOeM8ErFMBO3DR3mRApbm31xG01uOIhCEY32IvMVEPBwx1ZSCOEa06BperXH9ArbxiCXf exqQRwzX/4E0IlSI+Ajl5iUOQE/vXHwwek/qH4zQwWZ6W8A70PUksgjghzi30KbGUc3Hr4 /ruvNopBOXP4OcLpKTnx/X1ANh6s0sk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653129578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ReXa6gekTyDvKdLnc790nEALr3l/XMJezrJSp6WQ/7Y=; b=AdTlD9HCMmXpZB6TM8QsiozR1Dx2mYVu5xkePhVimqlOadXWE7u6gA2byiBgKWqegUa27F VCrTDCJOL3qZL6BA== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 083A02C141; Sat, 21 May 2022 10:39:38 +0000 (UTC) Date: Sat, 21 May 2022 12:39:36 +0200 Message-ID: <87o7zrnp93.wl-tiwai@suse.de> From: Takashi Iwai To: Edward Matijevic Subject: Re: [PATCH] ALSA: ctxfi: Add SB046x PCI ID In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 21 May 2022 06:45:15 +0200, Edward Matijevic wrote: > > Adds the PCI ID for X-Fi cards sold under the Platnum and XtremeMusic names > > Before: snd_ctxfi 0000:05:05.0: chip 20K1 model Unknown (1102:0021) is found > After: snd_ctxfi 0000:05:05.0: chip 20K1 model SB046x (1102:0021) is found > > Signed-off-by: Edward Matijevic Does / did everything work as expected? The model field influence on a few device-specific setups such as the GPIO initial value, ADC and DAC selections, not only the name string. thanks, Takashi > --- > sound/pci/ctxfi/ctatc.c | 2 ++ > sound/pci/ctxfi/cthardware.h | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c > index 78f35e88aed6..fbdb8a3d5b8e 100644 > --- a/sound/pci/ctxfi/ctatc.c > +++ b/sound/pci/ctxfi/ctatc.c > @@ -36,6 +36,7 @@ > | ((IEC958_AES3_CON_FS_48000) << 24)) > > static const struct snd_pci_quirk subsys_20k1_list[] = { > + SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x0021, "SB046x", CTSB046X), > SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x0022, "SB055x", CTSB055X), > SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x002f, "SB055x", CTSB055X), > SND_PCI_QUIRK(PCI_VENDOR_ID_CREATIVE, 0x0029, "SB073x", CTSB073X), > @@ -64,6 +65,7 @@ static const struct snd_pci_quirk subsys_20k2_list[] = { > > static const char *ct_subsys_name[NUM_CTCARDS] = { > /* 20k1 models */ > + [CTSB046X] = "SB046x", > [CTSB055X] = "SB055x", > [CTSB073X] = "SB073x", > [CTUAA] = "UAA", > diff --git a/sound/pci/ctxfi/cthardware.h b/sound/pci/ctxfi/cthardware.h > index f406b626a28c..2875cec83b8f 100644 > --- a/sound/pci/ctxfi/cthardware.h > +++ b/sound/pci/ctxfi/cthardware.h > @@ -26,8 +26,9 @@ enum CHIPTYP { > > enum CTCARDS { > /* 20k1 models */ > + CTSB046X, > + CT20K1_MODEL_FIRST = CTSB046X, > CTSB055X, > - CT20K1_MODEL_FIRST = CTSB055X, > CTSB073X, > CTUAA, > CT20K1_UNKNOWN, > -- > 2.36.1 >