From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A203DC433EF for ; Tue, 26 Apr 2022 20:21:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21F1E10E449; Tue, 26 Apr 2022 20:21:13 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 228D610E449 for ; Tue, 26 Apr 2022 20:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651004471; x=1682540471; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=suweuorXJZ+KS9//ncakfeLI49PS2SoPIWhbozYyxM4=; b=HvhaBjH4EgfnlfoHlfXrZ78MUwg5KQidooxigemuyFO0WPaBnf8659tg fJbPoPEl1LEhR3DdC7bA4rt8ijp2SOiEo/j4Oe3AhKy2wZG3rRan47vjR oozONMC5ab8KUu/wIFN0OmHSv6r0WKH6Hyn3ScBa7UQUupDdl9Ws3llzS TM8cExKnGOARL1mn57o41+OX3zj0NNPjgCh26Zya5dPlWRSbDqk54p+rD ra6FtyNVDzqRbmBAIdgl3sfd1BX5skmsIL8XZhPfQ08k3lWH4G5ir0vbh pDy7BV1UC03wd1nKj4ygmwLOCioRWmpwNNZ6biT2m1Whl3bKrfdf/lSWJ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="263303383" X-IronPort-AV: E=Sophos;i="5.90,291,1643702400"; d="scan'208";a="263303383" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 13:21:10 -0700 X-IronPort-AV: E=Sophos;i="5.90,291,1643702400"; d="scan'208";a="874935023" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.167.108]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 13:21:10 -0700 Date: Tue, 26 Apr 2022 13:21:10 -0700 Message-ID: <87o80n61ft.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti In-Reply-To: References: <9ed5af1177ad08c7c2d9c5d9b32ab0154dbd950f.1650435571.git.ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, 24 Apr 2022 15:30:59 -0700, Andi Shyti wrote: > > Hi Ashutosh, > Hi Andi, > [...] > > > -static struct kobj_type kobj_gt_type = { > > - .release = kobj_gt_release, > > +static struct kobj_type kobj_gtn_type = { > > what does it mean GTN? Or is it GTn? Please use just GT, gtn is > confusing. > > Same for all the rest of the gtn's you have used below. I didn't like gtn either. But a sysfs_gt kobject is already part of 'struct drm_i915_private' so I thought I'll put sysfs_gtn (for gt/gtN) in 'struct intel_gt'. Otherwise browsing the code etc. gets confusing. So that was the reason, but I think I'll change the name to 'kobj_gt' (from the current 'sysfs_gtn') in the next rev. That seems better. Thoughts? Will respond to your other comments after posting the next rev patches (now need some rework because Jani doesn't want a dependence between gt and display code in pcode functions). Thanks. -- Ashutosh