From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A6E1C433F5 for ; Wed, 6 Apr 2022 10:46:50 +0000 (UTC) Received: from localhost ([::1]:44300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nc3BZ-0005JF-4R for qemu-devel@archiver.kernel.org; Wed, 06 Apr 2022 06:46:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nc3AO-0003uT-5w for qemu-devel@nongnu.org; Wed, 06 Apr 2022 06:45:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:49831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nc3AL-0007sx-By for qemu-devel@nongnu.org; Wed, 06 Apr 2022 06:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649241932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ugBjFme6Tz0mv1Hm4wpbefwSklpAUmZcDU57eVJ7dYg=; b=hfGsqLlPRaaEyI1Neba8+Pd8GiiRMysjs23rf7skxleF6AoofDifzdCg9Z8U0u9/aToGPe pPgSiSA1ZJW1c7LkQ90oNobC9pbaQL5fctkq5qJeMlbhOqBZSEWSrk5g5xBtd64WfId3DT Ax08SmEMdnOFwJCUF6thZBUfIRO+kjI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-OM1aiwbgMuiuhMqtFjCKTw-1; Wed, 06 Apr 2022 06:45:29 -0400 X-MC-Unique: OM1aiwbgMuiuhMqtFjCKTw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 026011C1C520; Wed, 6 Apr 2022 10:45:23 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFC12C27E84; Wed, 6 Apr 2022 10:45:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 961B121E6A00; Wed, 6 Apr 2022 12:45:19 +0200 (CEST) From: Markus Armbruster To: Ani Sinha Subject: Re: [PATCH 32/32] Remove qemu-common.h include from most units References: <20220323155743.1585078-1-marcandre.lureau@redhat.com> <20220323155743.1585078-33-marcandre.lureau@redhat.com> Date: Wed, 06 Apr 2022 12:45:19 +0200 In-Reply-To: (Ani Sinha's message of "Tue, 5 Apr 2022 20:32:28 +0530") Message-ID: <87o81epk1s.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John G Johnson , Alexey Kardashevskiy , Li Zhijian , KONRAD Frederic , "open list:raw" , Stefan Berger , Alex =?utf-8?Q?Benn?= =?utf-8?Q?=C3=A9e?= , Huacai Chen , Halil Pasic , Kamil Rytarowski , =?utf-8?Q?Herv=C3=A9?= Poussineau , Christian Borntraeger , Michael Roth , Alexander Bulekov , Stefan Hajnoczi , John Snow , Aarushi Mehta , Kevin Wolf , Andrew Jeffery , Chris Wulff , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Subbaraya Sundeep , Zhang Chen , "open list:sPAPR \(pseries\)" , Igor Mammedov , Gerd Hoffmann , Fam Zheng , Peter Maydell , David Hildenbrand , Yanan Wang , Max Filippov , Alistair Francis , Yoshinori Sato , Helge Deller , Qiuhao Li , Artyom Tarasenko , Stefano Garzarella , Eric Farman , Corey Minyard , Stefan Weil , Julia Suvorova , Greg Kurz , Cameron Esfahani , Bandan Das , Alexander Graf , Michael Rolnik , =?utf-8?Q?C=C3=A9?= =?utf-8?Q?dric?= Le Goater , "open list:RISC-V TCG CPUs" , Cornelia Huck , "open list:S390-ccw boot" , Tyrone Ting , Hanna Reitz , "open list:ARM PrimeCell and..." , Wenchao Wang , Aurelien Jarno , Elena Ufimtseva , Jason Wang , Bin Meng , Taylor Simpson , Colin Xu , "Edgar E. Iglesias" , Daniel Henrique Barboza , Joel Stanley , Aleksandar Rikalo , Mark Cave-Ayland , Fabien Chouteau , Roman Bolshakov , Sunil Muthuswamy , Eduardo Habkost , Bastian Koppelmann , Laurent Vivier , "open list:Overall KVM CPUs" , "Michael S. Tsirkin" , Christian Schoenebeck , qemu-devel@nongnu.org, "open list:X86 HAXM CPUs" , Warner Losh , Marek Vasut , Jagannathan Raman , Havard Skinnemoen , Reinoud Zandijk , Kyle Evans , marcandre.lureau@redhat.com, Richard Henderson , David Gibson , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , Darren Kenny , Eric Auger , Thomas Huth , Marcelo Tosatti , Palmer Dabbelt , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" First of all: thank you so much for completing the "empty out qemu-common.h" job! This is what's left: #ifndef QEMU_COMMON_H #define QEMU_COMMON_H /* Copyright string for -version arguments, About dialogs, etc */ #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \ "Fabrice Bellard and the QEMU Project developers" /* Bug reporting information for --help arguments, About dialogs, etc */ #define QEMU_HELP_BOTTOM \ "See for how to report b= ugs.\n" \ "More information on the QEMU project at ." #endif Rename the header? Or replace the macros by variables, and move their declarations elsewhere? Not demands; this series is lovely progress as is. Ani Sinha writes: > On Wed, Mar 23, 2022 at 9:32 PM wrote: > >> From: Marc-Andr=C3=A9 Lureau >> >> Signed-off-by: Marc-Andr=C3=A9 Lureau > > > Empty patch descriptions are not a good idea. Please explain why this > removal does not break things and maybe why the header got included > initiatively. Something like The previous commits moved most of qemu-common.h's contents elsewhere. Most inclusions are now useless. Remove them. would do for me. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nc3AQ-00041T-An for mharc-qemu-riscv@gnu.org; Wed, 06 Apr 2022 06:45:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nc3AO-0003uS-5q for qemu-riscv@nongnu.org; Wed, 06 Apr 2022 06:45:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:44943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nc3AL-0007t8-9B for qemu-riscv@nongnu.org; Wed, 06 Apr 2022 06:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649241932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ugBjFme6Tz0mv1Hm4wpbefwSklpAUmZcDU57eVJ7dYg=; b=hfGsqLlPRaaEyI1Neba8+Pd8GiiRMysjs23rf7skxleF6AoofDifzdCg9Z8U0u9/aToGPe pPgSiSA1ZJW1c7LkQ90oNobC9pbaQL5fctkq5qJeMlbhOqBZSEWSrk5g5xBtd64WfId3DT Ax08SmEMdnOFwJCUF6thZBUfIRO+kjI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-OM1aiwbgMuiuhMqtFjCKTw-1; Wed, 06 Apr 2022 06:45:29 -0400 X-MC-Unique: OM1aiwbgMuiuhMqtFjCKTw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 026011C1C520; Wed, 6 Apr 2022 10:45:23 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFC12C27E84; Wed, 6 Apr 2022 10:45:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 961B121E6A00; Wed, 6 Apr 2022 12:45:19 +0200 (CEST) From: Markus Armbruster To: Ani Sinha Cc: marcandre.lureau@redhat.com, Aarushi Mehta , Aleksandar Rikalo , Alex =?utf-8?Q?Benn?= =?utf-8?Q?=C3=A9e?= , Alexander Bulekov , Alexander Graf , Alexey Kardashevskiy , Alistair Francis , Andrew Jeffery , Artyom Tarasenko , Aurelien Jarno , BALATON Zoltan , Bandan Das , Bastian Koppelmann , Bin Meng , Cameron Esfahani , Chris Wulff , Christian Borntraeger , Christian Schoenebeck , Colin Xu , Corey Minyard , Cornelia Huck , =?utf-8?Q?C=C3=A9?= =?utf-8?Q?dric?= Le Goater , Daniel Henrique Barboza , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Darren Kenny , David Gibson , David Hildenbrand , "Edgar E. Iglesias" , Eduardo Habkost , Elena Ufimtseva , Eric Auger , Eric Farman , Fabien Chouteau , Fam Zheng , Gerd Hoffmann , Greg Kurz , Halil Pasic , Hanna Reitz , Havard Skinnemoen , Helge Deller , =?utf-8?Q?Herv=C3=A9?= Poussineau , Huacai Chen , Igor Mammedov , Jagannathan Raman , Jason Wang , Jiaxun Yang , Joel Stanley , John G Johnson , John Snow , Julia Suvorova , KONRAD Frederic , Kamil Rytarowski , Kevin Wolf , Kyle Evans , Laurent Vivier , Li Zhijian , Marcel Apfelbaum , Marcelo Tosatti , Marek Vasut , Mark Cave-Ayland , Max Filippov , Michael Rolnik , Michael Roth , "Michael S. Tsirkin" , Palmer Dabbelt , Paolo Bonzini , Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Qiuhao Li , Reinoud Zandijk , Richard Henderson , Roman Bolshakov , Stefan Berger , Stefan Hajnoczi , Stefan Weil , Stefano Garzarella , Subbaraya Sundeep , Sunil Muthuswamy , Taylor Simpson , Thomas Huth , Tyrone Ting , Warner Losh , Wenchao Wang , Yanan Wang , Yoshinori Sato , Zhang Chen , "open list:ARM PrimeCell and..." , "open list:Overall KVM CPUs" , "open list:RISC-V TCG CPUs" , "open list:S390-ccw boot" , "open list:X86 HAXM CPUs" , "open list:raw" , "open list:sPAPR (pseries)" , qemu-devel@nongnu.org Subject: Re: [PATCH 32/32] Remove qemu-common.h include from most units References: <20220323155743.1585078-1-marcandre.lureau@redhat.com> <20220323155743.1585078-33-marcandre.lureau@redhat.com> Date: Wed, 06 Apr 2022 12:45:19 +0200 In-Reply-To: (Ani Sinha's message of "Tue, 5 Apr 2022 20:32:28 +0530") Message-ID: <87o81epk1s.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 10:45:36 -0000 First of all: thank you so much for completing the "empty out qemu-common.h" job! This is what's left: #ifndef QEMU_COMMON_H #define QEMU_COMMON_H /* Copyright string for -version arguments, About dialogs, etc */ #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \ "Fabrice Bellard and the QEMU Project developers" /* Bug reporting information for --help arguments, About dialogs, etc */ #define QEMU_HELP_BOTTOM \ "See for how to report b= ugs.\n" \ "More information on the QEMU project at ." #endif Rename the header? Or replace the macros by variables, and move their declarations elsewhere? Not demands; this series is lovely progress as is. Ani Sinha writes: > On Wed, Mar 23, 2022 at 9:32 PM wrote: > >> From: Marc-Andr=C3=A9 Lureau >> >> Signed-off-by: Marc-Andr=C3=A9 Lureau > > > Empty patch descriptions are not a good idea. Please explain why this > removal does not break things and maybe why the header got included > initiatively. Something like The previous commits moved most of qemu-common.h's contents elsewhere. Most inclusions are now useless. Remove them. would do for me.