All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] toolchain: update gcc bug 99410
@ 2022-02-06  9:08 Giulio Benetti
  2022-02-06 10:58 ` Thomas Petazzoni via buildroot
  2022-02-06 11:14 ` Arnout Vandecappelle
  0 siblings, 2 replies; 8+ messages in thread
From: Giulio Benetti @ 2022-02-06  9:08 UTC (permalink / raw)
  To: buildroot
  Cc: Thomas Petazzoni, Romain Naour, Giulio Benetti, Thomas De Schampheleire

Gcc bug 99410 reappeared in gcc 10.x while building belle-sip, but it's
fixed on gcc 11.x, so let's update bug conditions.

Fixes:
http://autobuild.buildroot.net/results/846597f3573d3b0d52e80627a9577d14b9348547/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index ccdf62503d..aed8f393a3 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -185,11 +185,11 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99410
 # Error: branch offset out of range on Nios II. This bug
 # no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
-# fixed on gcc 10.x.
+# fixed on gcc 11.x.
 config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
 	bool
 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
-	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_10
+	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_10 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
 	depends on BR2_nios2
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH] toolchain: update gcc bug 99410
  2022-02-06  9:08 [Buildroot] [PATCH] toolchain: update gcc bug 99410 Giulio Benetti
@ 2022-02-06 10:58 ` Thomas Petazzoni via buildroot
  2022-02-06 11:14 ` Arnout Vandecappelle
  1 sibling, 0 replies; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-02-06 10:58 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Romain Naour, Thomas De Schampheleire, buildroot

On Sun,  6 Feb 2022 10:08:09 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Gcc bug 99410 reappeared in gcc 10.x while building belle-sip, but it's
> fixed on gcc 11.x, so let's update bug conditions.
> 
> Fixes:
> http://autobuild.buildroot.net/results/846597f3573d3b0d52e80627a9577d14b9348547/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  toolchain/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH] toolchain: update gcc bug 99410
  2022-02-06  9:08 [Buildroot] [PATCH] toolchain: update gcc bug 99410 Giulio Benetti
  2022-02-06 10:58 ` Thomas Petazzoni via buildroot
@ 2022-02-06 11:14 ` Arnout Vandecappelle
  2022-02-06 11:33   ` Giulio Benetti
  1 sibling, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2022-02-06 11:14 UTC (permalink / raw)
  To: Giulio Benetti, buildroot
  Cc: Romain Naour, Thomas De Schampheleire, Thomas Petazzoni



On 06/02/2022 10:08, Giulio Benetti wrote:
> Gcc bug 99410 reappeared in gcc 10.x while building belle-sip, but it's
> fixed on gcc 11.x, so let's update bug conditions.
> 
> Fixes:
> http://autobuild.buildroot.net/results/846597f3573d3b0d52e80627a9577d14b9348547/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   toolchain/Config.in | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index ccdf62503d..aed8f393a3 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -185,11 +185,11 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99410
>   # Error: branch offset out of range on Nios II. This bug
>   # no longer exists in gcc 8.x but reappeared on gcc 9.x and has been

  If this statement is true...

> -# fixed on gcc 10.x.
> +# fixed on gcc 11.x.
>   config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
>   	bool
>   	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_10
> +	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_10 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11

  ... then this should be

	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11

  We don't have a nios2 GCC9 toolchain in the autobuilders so we'll never 
notice, of course.

  Regards,
  Arnout

>   	depends on BR2_nios2
>   
>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH] toolchain: update gcc bug 99410
  2022-02-06 11:14 ` Arnout Vandecappelle
@ 2022-02-06 11:33   ` Giulio Benetti
  2022-02-06 11:34     ` Giulio Benetti
  0 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2022-02-06 11:33 UTC (permalink / raw)
  To: Arnout Vandecappelle, buildroot
  Cc: Romain Naour, Thomas Petazzoni, Thomas De Schampheleire

Hi Arnout,

On 06/02/22 12:14, Arnout Vandecappelle wrote:
> 
> 
> On 06/02/2022 10:08, Giulio Benetti wrote:
>> Gcc bug 99410 reappeared in gcc 10.x while building belle-sip, but it's
>> fixed on gcc 11.x, so let's update bug conditions.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/846597f3573d3b0d52e80627a9577d14b9348547/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>    toolchain/Config.in | 4 ++--
>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/toolchain/Config.in b/toolchain/Config.in
>> index ccdf62503d..aed8f393a3 100644
>> --- a/toolchain/Config.in
>> +++ b/toolchain/Config.in
>> @@ -185,11 +185,11 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
>>    # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99410
>>    # Error: branch offset out of range on Nios II. This bug
>>    # no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
> 
>    If this statement is true...
> 
>> -# fixed on gcc 10.x.
>> +# fixed on gcc 11.x.
>>    config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
>>    	bool
>>    	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
>> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_10
>> +	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_10 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
> 
>    ... then this should be
> 
> 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11

but it's all negative options, so I thought I needed AT_LEAST_10 to 
cover gcc 10.x as having the bug. But it's not needed. So I only need to 
modify from !BR2_TOOLCHAIN_GCC_AT_LEAST_10 to 
!BR2_TOOLCHAIN_GCC_AT_LEAST_11 and that's it.

So I send a V2 for this.

>    We don't have a nios2 GCC9 toolchain in the autobuilders so we'll never
> notice, of course.

I've tested it locally with buildroot built toolchain.

Thank you!

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

>    Regards,
>    Arnout
> 
>>    	depends on BR2_nios2
>>    
>>    # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH] toolchain: update gcc bug 99410
  2022-02-06 11:33   ` Giulio Benetti
@ 2022-02-06 11:34     ` Giulio Benetti
  2022-02-06 14:24       ` [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition Giulio Benetti
  0 siblings, 1 reply; 8+ messages in thread
From: Giulio Benetti @ 2022-02-06 11:34 UTC (permalink / raw)
  To: Arnout Vandecappelle, buildroot
  Cc: Romain Naour, Thomas De Schampheleire, Thomas Petazzoni

On 06/02/22 12:33, Giulio Benetti wrote:
> Hi Arnout,
> 
> On 06/02/22 12:14, Arnout Vandecappelle wrote:
>>
>>
>> On 06/02/2022 10:08, Giulio Benetti wrote:
>>> Gcc bug 99410 reappeared in gcc 10.x while building belle-sip, but it's
>>> fixed on gcc 11.x, so let's update bug conditions.
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/846597f3573d3b0d52e80627a9577d14b9348547/
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> ---
>>>     toolchain/Config.in | 4 ++--
>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/toolchain/Config.in b/toolchain/Config.in
>>> index ccdf62503d..aed8f393a3 100644
>>> --- a/toolchain/Config.in
>>> +++ b/toolchain/Config.in
>>> @@ -185,11 +185,11 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
>>>     # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99410
>>>     # Error: branch offset out of range on Nios II. This bug
>>>     # no longer exists in gcc 8.x but reappeared on gcc 9.x and has been
>>
>>     If this statement is true...
>>
>>> -# fixed on gcc 10.x.
>>> +# fixed on gcc 11.x.
>>>     config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
>>>     	bool
>>>     	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
>>> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_10
>>> +	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_10 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
>>
>>     ... then this should be
>>
>> 	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
> 
> but it's all negative options, so I thought I needed AT_LEAST_10 to
> cover gcc 10.x as having the bug. But it's not needed. So I only need to
> modify from !BR2_TOOLCHAIN_GCC_AT_LEAST_10 to
> !BR2_TOOLCHAIN_GCC_AT_LEAST_11 and that's it.
> 
> So I send a V2 for this.

Not V2, I need a new one to fix it since it's already been applied.
I send it now

>>     We don't have a nios2 GCC9 toolchain in the autobuilders so we'll never
>> notice, of course.
> 
> I've tested it locally with buildroot built toolchain.
> 
> Thank you!
> 
> Best regards

-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition
  2022-02-06 11:34     ` Giulio Benetti
@ 2022-02-06 14:24       ` Giulio Benetti
  2022-02-14 20:41         ` Arnout Vandecappelle
  2022-02-27 20:33         ` Peter Korsgaard
  0 siblings, 2 replies; 8+ messages in thread
From: Giulio Benetti @ 2022-02-06 14:24 UTC (permalink / raw)
  To: buildroot
  Cc: Giulio Benetti, Romain Naour, Thomas De Schampheleire, Thomas Petazzoni

Gcc bug 99140 exhibits with gcc versions:
- up to 7.x
- 9.x
- 10.x
and doesn't show up with gcc versions:
- 8.x
- 11.x
then moving BR2_TOOLCHAIN_GCC_AT_LEAST_9 to BR2_TOOLCHAIN_GCC_AT_LEAST_10
makes gcc version 9 set as working but it's not. So let's back substitute
BR2_TOOLCHAIN_GCC_AT_LEAST_10 with BR2_TOOLCHAIN_GCC_AT_LEAST_9.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index aed8f393a3..db3f451f45 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -189,7 +189,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
 config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
 	bool
 	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
-	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_10 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
+	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
 	depends on BR2_nios2
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition
  2022-02-06 14:24       ` [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition Giulio Benetti
@ 2022-02-14 20:41         ` Arnout Vandecappelle
  2022-02-27 20:33         ` Peter Korsgaard
  1 sibling, 0 replies; 8+ messages in thread
From: Arnout Vandecappelle @ 2022-02-14 20:41 UTC (permalink / raw)
  To: Giulio Benetti, buildroot
  Cc: Romain Naour, Thomas De Schampheleire, Thomas Petazzoni



On 06/02/2022 15:24, Giulio Benetti wrote:
> Gcc bug 99140 exhibits with gcc versions:
> - up to 7.x
> - 9.x
> - 10.x
> and doesn't show up with gcc versions:
> - 8.x
> - 11.x
> then moving BR2_TOOLCHAIN_GCC_AT_LEAST_9 to BR2_TOOLCHAIN_GCC_AT_LEAST_10
> makes gcc version 9 set as working but it's not. So let's back substitute
> BR2_TOOLCHAIN_GCC_AT_LEAST_10 with BR2_TOOLCHAIN_GCC_AT_LEAST_9.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   toolchain/Config.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index aed8f393a3..db3f451f45 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -189,7 +189,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
>   config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
>   	bool
>   	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_8
> -	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_10 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
> +	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_9 && !BR2_TOOLCHAIN_GCC_AT_LEAST_11
>   	depends on BR2_nios2
>   
>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101737
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition
  2022-02-06 14:24       ` [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition Giulio Benetti
  2022-02-14 20:41         ` Arnout Vandecappelle
@ 2022-02-27 20:33         ` Peter Korsgaard
  1 sibling, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2022-02-27 20:33 UTC (permalink / raw)
  To: Giulio Benetti
  Cc: Romain Naour, Thomas Petazzoni, Thomas De Schampheleire, buildroot

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > Gcc bug 99140 exhibits with gcc versions:
 > - up to 7.x
 > - 9.x
 > - 10.x
 > and doesn't show up with gcc versions:
 > - 8.x
 > - 11.x
 > then moving BR2_TOOLCHAIN_GCC_AT_LEAST_9 to BR2_TOOLCHAIN_GCC_AT_LEAST_10
 > makes gcc version 9 set as working but it's not. So let's back substitute
 > BR2_TOOLCHAIN_GCC_AT_LEAST_10 with BR2_TOOLCHAIN_GCC_AT_LEAST_9.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-02-27 20:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-06  9:08 [Buildroot] [PATCH] toolchain: update gcc bug 99410 Giulio Benetti
2022-02-06 10:58 ` Thomas Petazzoni via buildroot
2022-02-06 11:14 ` Arnout Vandecappelle
2022-02-06 11:33   ` Giulio Benetti
2022-02-06 11:34     ` Giulio Benetti
2022-02-06 14:24       ` [Buildroot] [PATCH] toolchain: fix gcc bug 99140 condition Giulio Benetti
2022-02-14 20:41         ` Arnout Vandecappelle
2022-02-27 20:33         ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.