From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A27C433FE for ; Sun, 30 Jan 2022 10:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354598AbiA3K2t (ORCPT ); Sun, 30 Jan 2022 05:28:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354443AbiA3K2o (ORCPT ); Sun, 30 Jan 2022 05:28:44 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE4EBC061714; Sun, 30 Jan 2022 02:28:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 578F461134; Sun, 30 Jan 2022 10:28:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FD29C340E4; Sun, 30 Jan 2022 10:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643538523; bh=JScouu7QJzKlX9zxN9+gJC2kurFCaqhYhzCffJo5CmY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UO1SMJcNJgX2LrIsWjjT4ryauQ1+KZ1t4buAgyl08ZK9ezEUsorn/xeZNdyEJlSrO eIm8CHvEVOJLGXMoYNPBu1QJuFBUX8bKG/T9Zb4bH5e1s05R7KeuRMExjHKwxjUkY4 93Ad77S1psNZY/tBpaw+E6a59SLOtloEnP0jA34G1gDYgNrG9aZ3gsq9M1lM37lv9s jErY1u1XUd7ZvHfOlJPLznacSu0fAa5fR7Jqpgz26/AAWpBXFppcmnsBYYNEbleSI7 2NeFt7YSLeSu0QJTB93G4wTBr9zkcyAF6PURU3Vc914nRE3kjkx3odTpyJprt9AoZS RshTaMiOqgUew== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nE7Rp-00493J-K8; Sun, 30 Jan 2022 10:28:41 +0000 Date: Sun, 30 Jan 2022 10:28:41 +0000 Message-ID: <87o83ty0ti.wl-maz@kernel.org> From: Marc Zyngier To: Guo Ren Cc: Samuel Holland , Anup Patel , Thomas Gleixner , Palmer Dabbelt , Linux Kernel Mailing List , linux-riscv , devicetree , Guo Ren Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt parse in opensbi In-Reply-To: References: <20220129162726.1154501-1-guoren@kernel.org> <20220129162726.1154501-3-guoren@kernel.org> <87r18qxui9.wl-maz@kernel.org> <35b1838d-ef80-1816-46f6-9cba7afc813e@sholland.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: guoren@kernel.org, samuel@sholland.org, anup@brainfault.org, tglx@linutronix.de, palmer@dabbelt.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, guoren@linux.alibaba.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Jan 2022 04:39:34 +0000, Guo Ren wrote: > > On Sun, Jan 30, 2022 at 10:50 AM Samuel Holland wrote: > > > > On 1/29/22 8:08 PM, Guo Ren wrote: > > > On Sun, Jan 30, 2022 at 2:32 AM Marc Zyngier wrote: > > >> > > >> On Sat, 29 Jan 2022 16:27:26 +0000, > > >> guoren@kernel.org wrote: > > >>> > > >>> From: Guo Ren > > >>> > > >>> The thead,c900-plic has been used in opensbi to distinguish > > >>> PLIC [1]. Although PLICs have the same behaviors in Linux, > > >>> they are different hardware with some custom initializing in > > >>> firmware(opensbi). > > >>> > > >>> [1]: https://github.com/riscv-software-src/opensbi/commit/78c2b19218bd62653b9fb31623a42ced45f38ea6 > > >>> > > >>> Signed-off-by: Guo Ren > > >>> Cc: Anup Patel > > >>> Cc: Marc Zyngier > > >>> Cc: Palmer Dabbelt > > >>> Cc: Samuel Holland > > >>> Cc: Thomas Gleixner > > >>> --- > > >>> drivers/irqchip/irq-sifive-plic.c | 25 +++++++++++++++++++++++-- > > >>> 1 file changed, 23 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c > > >>> index 259065d271ef..245655928076 100644 > > >>> --- a/drivers/irqchip/irq-sifive-plic.c > > >>> +++ b/drivers/irqchip/irq-sifive-plic.c > > >>> @@ -172,7 +172,7 @@ static void plic_irq_eoi(struct irq_data *d) > > >>> } > > >>> } > > >>> > > >>> -static struct irq_chip plic_chip = { > > >>> +static struct irq_chip sifive_plic_chip = { > > >>> .name = "SiFive PLIC", > > >>> .irq_mask = plic_irq_mask, > > >>> .irq_unmask = plic_irq_unmask, > > >>> @@ -182,12 +182,24 @@ static struct irq_chip plic_chip = { > > >>> #endif > > >>> }; > > >>> > > >>> +static struct irq_chip thead_plic_chip = { > > >>> + .name = "T-Head PLIC", > > >>> + .irq_mask = plic_irq_mask, > > >>> + .irq_unmask = plic_irq_unmask, > > >>> + .irq_eoi = plic_irq_eoi, > > >>> +#ifdef CONFIG_SMP > > >>> + .irq_set_affinity = plic_set_affinity, > > >>> +#endif > > >>> +}; > > >> > > >> For pure entertainment, let's compare the two structures: > > >> > > >> static struct irq_chip plic_chip = { > > >> .name = "SiFive PLIC", > > >> .irq_mask = plic_irq_mask, > > >> .irq_unmask = plic_irq_unmask, > > >> .irq_eoi = plic_irq_eoi, > > >> #ifdef CONFIG_SMP > > >> .irq_set_affinity = plic_set_affinity, > > >> #endif > > >> }; > > >> > > >> Oh wait: a string. Must be really important. Not. > > > No, pls see below comment. > > > > > >> > > >>> + > > >>> +static struct irq_chip *def_plic_chip = &sifive_plic_chip; > > >>> + > > >>> static int plic_irqdomain_map(struct irq_domain *d, unsigned int irq, > > >>> irq_hw_number_t hwirq) > > >>> { > > >>> struct plic_priv *priv = d->host_data; > > >>> > > >>> - irq_domain_set_info(d, irq, hwirq, &plic_chip, d->host_data, > > >>> + irq_domain_set_info(d, irq, hwirq, def_plic_chip, d->host_data, > > >>> handle_fasteoi_irq, NULL, NULL); > > >>> irq_set_noprobe(irq); > > >>> irq_set_affinity(irq, &priv->lmask); > > >>> @@ -396,5 +408,14 @@ static int __init plic_init(struct device_node *node, > > >>> return error; > > >>> } > > >>> > > >>> +static int __init thead_c900_plic_init(struct device_node *node, > > >>> + struct device_node *parent) > > >>> +{ > > >>> + def_plic_chip = &thead_plic_chip; > > >>> + > > >>> + return plic_init(node, parent); > > >>> +} > > >>> + > > >>> IRQCHIP_DECLARE(sifive_plic, "sifive,plic-1.0.0", plic_init); > > >>> IRQCHIP_DECLARE(riscv_plic0, "riscv,plic0", plic_init); /* for legacy systems */ > > >>> +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", thead_c900_plic_init); > > >> > > >> Sorry, but I can't see any point to this patch. > > > You didn't see the link I've put in the patch. In that opensbi patch: No. If you can't explain why you need this in the commit message, why should I reverse engineer that from some obscure piece of firmware? > > > intc: interrupt-controller@10000000 { > > > #interrupt-cells = <1>; > > > - compatible = "riscv,plic0"; > > > + compatible = "allwinner,sun20i-d1-plic", > > > + "thead,c900-plic"; > > > > > > +#define THEAD_PLIC_CTRL_REG 0x1ffffc > > > + > > > +static void thead_plic_plat_init(struct plic_data *pd) > > > +{ > > > + writel_relaxed(BIT(0), (void *)pd->addr + THEAD_PLIC_CTRL_REG); > > > +} > > > + > > > static const struct fdt_match irqchip_plic_match[] = { > > > { .compatible = "riscv,plic0" }, > > > { .compatible = "sifive,plic-1.0.0" }, > > > + { .compatible = "thead,c900-plic", > > > + .data = thead_plic_plat_init }, > > > { }, > > > }; > > > > > > We've changed the compatible name for thead,c900-plic, and there is no > > > riscv,plic0 / sifive,plic-1.0.0 in dts. Without the patch, the newest > > > opensbi + newest Linux would be broken in the Allwinner D1 dev board. So the firmware changes things in incompatible ways. Why does it matter to Linux? Why isn't the fix directly applied to the firmware instead? Why isn't the riscv,plic0 fallback appropriate? > > Yes, some patch is still necessary, because the hardware is indeed incompatible > > with riscv,plic0. However, this driver does not care about the difference. So > > all you need to do is hook up the existing code to the new compatible: > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > I think we should give clear info in /proc/interrupts. I hope we could > keep thead_plic_init. Why? There is no material difference at the driver level, and /proc/interrupts won't be the target of a branding exercise (which this series seems to be all about). M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD763C433EF for ; Sun, 30 Jan 2022 10:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gT25yb8wQLdWgkWAaHziP8NA4v9Uy6CxH8jFhCpSk2k=; b=ukBiBEu8r7RPTV dyJ+38U/XPlJCEW2GlRXnuRQ97XGb523t/nB1ggrj7J78QOp4ZbbvtqwSGoMWJICxncD7u0mcW3He 5a0r3cl18n/dU3Z0N35MVGVbpU4muU4q1/qQP44dT+p47LTS/hpe8++/plBh0MPN1taq41MYA66fC 7GDnFhUoxtp4f/ZtaLmdkiJ/vDO/SFkHkzwWq50VQTB9uaeWbJ5QS6HWnqSo5kCNAlVRhEa8K8W4b LTYO0QDWiGnTESnVMWqqbeydpjdOOSr0H35zRWECFcXSG67BvypXzpgx7HVHqVV+1BFTC0kX6Wrt/ 4qXF0rmEgjUJLCqdZ9OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nE7S5-006M5Q-1E; Sun, 30 Jan 2022 10:28:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nE7S1-006M3t-8L for linux-riscv@lists.infradead.org; Sun, 30 Jan 2022 10:28:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4956A61126; Sun, 30 Jan 2022 10:28:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FD29C340E4; Sun, 30 Jan 2022 10:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643538523; bh=JScouu7QJzKlX9zxN9+gJC2kurFCaqhYhzCffJo5CmY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UO1SMJcNJgX2LrIsWjjT4ryauQ1+KZ1t4buAgyl08ZK9ezEUsorn/xeZNdyEJlSrO eIm8CHvEVOJLGXMoYNPBu1QJuFBUX8bKG/T9Zb4bH5e1s05R7KeuRMExjHKwxjUkY4 93Ad77S1psNZY/tBpaw+E6a59SLOtloEnP0jA34G1gDYgNrG9aZ3gsq9M1lM37lv9s jErY1u1XUd7ZvHfOlJPLznacSu0fAa5fR7Jqpgz26/AAWpBXFppcmnsBYYNEbleSI7 2NeFt7YSLeSu0QJTB93G4wTBr9zkcyAF6PURU3Vc914nRE3kjkx3odTpyJprt9AoZS RshTaMiOqgUew== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nE7Rp-00493J-K8; Sun, 30 Jan 2022 10:28:41 +0000 Date: Sun, 30 Jan 2022 10:28:41 +0000 Message-ID: <87o83ty0ti.wl-maz@kernel.org> From: Marc Zyngier To: Guo Ren Cc: Samuel Holland , Anup Patel , Thomas Gleixner , Palmer Dabbelt , Linux Kernel Mailing List , linux-riscv , devicetree , Guo Ren Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic dt parse in opensbi In-Reply-To: References: <20220129162726.1154501-1-guoren@kernel.org> <20220129162726.1154501-3-guoren@kernel.org> <87r18qxui9.wl-maz@kernel.org> <35b1838d-ef80-1816-46f6-9cba7afc813e@sholland.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: guoren@kernel.org, samuel@sholland.org, anup@brainfault.org, tglx@linutronix.de, palmer@dabbelt.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, guoren@linux.alibaba.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220130_022853_428076_34C07A5B X-CRM114-Status: GOOD ( 41.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, 30 Jan 2022 04:39:34 +0000, Guo Ren wrote: > > On Sun, Jan 30, 2022 at 10:50 AM Samuel Holland wrote: > > > > On 1/29/22 8:08 PM, Guo Ren wrote: > > > On Sun, Jan 30, 2022 at 2:32 AM Marc Zyngier wrote: > > >> > > >> On Sat, 29 Jan 2022 16:27:26 +0000, > > >> guoren@kernel.org wrote: > > >>> > > >>> From: Guo Ren > > >>> > > >>> The thead,c900-plic has been used in opensbi to distinguish > > >>> PLIC [1]. Although PLICs have the same behaviors in Linux, > > >>> they are different hardware with some custom initializing in > > >>> firmware(opensbi). > > >>> > > >>> [1]: https://github.com/riscv-software-src/opensbi/commit/78c2b19218bd62653b9fb31623a42ced45f38ea6 > > >>> > > >>> Signed-off-by: Guo Ren > > >>> Cc: Anup Patel > > >>> Cc: Marc Zyngier > > >>> Cc: Palmer Dabbelt > > >>> Cc: Samuel Holland > > >>> Cc: Thomas Gleixner > > >>> --- > > >>> drivers/irqchip/irq-sifive-plic.c | 25 +++++++++++++++++++++++-- > > >>> 1 file changed, 23 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c > > >>> index 259065d271ef..245655928076 100644 > > >>> --- a/drivers/irqchip/irq-sifive-plic.c > > >>> +++ b/drivers/irqchip/irq-sifive-plic.c > > >>> @@ -172,7 +172,7 @@ static void plic_irq_eoi(struct irq_data *d) > > >>> } > > >>> } > > >>> > > >>> -static struct irq_chip plic_chip = { > > >>> +static struct irq_chip sifive_plic_chip = { > > >>> .name = "SiFive PLIC", > > >>> .irq_mask = plic_irq_mask, > > >>> .irq_unmask = plic_irq_unmask, > > >>> @@ -182,12 +182,24 @@ static struct irq_chip plic_chip = { > > >>> #endif > > >>> }; > > >>> > > >>> +static struct irq_chip thead_plic_chip = { > > >>> + .name = "T-Head PLIC", > > >>> + .irq_mask = plic_irq_mask, > > >>> + .irq_unmask = plic_irq_unmask, > > >>> + .irq_eoi = plic_irq_eoi, > > >>> +#ifdef CONFIG_SMP > > >>> + .irq_set_affinity = plic_set_affinity, > > >>> +#endif > > >>> +}; > > >> > > >> For pure entertainment, let's compare the two structures: > > >> > > >> static struct irq_chip plic_chip = { > > >> .name = "SiFive PLIC", > > >> .irq_mask = plic_irq_mask, > > >> .irq_unmask = plic_irq_unmask, > > >> .irq_eoi = plic_irq_eoi, > > >> #ifdef CONFIG_SMP > > >> .irq_set_affinity = plic_set_affinity, > > >> #endif > > >> }; > > >> > > >> Oh wait: a string. Must be really important. Not. > > > No, pls see below comment. > > > > > >> > > >>> + > > >>> +static struct irq_chip *def_plic_chip = &sifive_plic_chip; > > >>> + > > >>> static int plic_irqdomain_map(struct irq_domain *d, unsigned int irq, > > >>> irq_hw_number_t hwirq) > > >>> { > > >>> struct plic_priv *priv = d->host_data; > > >>> > > >>> - irq_domain_set_info(d, irq, hwirq, &plic_chip, d->host_data, > > >>> + irq_domain_set_info(d, irq, hwirq, def_plic_chip, d->host_data, > > >>> handle_fasteoi_irq, NULL, NULL); > > >>> irq_set_noprobe(irq); > > >>> irq_set_affinity(irq, &priv->lmask); > > >>> @@ -396,5 +408,14 @@ static int __init plic_init(struct device_node *node, > > >>> return error; > > >>> } > > >>> > > >>> +static int __init thead_c900_plic_init(struct device_node *node, > > >>> + struct device_node *parent) > > >>> +{ > > >>> + def_plic_chip = &thead_plic_chip; > > >>> + > > >>> + return plic_init(node, parent); > > >>> +} > > >>> + > > >>> IRQCHIP_DECLARE(sifive_plic, "sifive,plic-1.0.0", plic_init); > > >>> IRQCHIP_DECLARE(riscv_plic0, "riscv,plic0", plic_init); /* for legacy systems */ > > >>> +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", thead_c900_plic_init); > > >> > > >> Sorry, but I can't see any point to this patch. > > > You didn't see the link I've put in the patch. In that opensbi patch: No. If you can't explain why you need this in the commit message, why should I reverse engineer that from some obscure piece of firmware? > > > intc: interrupt-controller@10000000 { > > > #interrupt-cells = <1>; > > > - compatible = "riscv,plic0"; > > > + compatible = "allwinner,sun20i-d1-plic", > > > + "thead,c900-plic"; > > > > > > +#define THEAD_PLIC_CTRL_REG 0x1ffffc > > > + > > > +static void thead_plic_plat_init(struct plic_data *pd) > > > +{ > > > + writel_relaxed(BIT(0), (void *)pd->addr + THEAD_PLIC_CTRL_REG); > > > +} > > > + > > > static const struct fdt_match irqchip_plic_match[] = { > > > { .compatible = "riscv,plic0" }, > > > { .compatible = "sifive,plic-1.0.0" }, > > > + { .compatible = "thead,c900-plic", > > > + .data = thead_plic_plat_init }, > > > { }, > > > }; > > > > > > We've changed the compatible name for thead,c900-plic, and there is no > > > riscv,plic0 / sifive,plic-1.0.0 in dts. Without the patch, the newest > > > opensbi + newest Linux would be broken in the Allwinner D1 dev board. So the firmware changes things in incompatible ways. Why does it matter to Linux? Why isn't the fix directly applied to the firmware instead? Why isn't the riscv,plic0 fallback appropriate? > > Yes, some patch is still necessary, because the hardware is indeed incompatible > > with riscv,plic0. However, this driver does not care about the difference. So > > all you need to do is hook up the existing code to the new compatible: > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init); > I think we should give clear info in /proc/interrupts. I hope we could > keep thead_plic_init. Why? There is no material difference at the driver level, and /proc/interrupts won't be the target of a branding exercise (which this series seems to be all about). M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv