[PATCH] disable modular TCG on Darwin

[PATCH] disable modular TCG on Darwin

[Paolo Bonzini]

Accelerator modularity does not work on Darwin:

ld: illegal thread local variable reference to regular symbol _current_cpu for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Fix by avoiding modular TCG builds.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index b2e8731410..a1f767e250 100644
--- a/meson.build
+++ b/meson.build
@@ -92,7 +92,11 @@ if cpu in ['x86', 'x86_64']
   }
 endif
 
-modular_tcg = ['i386-softmmu', 'x86_64-softmmu']
+modular_tcg = []
+# Darwin does not support references to thread-local variables in modules
+if target != 'darwin'
+  modular_tcg = ['i386-softmmu', 'x86_64-softmmu']
+endif
 
 edk2_targets = [ 'arm-softmmu', 'aarch64-softmmu', 'i386-softmmu', 'x86_64-softmmu' ]
 install_edk2_blobs = false
-- 
2.31.1

Re: [PATCH] disable modular TCG on Darwin

[Alex Bennée]

Paolo Bonzini <pbonzini@redhat.com> writes:

> Accelerator modularity does not work on Darwin:
>
> ld: illegal thread local variable reference to regular symbol _current_cpu for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Fix by avoiding modular TCG builds.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Queued to HEAD, thanks.

-- 
Alex Bennée