From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints Date: 20 Jul 2020 14:13:35 +0900 Message-ID: <87o8oazs5a.wl-kuninori.morimoto.gx@renesas.com> References: <1595135417-16589-1-git-send-email-spujar@nvidia.com> <1595135417-16589-4-git-send-email-spujar@nvidia.com> <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, nwartikar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Sameer > >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c > >> index 1e20562..b1903f9 100644 > >> --- a/sound/soc/generic/audio-graph-card.c > >> +++ b/sound/soc/generic/audio-graph-card.c > >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top, > >> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, > >> struct device_node *cpu_ep, > >> struct device_node *codec_ep, > >> - struct link_info *li, > >> - int dup_codec) > >> + struct link_info *li) > > This patch breaks DPCM connection which is used for MIXer > > Could you please elaborate a bit more as to what is broken with this? > The problem I am trying to solve here is to have multiple endpoints > for Codec port. For example MIXer, it is like below. If you removes "dup_codec", it breaks MIXer and/or TDM split mode. CPU0 ---+---- DAI | CPU1 ---+ cpu { ports { port@0 { cpu_0: endpoint { remote-endpoint = <&codec_0>; }; }; port@1 { cpu_1: endpoint { remote-endpoint = <&codec_1>; }; }; }; }; codec { port { codec_0: endpoint { remote-endpoint = <&cpu_0>; }; codec_1: endpoint { remote-endpoint = <&cpu_1>; }; } }; Thank you for your help !! Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46790C433DF for ; Mon, 20 Jul 2020 05:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24E1B22B4E for ; Mon, 20 Jul 2020 05:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726042AbgGTFNi (ORCPT ); Mon, 20 Jul 2020 01:13:38 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:24058 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725287AbgGTFNh (ORCPT ); Mon, 20 Jul 2020 01:13:37 -0400 Date: 20 Jul 2020 14:13:35 +0900 X-IronPort-AV: E=Sophos;i="5.75,373,1589209200"; d="scan'208";a="52564349" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 20 Jul 2020 14:13:35 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 8018B400753D; Mon, 20 Jul 2020 14:13:35 +0900 (JST) Message-ID: <87o8oazs5a.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sameer Pujar Cc: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints In-Reply-To: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> References: <1595135417-16589-1-git-send-email-spujar@nvidia.com> <1595135417-16589-4-git-send-email-spujar@nvidia.com> <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sameer > >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c > >> index 1e20562..b1903f9 100644 > >> --- a/sound/soc/generic/audio-graph-card.c > >> +++ b/sound/soc/generic/audio-graph-card.c > >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top, > >> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, > >> struct device_node *cpu_ep, > >> struct device_node *codec_ep, > >> - struct link_info *li, > >> - int dup_codec) > >> + struct link_info *li) > > This patch breaks DPCM connection which is used for MIXer > > Could you please elaborate a bit more as to what is broken with this? > The problem I am trying to solve here is to have multiple endpoints > for Codec port. For example MIXer, it is like below. If you removes "dup_codec", it breaks MIXer and/or TDM split mode. CPU0 ---+---- DAI | CPU1 ---+ cpu { ports { port@0 { cpu_0: endpoint { remote-endpoint = <&codec_0>; }; }; port@1 { cpu_1: endpoint { remote-endpoint = <&codec_1>; }; }; }; }; codec { port { codec_0: endpoint { remote-endpoint = <&cpu_0>; }; codec_1: endpoint { remote-endpoint = <&cpu_1>; }; } }; Thank you for your help !! Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D9CC433E0 for ; Mon, 20 Jul 2020 05:14:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9205822BEF for ; Mon, 20 Jul 2020 05:14:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="p4vAL40z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9205822BEF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1AC9683E; Mon, 20 Jul 2020 07:13:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1AC9683E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595222084; bh=zlyYwFn3+Nc6/YaYjdvsiimhUIiPVbViqkUr9WwZFRc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=p4vAL40zBz1xIWMoMFDwSihW6cXBIeLqR+PcjStaOGjGEVbK25PxF5HUzxx2Q5BuH uZYicGr6HYdJKGzQ22fvPIH+vYzKedbYibnd6+VmBhVAvpv0t7U8d8SccX1pZ2BD7h CGIsL/Z5lmL6JrLO5N39X5rbJJsAgXUksQc6nAzU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6CD8CF800E0; Mon, 20 Jul 2020 07:13:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 33EE4F800F5; Mon, 20 Jul 2020 07:13:52 +0200 (CEST) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa1.perex.cz (Postfix) with ESMTP id 386C4F800BF for ; Mon, 20 Jul 2020 07:13:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 386C4F800BF Date: 20 Jul 2020 14:13:35 +0900 X-IronPort-AV: E=Sophos;i="5.75,373,1589209200"; d="scan'208";a="52564349" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 20 Jul 2020 14:13:35 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 8018B400753D; Mon, 20 Jul 2020 14:13:35 +0900 (JST) Message-ID: <87o8oazs5a.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Sameer Pujar Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints In-Reply-To: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> References: <1595135417-16589-1-git-send-email-spujar@nvidia.com> <1595135417-16589-4-git-send-email-spujar@nvidia.com> <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com> <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: jonathanh@nvidia.com, nicoleotsuka@gmail.com, alsa-devel@alsa-project.org, atalambedu@nvidia.com, swarren@nvidia.com, linux-kernel@vger.kernel.org, nwartikar@nvidia.com, lgirdwood@gmail.com, robh+dt@kernel.org, tiwai@suse.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Sameer > >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c > >> index 1e20562..b1903f9 100644 > >> --- a/sound/soc/generic/audio-graph-card.c > >> +++ b/sound/soc/generic/audio-graph-card.c > >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top, > >> static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, > >> struct device_node *cpu_ep, > >> struct device_node *codec_ep, > >> - struct link_info *li, > >> - int dup_codec) > >> + struct link_info *li) > > This patch breaks DPCM connection which is used for MIXer > > Could you please elaborate a bit more as to what is broken with this? > The problem I am trying to solve here is to have multiple endpoints > for Codec port. For example MIXer, it is like below. If you removes "dup_codec", it breaks MIXer and/or TDM split mode. CPU0 ---+---- DAI | CPU1 ---+ cpu { ports { port@0 { cpu_0: endpoint { remote-endpoint = <&codec_0>; }; }; port@1 { cpu_1: endpoint { remote-endpoint = <&codec_1>; }; }; }; }; codec { port { codec_0: endpoint { remote-endpoint = <&cpu_0>; }; codec_1: endpoint { remote-endpoint = <&cpu_1>; }; } }; Thank you for your help !! Best regards --- Kuninori Morimoto