All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: <kuhn.chenqun@huawei.com>
Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Euler Robot <euler.robot@huawei.com>
Subject: Re: [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v()
Date: Thu, 27 Feb 2020 19:01:08 +0100	[thread overview]
Message-ID: <87o8tjdi57.fsf@secure.laptop> (raw)
In-Reply-To: <20200226084647.20636-11-kuhn.chenqun@huawei.com> (kuhn chenqun's message of "Wed, 26 Feb 2020 16:46:44 +0800")

<kuhn.chenqun@huawei.com> wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> The "ret" has been assigned in all branches. It didn't need to be
>  assigned separately.
>
> Clang static code analyzer show warning:
>   migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read
>                 ret = 0;
>                 ^     ~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>

I thought I had already reviewed it.

Reviewed-by: Juan Quintela <quintela@redhat.com>
queued



  reply	other threads:[~2020-02-27 18:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  8:46 [PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run() kuhn.chenqun
2020-02-26  9:51   ` Kevin Wolf
2020-02-26 10:21     ` Chenqun (kuhn)
2020-02-26 10:36       ` Kevin Wolf
2020-02-26 10:41         ` Chenqun (kuhn)
2020-02-26  8:46 ` [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open() kuhn.chenqun
2020-02-26  9:54   ` Kevin Wolf
2020-02-27  1:49     ` Chenqun (kuhn)
2020-02-27 10:30       ` Kevin Wolf
2020-02-27 11:28         ` Chenqun (kuhn)
2020-02-28  7:30         ` Chenqun (kuhn)
2020-02-28 10:55           ` Kevin Wolf
2020-02-29  2:21             ` Chenqun (kuhn)
2020-02-26  8:46 ` [PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock() kuhn.chenqun
2020-02-26 10:37   ` Kevin Wolf
2020-02-26  8:46 ` [PATCH v2 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() kuhn.chenqun
2020-02-26  8:51   ` Philippe Mathieu-Daudé
2020-02-26 14:15   ` Francisco Iglesias
2020-02-26 17:56   ` Alistair Francis
2020-02-26  8:46 ` [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() kuhn.chenqun
2020-02-27 18:01   ` Juan Quintela [this message]
2020-02-26  8:46 ` [PATCH v2 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() kuhn.chenqun
2020-02-26  8:46 ` [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements kuhn.chenqun
2020-03-09 10:13   ` Gerd Hoffmann
2020-02-26  8:46 ` [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() kuhn.chenqun
2020-02-26  8:52   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8tjdi57.fsf@secure.laptop \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=euler.robot@huawei.com \
    --cc=kuhn.chenqun@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.