All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: "Vehmanen, Kai" <kai.vehmanen@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached
Date: Sun, 02 Feb 2020 12:00:09 +0200	[thread overview]
Message-ID: <87o8uh48d2.fsf@intel.com> (raw)
In-Reply-To: <158058418804.15137.11874631524443965282@skylake-alporthouse-com>

On Sat, 01 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-02-01 12:36:46)
>> On Sat, 01 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > If the display is not driving any pipes, we cannot change the bclk and
>> > doing so risks chasing NULL pointers:
>> 
>> Does this mean we can't probe hda if there are no displays attached at
>> boot on GLK?
>
> We do, but the question is should we. If we say there are no pipes, then
> how can there be a HDMI/other audio link?

I'll let Kai fill in the gaps, but my understanding is that you can't
even probe it then. I.e. it won't work when you *do* attach the cable.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-02-02 10:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01  9:46 [Intel-gfx] [PATCH] drm/i915/audio: Skip the cdclk modeset if no pipes attached Chris Wilson
2020-02-01 10:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-01 10:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-01 12:36 ` [Intel-gfx] [PATCH] " Jani Nikula
2020-02-01 19:09   ` Chris Wilson
2020-02-02 10:00     ` Jani Nikula [this message]
2020-02-03 13:23 ` Ville Syrjälä
2020-02-03 13:28   ` Chris Wilson
2020-02-03 14:46   ` Kai Vehmanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8uh48d2.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kai.vehmanen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.