From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F64C32771 for ; Thu, 16 Jan 2020 00:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5597A24656 for ; Thu, 16 Jan 2020 00:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729730AbgAPAxk (ORCPT ); Wed, 15 Jan 2020 19:53:40 -0500 Received: from relmlor1.renesas.com ([210.160.252.171]:22708 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726513AbgAPAxk (ORCPT ); Wed, 15 Jan 2020 19:53:40 -0500 Date: 16 Jan 2020 09:53:38 +0900 X-IronPort-AV: E=Sophos;i="5.70,323,1574089200"; d="scan'208";a="36784950" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 16 Jan 2020 09:53:38 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 7BA9340083DC; Thu, 16 Jan 2020 09:53:38 +0900 (JST) Message-ID: <87o8v41ast.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Marek Vasut Cc: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org, Fabio Estevam , Igor Opaniuk , Marcel Ziswiler , Oleksandr Suvorov Subject: Re: [PATCH] regulator: core: fixup regulator_is_equal() helper In-Reply-To: <66c63cfc-840b-8c57-8e70-f2f2824462c8@denx.de> References: <87ftgh8qnn.wl-kuninori.morimoto.gx@renesas.com> <20200115141235.GK3897@sirena.org.uk> <66c63cfc-840b-8c57-8e70-f2f2824462c8@denx.de> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Marek > >> From: Kuninori Morimoto > >> > >> commit b059b7e0ec320 ("regulator: core: Add regulator_is_equal() helper") > >> added regulator_is_equal() helper. > >> But it has unneeded ";" if CONFIG_REGULATOR was not defined. > >> Thus, we will have this error > > > > Thanks but Stephen already sent a fix. > > Sorry for the mess again. I could confirm it on mark/for-5.6 branch. Thank you about it ! Thank you for your help !! Best regards --- Kuninori Morimoto