From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/binutils: extend the 2.28 default to thumb mode
Date: Fri, 01 Jun 2018 19:32:47 +0200 [thread overview]
Message-ID: <87o9guxvi8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180601172629.13505-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Fri, 1 Jun 2018 19:26:29 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Commit 17f352ac (package/binutils: default to 2.29 for Cortex-M targets)
> made the default version 2.28 (and not 2.29!) when the target is an
> arm-v7m CPU.
> However, the real trigger is compilation in Thumb mode, not the fact
> that the target is v7m.
> The fact that it was noticed on a v7m target is because Thumb is the
> only mode valid on those CPUs.
> Tighten the defaults to 2.28 for Thumb and Thumb2 modes.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Laurent GONZALEZ <br22@gezedo.com>
> Cc: Christophe Priouzeau <christophe.priouzeau@st.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> ---
> package/binutils/Config.in.host | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index 4e578ef2ef..de229895c1 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -2,7 +2,8 @@ comment "Binutils Options"
> choice
> prompt "Binutils Version"
> - default BR2_BINUTILS_VERSION_2_28_X if BR2_ARM_CPU_ARMV7M
> + default BR2_BINUTILS_VERSION_2_28_X if BR2_ARM_INSTRUCTIONS_THUMB
> + default BR2_BINUTILS_VERSION_2_28_X if BR2_ARM_INSTRUCTIONS_THUMB2
> default BR2_BINUTILS_VERSION_2_29_X if !BR2_arc
> default BR2_BINUTILS_VERSION_ARC if BR2_arc
> help
Committed, thanks. Will you also send a patch to update the comment in
linux/Config.in?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-06-01 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 17:26 [Buildroot] [PATCH] package/binutils: extend the 2.28 default to thumb mode Yann E. MORIN
2018-06-01 17:32 ` Peter Korsgaard [this message]
2018-06-17 15:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9guxvi8.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.