From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1fG1dw-0002Wv-Vy
	for qemu-devel@nongnu.org; Tue, 08 May 2018 08:22:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1fG1dt-0005Db-Pj
	for qemu-devel@nongnu.org; Tue, 08 May 2018 08:22:56 -0400
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42926 helo=mx1.redhat.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1fG1dt-0005DB-Ln
	for qemu-devel@nongnu.org; Tue, 08 May 2018 08:22:53 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1525376963-79623-37-git-send-email-mst@redhat.com> (Michael
	S. Tsirkin's message of "Thu, 3 May 2018 22:51:15 +0300")
References: <1525376963-79623-1-git-send-email-mst@redhat.com>
	<1525376963-79623-37-git-send-email-mst@redhat.com>
Reply-To: quintela@redhat.com
Date: Tue, 08 May 2018 14:25:07 +0200
Message-ID: <87o9hq8hcs.fsf@secure.laptop>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 36/67] migration: add include directory
 headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, eblake@redhat.com, berrange@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Nack.

This are _internal_ files, that shouldn't be used anywere elese.

Except .... that we need them to write tests.  We only have two scopes
on qemu:
- internal: only for the subsystem we are at in
- pubilc: they can be used everywhere

So, tests came in a strange class here, because they need internal
implementation, but they are not in the proper directory due to the way
we do tests.

I *think* that using complete paths is the only reasonable way of doing
this.

Thanks, Juan.