From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 14/16] arm64: dts: marvell: armada-37xx: add second UART port Date: Fri, 06 Oct 2017 14:49:55 +0200 Message-ID: <87o9pke8zw.fsf@free-electrons.com> References: <20171006101344.15590-1-miquel.raynal@free-electrons.com> <20171006101344.15590-15-miquel.raynal@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:57256 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbdJFMuG (ORCPT ); Fri, 6 Oct 2017 08:50:06 -0400 In-Reply-To: <20171006101344.15590-15-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Fri, 6 Oct 2017 12:13:42 +0200") Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Miquel Raynal Cc: Greg Kroah-Hartman , Linus Walleij , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Jiri Slaby , Catalin Marinas , Will Deacon , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Thomas Petazzoni , Antoine Tenart , Nadav Haklai , Wilson Ding Hi Miquel, On ven., oct. 06 2017, Miquel Raynal wrote: > Add a node in Armada 37xx DTSI file for the second UART, with a > different compatible due to its extended IP which has some > differences with the first UART already in place. > > Make use of this commit to also fully describe the first port and > use the same clear and named interrupt bindings for both ports. > > The standard UART (UART0) uses level-interrupts while the extended > UART (UART1) uses edge-triggered interrupts. > > Signed-off-by: Miquel Raynal Acked-by: Gregory CLEMENT Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index a36d667f770e..72b68f23c001 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -55,6 +55,7 @@ > > aliases { > serial0 = &uart0; > + serial1 = &uart1; > }; > > cpus { > @@ -136,7 +137,22 @@ > compatible = "marvell,armada-3700-uart"; > reg = <0x12000 0x200>; > clocks = <&xtalclk>; > - interrupts = ; > + interrupts = > + , > + , > + ; > + interrupt-names = "uart-sum", "uart-tx", "uart-rx"; > + status = "disabled"; > + }; > + > + uart1: serial@12200 { > + compatible = "marvell,armada-3700-uart-ext"; > + reg = <0x12200 0x30>; > + clocks = <&xtalclk>; > + interrupts = > + , > + ; > + interrupt-names = "uart-tx", "uart-rx"; > status = "disabled"; > }; > > -- > 2.11.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Fri, 06 Oct 2017 14:49:55 +0200 Subject: [PATCH 14/16] arm64: dts: marvell: armada-37xx: add second UART port In-Reply-To: <20171006101344.15590-15-miquel.raynal@free-electrons.com> (Miquel Raynal's message of "Fri, 6 Oct 2017 12:13:42 +0200") References: <20171006101344.15590-1-miquel.raynal@free-electrons.com> <20171006101344.15590-15-miquel.raynal@free-electrons.com> Message-ID: <87o9pke8zw.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Miquel, On ven., oct. 06 2017, Miquel Raynal wrote: > Add a node in Armada 37xx DTSI file for the second UART, with a > different compatible due to its extended IP which has some > differences with the first UART already in place. > > Make use of this commit to also fully describe the first port and > use the same clear and named interrupt bindings for both ports. > > The standard UART (UART0) uses level-interrupts while the extended > UART (UART1) uses edge-triggered interrupts. > > Signed-off-by: Miquel Raynal Acked-by: Gregory CLEMENT Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > index a36d667f770e..72b68f23c001 100644 > --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi > @@ -55,6 +55,7 @@ > > aliases { > serial0 = &uart0; > + serial1 = &uart1; > }; > > cpus { > @@ -136,7 +137,22 @@ > compatible = "marvell,armada-3700-uart"; > reg = <0x12000 0x200>; > clocks = <&xtalclk>; > - interrupts = ; > + interrupts = > + , > + , > + ; > + interrupt-names = "uart-sum", "uart-tx", "uart-rx"; > + status = "disabled"; > + }; > + > + uart1: serial at 12200 { > + compatible = "marvell,armada-3700-uart-ext"; > + reg = <0x12200 0x30>; > + clocks = <&xtalclk>; > + interrupts = > + , > + ; > + interrupt-names = "uart-tx", "uart-rx"; > status = "disabled"; > }; > > -- > 2.11.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com