From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dI8zO-0007BL-4m for qemu-devel@nongnu.org; Tue, 06 Jun 2017 03:33:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dI8zL-000152-0h for qemu-devel@nongnu.org; Tue, 06 Jun 2017 03:33:18 -0400 From: Markus Armbruster References: <1496531612-22166-1-git-send-email-mdroth@linux.vnet.ibm.com> <1496531612-22166-2-git-send-email-mdroth@linux.vnet.ibm.com> Date: Tue, 06 Jun 2017 09:33:10 +0200 In-Reply-To: <1496531612-22166-2-git-send-email-mdroth@linux.vnet.ibm.com> (Michael Roth's message of "Sat, 3 Jun 2017 18:13:31 -0500") Message-ID: <87o9u11sg9.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 1/2] tests: check-qom-proplist: add checks for cmdline-created objects List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, "Dr. David Alan Gilbert" Michael Roth writes: > check-qom-proplist originally added tests for verifying that > object-creation helpers object_new_with_{props,propv} behaved in > similar fashion to the "traditional" method involving setting each > individual property separately after object creation rather than > via a single call. > > Another similar "helper" for creating Objects exists in the form of > objects specified via -object command-line parameters. By that > rationale, we extend check-qom-proplist to include similar checks > for command-line-created objects by employing the same > qemu_opts_parse()-based parsing the vl.c employs. > > This parser has a side-effect of parsing the object's options into > a QemuOpt structure and registering this in the global QemuOptsList > using the Object's ID. This can conflict with future Object instances > that attempt to use the same ID if we don't ensure this is cleaned > up as part of Object finalization, so we include a FIXME stub to test > for this case, which will then be resolved in a subsequent patch. > > Suggested-by: Daniel Berrange > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Cc: Eric Blake > Cc: Daniel Berrange > Cc: qemu-stable@nongnu.org > Signed-off-by: Michael Roth > Reviewed-by: Markus Armbruster > --- > tests/check-qom-proplist.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index a16cefc..e3f56ca 100644 > --- a/tests/check-qom-proplist.c > +++ b/tests/check-qom-proplist.c > @@ -23,6 +23,9 @@ > #include "qapi/error.h" > #include "qom/object.h" > #include "qemu/module.h" > +#include "qemu/option.h" > +#include "qemu/config-file.h" > +#include "qom/object_interfaces.h" > > > #define TYPE_DUMMY "qemu-dummy" > @@ -162,6 +165,10 @@ static const TypeInfo dummy_info = { > .instance_finalize = dummy_finalize, > .class_size = sizeof(DummyObjectClass), > .class_init = dummy_class_init, > + .interfaces = (InterfaceInfo[]) { > + { TYPE_USER_CREATABLE }, > + { } > + } > }; > > > @@ -320,6 +327,14 @@ static const TypeInfo dummy_backend_info = { > .class_size = sizeof(DummyBackendClass), > }; > > +static QemuOptsList qemu_object_opts = { > + .name = "object", > + .implied_opt_name = "qom-type", > + .head = QTAILQ_HEAD_INITIALIZER(qemu_object_opts.head), > + .desc = { > + { } > + }, > +}; > > > static void test_dummy_createv(void) > @@ -388,6 +403,45 @@ static void test_dummy_createlist(void) > object_unparent(OBJECT(dobj)); > } > > +static void test_dummy_createcmdl(void) > +{ > + QemuOpts *opts; > + DummyObject *dobj; > + Error *err = NULL; > + const char *params = TYPE_DUMMY \ > + ",id=dev0," \ > + "bv=yes,sv=Hiss hiss hiss,av=platypus"; > + > + qemu_add_opts(&qemu_object_opts); > + opts = qemu_opts_parse(&qemu_object_opts, params, true, &err); > + g_assert(err == NULL); > + g_assert(opts); > + > + dobj = DUMMY_OBJECT(user_creatable_add_opts(opts, &err)); > + g_assert(err == NULL); > + g_assert(dobj); > + g_assert_cmpstr(dobj->sv, ==, "Hiss hiss hiss"); > + g_assert(dobj->bv == true); > + g_assert(dobj->av == DUMMY_PLATYPUS); > + > + user_creatable_del("dev0", &err); > + g_assert(err == NULL); > + error_free(err); > + > + /* cmdline-parsing via qemu_opts_parse() results in a QemuOpts entry Series applied with this end of the comment winged as well. Thanks! > + * corresponding to the Object's ID to be added to the QemuOptsList > + * for objects. To avoid having this entry conflict with future > + * Objects using the same ID (which can happen in cases where > + * qemu_opts_parse() is used to parse the object params, such as > + * with hmp_object_add() at the time of this comment), we need to > + * check for this in user_creatable_del() and remove the QemuOpts if > + * it is present. > + * > + * FIXME: add an assert to verify that the QemuOpts is cleaned up > + * once the corresponding cleanup code is added. > + */ > +} > + > static void test_dummy_badenum(void) > { > Error *err = NULL; > @@ -525,6 +579,7 @@ int main(int argc, char **argv) > > g_test_add_func("/qom/proplist/createlist", test_dummy_createlist); > g_test_add_func("/qom/proplist/createv", test_dummy_createv); > + g_test_add_func("/qom/proplist/createcmdline", test_dummy_createcmdl); > g_test_add_func("/qom/proplist/badenum", test_dummy_badenum); > g_test_add_func("/qom/proplist/getenum", test_dummy_getenum); > g_test_add_func("/qom/proplist/iterator", test_dummy_iterator);