All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: "Robert E. Cochran" <ppc@mindchasers.com>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Fix page table dump build on non-Book3S
Date: Mon, 06 Mar 2017 20:28:29 +1100	[thread overview]
Message-ID: <87o9xepxdu.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <e0d44bac-65ff-fca4-437c-42872eff8842@mindchasers.com>

"Robert E. Cochran" <ppc@mindchasers.com> writes:

> On 12/01/2016 04:00 AM, Michael Ellerman wrote:
>> In the recent commit 1515ab932156 ("powerpc/mm: Dump hash table") we
>> added code to dump the hage page table. Currently this can be selected
>> to build on any platform. However it breaks the build if we're building
>> for a non-Book3S platform, because none of the hash page table related
>> defines and so on exist. So restrict it to building only on Book3S.
>>
>> Similarly in commit 8eb07b187000 ("powerpc/mm: Dump linux pagetables")
>> we added code to dump the Linux page tables, which uses some constants
>> which are only defined on Book3S - so guard those with an #ifdef.
>
>
> Hello,
>
> I was just building the mainline 4.11-rc1 tonight on an NXP P1010 / 
> e500v2 with CONFIG_PPC_PTDUMP set.
>
> I received a bunch of errors from dump_linuxpagetables.c  (as you can 
> see below).
>
> I realize now that CONFIG_PPC_PTDUMP  isn't for the e500, but I thought 
> someone might want to know that enabling it causes the build of an 
> e500v2 to fail.

Thanks. It actually should work on that config, it's just dumping the
Linux page tables.

It looks like it's just that some of the "well known" address ranges
don't exist, or don't have the same names. So it should be fixable with
some #ifdefs.

I'll fix it at some point if no one beats me to it.

cheers

      reply	other threads:[~2017-03-06  9:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  9:00 [PATCH] powerpc/mm: Fix page table dump build on non-Book3S Michael Ellerman
2016-12-03 11:28 ` Michael Ellerman
2017-03-06  4:38 ` [PATCH] " Robert E. Cochran
2017-03-06  9:28   ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9xepxdu.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=ppc@mindchasers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.