Re: [Qemu-devel] [PATCH v2 19/30] tests: fix i440fx-test leaks

From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 19/30] tests: fix i440fx-test leaks
Date: Mon, 27 Feb 2017 15:05:21 +0100	[thread overview]
Message-ID: <87o9xnenku.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170221141451.28305-20-marcandre.lureau@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 21 Feb 2017 18:14:40 +0400")

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/i440fx-test.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c
> index da2d5a53f0..e9d05c87d1 100644
> --- a/tests/i440fx-test.c
> +++ b/tests/i440fx-test.c
> @@ -134,6 +134,8 @@ static void test_i440fx_defaults(gconstpointer opaque)
>      /* 3.2.26 */
>      g_assert_cmpint(qpci_config_readb(dev, 0x93), ==, 0x00); /* TRC */
>  
> +    g_free(dev);
> +    qpci_free_pc(bus);
>      qtest_end();
>  }
>  
> @@ -270,6 +272,9 @@ static void test_i440fx_pam(gconstpointer opaque)
>          /* Verify the area is not our new mask */
>          g_assert(!verify_area(pam_area[i].start, pam_area[i].end, 0x82));
>      }
> +
> +    g_free(dev);
> +    qpci_free_pc(bus);
>      qtest_end();
>  }

Reviewed-by: Markus Armbruster <armbru@redhat.com>