From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Tue, 14 Jun 2016 22:21:23 +0200 Subject: [Buildroot] [PATCH 2/5] readline: fix installed libraries permission In-Reply-To: <1465917079-30473-2-git-send-email-gilles.chanteperdrix@xenomai.org> (Gilles Chanteperdrix's message of "Tue, 14 Jun 2016 17:11:16 +0200") References: <20160614151017.GG3060@hermes.click-hack.org> <1465917079-30473-1-git-send-email-gilles.chanteperdrix@xenomai.org> <1465917079-30473-2-git-send-email-gilles.chanteperdrix@xenomai.org> Message-ID: <87oa73v7wc.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Gilles" == Gilles Chanteperdrix writes: > In order to avoid strip failing to strip the library. > Signed-off-by: Gilles Chanteperdrix Thanks, but we already have logic in readline.mk to fix this: ifneq ($(BR2_STATIC_LIBS),y) # libraries get installed read only, so strip fails define READLINE_INSTALL_FIXUPS_SHARED chmod +w $(addprefix $(TARGET_DIR)/usr/lib/,libhistory.so.* libreadline.so.*) endef READLINE_POST_INSTALL_TARGET_HOOKS += READLINE_INSTALL_FIXUPS_SHARED endif So why this patch instead? It would be good if we could get rid of both, have you tried sending it upstream? -- Bye, Peter Korsgaard