From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1afnwm-0005RK-R0
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 08:19:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1afnwh-0000d6-P5
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 08:19:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1afnwh-0000cz-Ja
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 08:19:31 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <87wpp4m6n1.fsf@blackfin.pond.sub.org> <56E7D884.902@redhat.com>
Date: Tue, 15 Mar 2016 13:19:26 +0100
In-Reply-To: <56E7D884.902@redhat.com> (Paolo Bonzini's message of "Tue, 15
	Mar 2016 10:40:20 +0100")
Message-ID: <87oaagj5m9.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] Our use of #include is undisciplined,
	and what to do about it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 15/03/2016 10:29, Markus Armbruster wrote:
>> NEED_CPU_H further adds
>> 
>>     include/disas/bfd.h
>>     include/exec/cpu-all.h
>>     include/exec/cpu-common.h
>>     include/exec/cpu-defs.h
>>     include/exec/exec-all.h
>>     include/exec/hwaddr.h
>>     include/exec/memattrs.h
>>     include/exec/memory.h
>>     include/hw/hotplug.h
>>     include/hw/i386/apic.h
>>     include/hw/irq.h
>>     include/hw/qdev-core.h
>>     include/qemu/bitmap.h
>>     include/qemu/bitops.h
>>     include/qemu/int128.h
>>     include/qemu/log.h
>>     include/qemu/notify.h
>>     include/qemu/rcu.h
>>     include/qemu/thread-posix.h
>>     include/qemu/thread.h
>>     include/qom/cpu.h
>>     include/qom/object.h
>>     include/standard-headers/asm-x86/hyperv.h
>>     include/standard-headers/linux/types.h
>>     target-i386/cpu-qom.h
>>     target-i386/cpu.h
>>     target-i386/svm.h
>>     tcg/i386/tcg-target.h
>>     x86_64-softmmu/config-target.h
>
> FWIW, I'm going to do something about this in 2.7.  I have patches to
> remove cpu.h inclusion from qemu-common.h.

Appreciated!

> Generally though qemu-common.h needs to go. :)

Yes.  The series I hope to post today is a baby step in that direction.