From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbcBKJAF (ORCPT ); Thu, 11 Feb 2016 04:00:05 -0500 Received: from canardo.mork.no ([148.122.252.1]:53737 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcBKJAC convert rfc822-to-8bit (ORCPT ); Thu, 11 Feb 2016 04:00:02 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Andy Shevchenko Cc: Oliver Neukum , Heikki Krogerus , Felipe Balbi , Mathias Nyman , Greg KH , "linux-kernel\@vger.kernel.org" , USB Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface Organization: m References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com> <1455037283-106479-3-git-send-email-heikki.krogerus@linux.intel.com> <1455110486.8878.12.camel@suse.com> <8760xwbnwx.fsf@nemi.mork.no> Date: Thu, 11 Feb 2016 09:59:38 +0100 In-Reply-To: (Andy Shevchenko's message of "Thu, 11 Feb 2016 10:26:31 +0200") Message-ID: <87oabnaah1.fsf@nemi.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > To me out: sounds out, like printing error and return code, or > something like that. Here the case is different. > > And since we have two full switches it might be hard to have on one > screen out code and exact goto. See my point now? No, sorry. Not really. The pattern out: return whatever; is so common in the kernel that I cannot see any point starting a discussion about it: bjorn@nemi:/usr/local/src/git/linux$ git grep -A1 ^out:|grep return|wc -l 3622 And I also fail to see any relation between the explanation you come up with here and the text in CodingStyle, which was what you initially referred to. There is no specific interpreation of the label name "out" there AFAICS. I apologize if you think I am being an ass now. I am. I'm just too fed up with coding style arguments with no other reason than a vague pointer to some document. If you're going to point out coding style problems, then you could at least make an effort explaining why a style change improves the code. My bet is that most of the time you'll find that the comment is unnecessary... Bjørn