All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Xose Vazquez Perez <xose.vazquez@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: overlap of devices in rtl8xxxu and rtl8192cu
Date: Fri, 23 Oct 2015 20:07:37 +0300	[thread overview]
Message-ID: <87oafp1pk6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <wrfj611xhda9.fsf@redhat.com> (Jes Sorensen's message of "Fri, 23 Oct 2015 10:26:06 -0400")

Jes Sorensen <Jes.Sorensen@redhat.com> writes:

> Kalle Valo <kvalo@codeaurora.org> writes:
>> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>>
>>> Xose Vazquez Perez <xose.vazquez@gmail.com> writes:
>>>>
>>>> There is overlap of devices between rtl8xxxu and rtl8192cu:
>>>> USB_VENDER_ID_REALTEK, 0x8176
>>>> USB_VENDER_ID_REALTEK, 0x8178
>>>> USB_VENDER_ID_REALTEK, 0x817f
>>>> 0x7392, 0x7811
>>>
>>> Yes
>>
>> What, are you saying that you didn't fix that? I did say in the last
>> review round that we should not have duplicated device entries within
>> drivers/net/wireless and I assumed you took care of that.
>>
>>> and there is also a clash with USB IDs between
>>> drivers/staging/rtl8192u and drivers/net/wireless/realtek/rtlwifi -
>>> this is nothing new.
>>
>> We should do things properly in under drivers/, I don't care what
>> happens in staging and that's no excuse to do things badly.
>
> As I explained earlier, there is no way I can do that unless we remove
> rtlwifi's rtl8192cu driver and that cannot happen due to the feature
> differences. There are plenty of other conflicts and this is not a bug.

Like I said earlier in rtl8xxxu review, I don't want to have two drivers
supporting the same device. So either rtl8xxxu or rtlwifi supports the
devices above, not both. And to my knowledge rtl8xxxu is still lacking
in features, and it's a new driver, so it's best that rtlwifi continues
to support these for the time being. Once rtl8xxxu catches up and we
have a clear consensus we can make the switch.

I'll send a patch in a jiffy, merge window is getting closer so we don't
have any extra time.

-- 
Kalle Valo

  reply	other threads:[~2015-10-23 17:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 12:24 overlap of devices in rtl8xxxu and rtl8192cu Xose Vazquez Perez
2015-10-23 13:59 ` Jes Sorensen
2015-10-23 14:20   ` Kalle Valo
2015-10-23 14:26     ` Jes Sorensen
2015-10-23 17:07       ` Kalle Valo [this message]
2015-10-23 17:26         ` Kalle Valo
2015-10-23 17:53           ` Jes Sorensen
2015-10-23 19:31             ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oafp1pk6.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=Jes.Sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.