From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK8Xx-0006Gm-4r for qemu-devel@nongnu.org; Tue, 28 Jul 2015 13:20:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZK8Xv-0000gk-0T for qemu-devel@nongnu.org; Tue, 28 Jul 2015 13:20:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZK8Xu-0000g6-SH for qemu-devel@nongnu.org; Tue, 28 Jul 2015 13:20:06 -0400 From: Markus Armbruster References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-39-git-send-email-armbru@redhat.com> <55B144B7.5030204@redhat.com> Date: Tue, 28 Jul 2015 13:20:28 +0200 In-Reply-To: <55B144B7.5030204@redhat.com> (Eric Blake's message of "Thu, 23 Jul 2015 13:47:03 -0600") Message-ID: <87oaiwwmtf.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v2 38/47] qapi-commands: De-duplicate output marshaling functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com Eric Blake writes: > On 07/01/2015 02:22 PM, Markus Armbruster wrote: >> gen_marshal_output() uses its parameter name only for name of the >> generated function. Name it after the type being marshaled instead of >> its caller, and drop duplicates. >> >> Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of >> qmp_marshal_output_str() in qemu-system-*. > > qga/qapi-generated/qga-qmp-marshal.c | 227 > +++++------------------------------ > qmp-marshal.c | 225 > +++++++++++++++------------------- > 2 files changed, 134 insertions(+), 318 deletions(-) > > Most changes look like: > > -static void qmp_marshal_output_add_fd(AddfdInfo *ret_in, QObject > **ret_out, Error **errp) > +static void qmp_marshal_output_AddfdInfo(AddfdInfo *ret_in, QObject > **ret_out, Error **errp) > { > Error *local_err = NULL; > QmpOutputVisitor *mo = qmp_output_visitor_new(); > @@ -88,7 +88,7 @@ void qmp_marshal_add_fd(QDict *args, QOb > goto out; > } > > - qmp_marshal_output_add_fd(retval, ret, &local_err); > + qmp_marshal_output_AddfdInfo(retval, ret, &local_err); > > coupled with wholesale deletions of functions that previously had > identical bodies. Nice. Exactly. > [I suspect there might be ways to trim a LOT more code size, by > rewriting a generic marshaller helper that is passed a varargs or > array-of-struct list of operations to perform in order to visit an > arbitrary object, then having each command's marshaller generated with > the appropriate list of arguments for the generic helpers rather than > the current approach of calling out to one marshaller helper per type - > but exploring ideas like that is work for another series] Oh, but generating thousands of line of repetitive code is so much fun! Seriously: yes, that's a far better way to do it. Marshalling doesn't have to be as fast as it could possibly be, space cost be damned. >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi-commands.py | 16 +++++++++------- >> 1 file changed, 9 insertions(+), 7 deletions(-) > > Reviewed-by: Eric Blake Thanks!