From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yhgic-00012l-0Z for qemu-devel@nongnu.org; Mon, 13 Apr 2015 11:56:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhgiY-0004hc-RB for qemu-devel@nongnu.org; Mon, 13 Apr 2015 11:56:13 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:35704 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhgiY-0004hR-Im for qemu-devel@nongnu.org; Mon, 13 Apr 2015 11:56:10 -0400 References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com> <1428055432-12120-19-git-send-email-zhaoshenglong@huawei.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1428055432-12120-19-git-send-email-zhaoshenglong@huawei.com> Date: Mon, 13 Apr 2015 16:56:24 +0100 Message-ID: <87oamsja3b.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 18/20] hw/acpi/aml-build: Add aml_dword_io() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, msalter@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org Shannon Zhao writes: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Alex Bennée > --- > hw/acpi/aml-build.c | 17 +++++++++++++++++ > include/hw/acpi/aml-build.h | 5 +++++ > 2 files changed, 22 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 221d054..2076ba1 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -937,6 +937,23 @@ Aml *aml_word_io(AmlMinFixed min_fixed, AmlMaxFixed max_fixed, > addr_gran, addr_min, addr_max, addr_trans, len, > isa_ranges); > } > +/* > + * ACPI 1.0b: 6.4.3.5.4 ASL Macros for DWORD Address Descriptor > + * > + * More verbose description at: > + * ACPI 5.0: 19.5.33 DWordIO (DWord IO Resource Descriptor Macro) > + */ > +Aml *aml_dword_io(AmlMinFixed min_fixed, AmlMaxFixed max_fixed, > + AmlDecode dec, AmlISARanges isa_ranges, > + uint32_t addr_gran, uint32_t addr_min, > + uint32_t addr_max, uint32_t addr_trans, > + uint32_t len) > + > +{ > + return aml_dword_as_desc(aml_io_range, min_fixed, max_fixed, dec, > + addr_gran, addr_min, addr_max, addr_trans, len, > + isa_ranges); > +} > > /* > * ACPI 1.0b: 6.4.3.5.4 ASL Macros for DWORD Address Space Descriptor > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 0d923e8..adefc25 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -188,6 +188,11 @@ Aml *aml_word_io(AmlMinFixed min_fixed, AmlMaxFixed max_fixed, > uint16_t addr_gran, uint16_t addr_min, > uint16_t addr_max, uint16_t addr_trans, > uint16_t len); > +Aml *aml_dword_io(AmlMinFixed min_fixed, AmlMaxFixed max_fixed, > + AmlDecode dec, AmlISARanges isa_ranges, > + uint32_t addr_gran, uint32_t addr_min, > + uint32_t addr_max, uint32_t addr_trans, > + uint32_t len); > Aml *aml_dword_memory(AmlDecode dec, AmlMinFixed min_fixed, > AmlMaxFixed max_fixed, AmlCacheble cacheable, > AmlReadAndWrite read_and_write, -- Alex Bennée