All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Markus Armbruster <armbru@redhat.com>, Amos Kong <akong@redhat.com>
Cc: lilei@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	qemu-stable@nongnu.org, lcapitulino@redhat.com,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf"
Date: Mon, 01 Jul 2013 07:52:27 -0500	[thread overview]
Message-ID: <87obam4f3o.fsf@codemonkey.ws> (raw)
In-Reply-To: <874ncezl0l.fsf@blackfin.pond.sub.org>

Markus Armbruster <armbru@redhat.com> writes:

> Amos Kong <akong@redhat.com> writes:
>
>> On Mon, Jul 01, 2013 at 10:10:40AM +0200, Markus Armbruster wrote:
>>> Amos Kong <akong@redhat.com> writes:
>>> 
>> The comment line in your patch doen't start with '#', it starts with
>> blank-space. If we want qapi.py to process it, we need to do strip()
>> first.
>
> Aha.  I agree with your reading of parse_schema().  However, I get
> exactly identical generated files with and without this comment.
>
> Michael, Anthony, can you explain why?
>
> Any particular reason for requiring comments to start in column 0?

I don't remember a particular reason.  Most likely an evolutionary
artifact.

Regards,

Anthony Liguori

  parent reply	other threads:[~2013-07-01 12:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 14:22 [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size Markus Armbruster
2013-06-27 23:17   ` Eric Blake
2013-07-03 14:54   ` Luiz Capitulino
2013-06-27 14:22 ` [Qemu-devel] [PATCH 2/4] Revert "chardev: Make the name of memory device consistent" Markus Armbruster
2013-06-28  3:35   ` Lei Li
2013-06-28  7:15     ` Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name "ringbuf" Markus Armbruster
2013-07-03 14:54   ` Luiz Capitulino
2013-07-04  6:30     ` Markus Armbruster
2013-06-27 14:22 ` [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf" Markus Armbruster
2013-06-28 13:37   ` Eric Blake
2013-06-28 17:19     ` Markus Armbruster
2013-07-01  3:08       ` Amos Kong
2013-07-01  8:10         ` Markus Armbruster
2013-07-01  9:00           ` Amos Kong
2013-07-01  9:28             ` Markus Armbruster
2013-07-01 11:17               ` Amos Kong
2013-07-01 16:08                 ` Markus Armbruster
2013-07-01 12:52               ` Anthony Liguori [this message]
2013-07-03 14:55 ` [Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obam4f3o.fsf@codemonkey.ws \
    --to=aliguori@us.ibm.com \
    --cc=akong@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=lilei@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.