From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kbuild-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:42560 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752735Ab1GGHtO (ORCPT <rfc822;linux-kbuild@vger.kernel.org>);
	Thu, 7 Jul 2011 03:49:14 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: sorting of exports breaks modpost's GPL checking
In-Reply-To: <4E12F9EB020000780004C219@nat28.tlf.novell.com>
References: <4E11F1C6020000780004C089@nat28.tlf.novell.com> <CAPk1OjGKD+i=RkfMq9GX_HeOdNSH1o5Bp2Ge6QXGy0edi+1kSQ@mail.gmail.com> <4E12F9EB020000780004C219@nat28.tlf.novell.com>
Date: Thu, 07 Jul 2011 10:33:11 +0930
Message-ID: <87oc16kils.fsf@rustcorp.com.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kbuild-owner@vger.kernel.org
List-ID: <linux-kbuild.vger.kernel.org>
To: Jan Beulich <JBeulich@novell.com>, Alessio Igor Bogani <abogani@kernel.org>
Cc: linux-kbuild@vger.kernel.org

On Tue, 05 Jul 2011 10:47:55 +0100, "Jan Beulich" <JBeulich@novell.com> wrote:
> >>> On 05.07.11 at 11:36, Alessio Igor Bogani <abogani@kernel.org> wrote:
> > Dear Mr. Beulich,
> > 
> > 2011/7/4 Jan Beulich <JBeulich@novell.com>:
> >> Is it known (and being worked on) that exported symbols residing
> >> themselves in modules are no longer properly handled by modpost,
> >> due to the .o files to be linked into .ko (other than vmlinux and the
> >> .ko files) still carrying the ___ksymtab*+<symbol> sections?
> >>
> >> If not - what are the thoughts to resolve this?
> > [...]
> > 
> > Could you tell me how reproduce the problem?
> 
> Just look at Modules.symvers - all the symbols coming from modules
> will be tagged "(unknown)" rather than EXPORT_SYMBOL,
> EXPORT_SYMBOL_GPL, etc.
> 
> As to reproducing the actual bad behavior - creating a non-GPL
> module that consumes a GPL-only export should be all you need.
> 
> Jan

We could just drop this detection.  It's a courtesy, after all: the gpl
stuff is enforced at runtime.

Thoughts?
Rusty.