From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6466CC433FE for ; Thu, 17 Nov 2022 10:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234676AbiKQKAx (ORCPT ); Thu, 17 Nov 2022 05:00:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbiKQKAs (ORCPT ); Thu, 17 Nov 2022 05:00:48 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E15525C; Thu, 17 Nov 2022 02:00:46 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668679244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=maOat5H9gR3gEndNJY08JL9PAhjiKE0EY6OpaWP1/04=; b=RGSf5GbhYCWO2dgXgAK/4MemOTdiWzdlP2kHg1EY3iV82/jd6MD8qutFDOfZyP9AVki+J/ RJ3tnnq6qLSJqqLRr72tXKSu30sMmZ40MFaLZbHPv5iVTEioxdnQWXBGw2O5N8hagYae8C eCB4colyFEdiZ5ue+ppMaKiDDXUTmIYbgrfRYPfZIInqUaDu9aBDcjuxngxWMw2cLoyVmy YQbMsvPmhg8jJHFTlEbypw0KgTemn+F6bHK3dPe+RmIxFbhPe/VOto2MlBZj9l2nBJZypQ 8POBvrR40jv9J1kVauY3ttDgvETw6SrqQHB+svEGkXwXN5pZ5ACVmn4odhHzLw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668679244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=maOat5H9gR3gEndNJY08JL9PAhjiKE0EY6OpaWP1/04=; b=OlNG+d1h/dgED4we7sPNyAacUdRGHP68b+yrWn7eSaSHsibUbUaAIusgf57rSNw5GtbQqm 6kHebCFDUDCB26Bw== To: Doug Anderson Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Jason Wessel , Daniel Thompson , Greg Kroah-Hartman , Jiri Slaby , kgdb-bugreport@lists.sourceforge.net, linux-serial@vger.kernel.org Subject: Re: [PATCH printk v5 37/40] tty: serial: kgdboc: synchronize tty_find_polling_driver() and register_console() In-Reply-To: References: <20221116162152.193147-1-john.ogness@linutronix.de> <20221116162152.193147-38-john.ogness@linutronix.de> Date: Thu, 17 Nov 2022 11:06:40 +0106 Message-ID: <87pmdloq7r.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-11-16, Doug Anderson wrote: > Seems OK to me, though I guess I would have moved console_lock() up > too just because this isn't a case we need to optimize and then we can > be extra certain that nobody else is messing with console structures > while we're looking at them. Actually this series is not about optimization. It is about reducing the scope of console_lock and removing unnecessary use of it. If tty_find_polling_driver() needs to be called under the console_lock, then we need to document exactly why. I could not find any situations where it is necessary. Also keep in mind that in the long term we will be completely removing the console_lock. It is a painful process of identifying and dismantling its scope and replacing it with multiple clearly scoped locking mechanisms. > Reviewed-by: Douglas Anderson Thanks. John