From: Peter Korsgaard <peter@korsgaard.com>
To: <yann.morin@orange.com>
Cc: Gleb Mazovetskiy <glex.spb@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] Makefile: really generate glibc locales in parallel
Date: Thu, 03 Nov 2022 14:49:05 +0100 [thread overview]
Message-ID: <87pme4p2r2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <9796_1665746309_63494585_9796_388_2_2b0b6b796ff36967c963ba90f138a03d467ee5cf.1665746266.git.yann.morin@orange.com> (yann morin's message of "Fri, 14 Oct 2022 13:18:25 +0200")
>>>>> <yann.morin@orange.com> writes:
> To generate the glibc locale data, we call into a recursive Makefile,
> so as to generate locales in parallel. This is done as part of a
> target-fialize hook.
> However, that hook is registered after all packages have been parsed,
> and as such, it maye be registered after hooks defined in packages.
> Furthermore, the expansion of target-finalize hooks is done in a recipe,
> so it is not easy to understand whether this generates a "simple" rule
> or not.
> As a consequence, despite the use of $(MAKE), make may not notice that
> the command is a recursive call, and will decide to close the jobserver
> file-descriptors, yieldiong warnings like:
> make[2]: warning: jobserver unavailable: using -j1. Add '+' to
> parent make rule.
> This causes the lcoale data to not be generated in parallel, which is
> initially all the fuss about using a sub-makefile...
> So, do as suggested, and prepend the hook with a '+', so that it
> isexplicit to make that it should not close its jobserver fds.
> Fixes: 6fbdf5159607 (Makefile: Parallelize glibc locale generation)
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> Cc: Gleb Mazovetskiy <glex.spb@gmail.com>
Committed to 2022.08.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-03 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 11:18 [Buildroot] [PATCH 1/3] Makefile: really generate glibc locales in parallel yann.morin
2022-10-21 19:07 ` Yann E. MORIN
2022-10-21 19:46 ` Yann E. MORIN
2022-11-03 13:49 ` Peter Korsgaard [this message]
[not found] <2b0b6b796ff36967c963ba90f138a03d467ee5cf.1665746266.git.yann.morin@orange.com>
2022-10-14 11:18 ` [Buildroot] [PATCH 2/3] support/scripts: don't require gawk to generate glibc gconv modules yann.morin
2022-10-21 19:08 ` Yann E. MORIN
2022-11-04 7:40 ` Peter Korsgaard
2022-10-14 11:18 ` [Buildroot] [PATCH 3/3] toolchain: suppot gconv modules fro mglibc >= 2.34 yann.morin
2022-10-21 19:10 ` Yann E. MORIN
2022-11-04 7:43 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pme4p2r2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=glex.spb@gmail.com \
--cc=yann.morin@orange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.