From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 002742CA4 for ; Mon, 31 Jan 2022 02:16:22 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id C60A95800EF; Sun, 30 Jan 2022 21:16:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jan 2022 21:16:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=turner.link; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=P9iOim4NrWctmEwZ8zPw3HEkn6EbbINyR5zkQ2 23ptE=; b=WhZLbraCfAbAiaXMYxdU0JtimnEgffIECycU2prEgxs57Qiv3otomd LxciAIQ404Tr+R0QA39S0Sh6TphRwSsKbTW/YyVossjjt9UUp71KVqGDjZU9ha2o 5kIawzsFib+RlISzbDxQ5dboN1jldudrXsbVhsDG+LAGRN7ibAMaNBi9eIvrejU3 TZwuD2V1Eh8s5VjcaN+mbp91bSPGhAFy5e8xxRyR6lHU7Fgs0FCJehomiy708/iL WotvDHVyRRIPtZo83WBNjzbFgp63qAcmVRjLU0+Zr2lsIUskSzgsjSJ1RqxT/LJc YNOPuVMLmuTLqq5zGyYgqMP+g1t6LuAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=P9iOim4NrWctmEwZ8 zPw3HEkn6EbbINyR5zkQ223ptE=; b=drCIdtq56LgKKAk04BhqRdtXtrABgGh37 2dky3hCczhXDUV0ToEuDeuG4UJO94oDrN1SsnA8QQX5xq5xAjL0K/CEHgYwergbJ 1LpooZ28Gk0+tnyKL0jADrmqTwREg3XvV86Tj1NhzvO9a53TDiCWxd5OsUKBQBLM dLKo/cF+OCSUk8yaumj02qn5zLVMpqLrpMDr00Hy+0CdfnrjHp7xkGVQQ7x08+jD 7+in0yYBg4ohQs9Ffyhjvi742vXn8PBYjVsf8EVmi+GYpoaNhcj8Vu8AlUV1xG74 xwY4XgXI7mBo42ThRuNldJDCdYPh6wWlTmiXnE41qDd9C1BPHgZ4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedtgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehfhffvufffjgfkgggtsehttdertddttddtnecuhfhrohhmpeflihhmucfvuhhr nhgvrhcuoehlihhnuhigkhgvrhhnvghlrdhfohhsshesughmrghrtgdqnhhonhgvrdhtuh hrnhgvrhdrlhhinhhkqeenucggtffrrghtthgvrhhnpeetheegvdetueefudelffejieff feetuefhveffveffffffhffguddtleehueevleenucffohhmrghinhepsghoohhtlhhinh drtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehlihhnuhigkhgvrhhnvghlrdhfohhsshesughmrghrtgdqnhhonhgvrdhtuhhrnhgvrh drlhhinhhk X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jan 2022 21:16:21 -0500 (EST) References: <87ee57c8fu.fsf@turner.link> <87a6ftk9qy.fsf@dmarc-none.turner.link> <87zgnp96a4.fsf@turner.link> <87czkk1pmt.fsf@dmarc-none.turner.link> <87sftfqwlx.fsf@dmarc-none.turner.link> <87ee4wprsx.fsf@turner.link> <4b3ed7f6-d2b6-443c-970e-d963066ebfe3@amd.com> From: Jim Turner To: "Lazar, Lijo" Cc: Alex Deucher , Thorsten Leemhuis , "Deucher, Alexander" , "regressions@lists.linux.dev" , "kvm@vger.kernel.org" , Greg KH , "Pan, Xinhui" , LKML , "amd-gfx@lists.freedesktop.org" , Alex Williamson , "Koenig, Christian" Subject: Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM Date: Sat, 29 Jan 2022 19:25:07 -0500 In-reply-to: <4b3ed7f6-d2b6-443c-970e-d963066ebfe3@amd.com> Message-ID: <87pmo8r6ob.fsf@turner.link> Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi Lijo, > Specifically, I was looking for any events happening at these two > places because of the patch- > > https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L411 > > https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L653 I searched the logs generated with all drm debug messages enabled (drm.debug=0x1ff) for "device_class", "ATCS", "atcs", "ATIF", and "atif", for both f1688bd69ec4 and f9b7f3703ff9. Other than the few lines mentioning ATIF from my previous email, there weren't any matches. Since "device_class" didn't appear in the logs, we know that `amdgpu_atif_handler` was not called for either version. I also patched f9b7f3703ff9 to add the line DRM_DEBUG_DRIVER("Entered amdgpu_acpi_pcie_performance_request"); at the top (below the variable declarations) of `amdgpu_acpi_pcie_performance_request`, and then tested again with all drm debug messages enabled (0x1ff). That debug message didn't show up. So, `amdgpu_acpi_pcie_performance_request` was not called either, at least with f9b7f3703ff9. (I didn't try adding this patch to f1688bd69ec4.) Would anything else be helpful? James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2020C433F5 for ; Mon, 31 Jan 2022 08:43:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FBDF112CB9; Mon, 31 Jan 2022 08:43:18 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3D0110F3BA for ; Mon, 31 Jan 2022 02:16:24 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id C60A95800EF; Sun, 30 Jan 2022 21:16:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jan 2022 21:16:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=turner.link; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; bh=P9iOim4NrWctmEwZ8zPw3HEkn6EbbINyR5zkQ2 23ptE=; b=WhZLbraCfAbAiaXMYxdU0JtimnEgffIECycU2prEgxs57Qiv3otomd LxciAIQ404Tr+R0QA39S0Sh6TphRwSsKbTW/YyVossjjt9UUp71KVqGDjZU9ha2o 5kIawzsFib+RlISzbDxQ5dboN1jldudrXsbVhsDG+LAGRN7ibAMaNBi9eIvrejU3 TZwuD2V1Eh8s5VjcaN+mbp91bSPGhAFy5e8xxRyR6lHU7Fgs0FCJehomiy708/iL WotvDHVyRRIPtZo83WBNjzbFgp63qAcmVRjLU0+Zr2lsIUskSzgsjSJ1RqxT/LJc YNOPuVMLmuTLqq5zGyYgqMP+g1t6LuAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=P9iOim4NrWctmEwZ8 zPw3HEkn6EbbINyR5zkQ223ptE=; b=drCIdtq56LgKKAk04BhqRdtXtrABgGh37 2dky3hCczhXDUV0ToEuDeuG4UJO94oDrN1SsnA8QQX5xq5xAjL0K/CEHgYwergbJ 1LpooZ28Gk0+tnyKL0jADrmqTwREg3XvV86Tj1NhzvO9a53TDiCWxd5OsUKBQBLM dLKo/cF+OCSUk8yaumj02qn5zLVMpqLrpMDr00Hy+0CdfnrjHp7xkGVQQ7x08+jD 7+in0yYBg4ohQs9Ffyhjvi742vXn8PBYjVsf8EVmi+GYpoaNhcj8Vu8AlUV1xG74 xwY4XgXI7mBo42ThRuNldJDCdYPh6wWlTmiXnE41qDd9C1BPHgZ4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgedtgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehfhffvufffjgfkgggtsehttdertddttddtnecuhfhrohhmpeflihhmucfvuhhr nhgvrhcuoehlihhnuhigkhgvrhhnvghlrdhfohhsshesughmrghrtgdqnhhonhgvrdhtuh hrnhgvrhdrlhhinhhkqeenucggtffrrghtthgvrhhnpeetheegvdetueefudelffejieff feetuefhveffveffffffhffguddtleehueevleenucffohhmrghinhepsghoohhtlhhinh drtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehlihhnuhigkhgvrhhnvghlrdhfohhsshesughmrghrtgdqnhhonhgvrdhtuhhrnhgvrh drlhhinhhk X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jan 2022 21:16:21 -0500 (EST) References: <87ee57c8fu.fsf@turner.link> <87a6ftk9qy.fsf@dmarc-none.turner.link> <87zgnp96a4.fsf@turner.link> <87czkk1pmt.fsf@dmarc-none.turner.link> <87sftfqwlx.fsf@dmarc-none.turner.link> <87ee4wprsx.fsf@turner.link> <4b3ed7f6-d2b6-443c-970e-d963066ebfe3@amd.com> From: Jim Turner To: "Lazar, Lijo" Subject: Re: [REGRESSION] Too-low frequency limit for AMD GPU PCI-passed-through to Windows VM Date: Sat, 29 Jan 2022 19:25:07 -0500 In-reply-to: <4b3ed7f6-d2b6-443c-970e-d963066ebfe3@amd.com> Message-ID: <87pmo8r6ob.fsf@turner.link> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Mon, 31 Jan 2022 08:43:17 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "regressions@lists.linux.dev" , "kvm@vger.kernel.org" , Greg KH , "Pan, Xinhui" , LKML , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , Alex Williamson , Thorsten Leemhuis , Alex Deucher , "Koenig, Christian" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Lijo, > Specifically, I was looking for any events happening at these two > places because of the patch- > > https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L411 > > https://elixir.bootlin.com/linux/v5.16/source/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c#L653 I searched the logs generated with all drm debug messages enabled (drm.debug=0x1ff) for "device_class", "ATCS", "atcs", "ATIF", and "atif", for both f1688bd69ec4 and f9b7f3703ff9. Other than the few lines mentioning ATIF from my previous email, there weren't any matches. Since "device_class" didn't appear in the logs, we know that `amdgpu_atif_handler` was not called for either version. I also patched f9b7f3703ff9 to add the line DRM_DEBUG_DRIVER("Entered amdgpu_acpi_pcie_performance_request"); at the top (below the variable declarations) of `amdgpu_acpi_pcie_performance_request`, and then tested again with all drm debug messages enabled (0x1ff). That debug message didn't show up. So, `amdgpu_acpi_pcie_performance_request` was not called either, at least with f9b7f3703ff9. (I didn't try adding this patch to f1688bd69ec4.) Would anything else be helpful? James