From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B28F3C433F5 for ; Fri, 12 Nov 2021 19:59:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1891560698 for ; Fri, 12 Nov 2021 19:59:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1891560698 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D7F1C83027; Fri, 12 Nov 2021 20:59:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 208AC83010; Fri, 12 Nov 2021 20:59:40 +0100 (CET) Received: from cascadia.aikidev.net (cascadia.aikidev.net [IPv6:2600:3c01:e000:267:0:a171:de7:c]) by phobos.denx.de (Postfix) with ESMTP id 22A8783010 for ; Fri, 12 Nov 2021 20:59:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 589D51AC25; Fri, 12 Nov 2021 11:59:34 -0800 (PST) From: Vagrant Cascadian To: Patrick Wildt Cc: Stefano Babic , Fabio Estevam , u-boot@lists.denx.de, "Lukas F. Hartmann" , Peng Fan , "Peng Fan (OSS)" Subject: Re: [PATCH v2 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support In-Reply-To: References: <878rxvhck1.fsf@ponder> Date: Fri, 12 Nov 2021 11:59:29 -0800 Message-ID: <87pmr5f8m6.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2021-11-11, Patrick Wildt wrote: > On Thu, Nov 11, 2021 at 12:21:26PM +0100, Patrick Wildt wrote: >> On Wed, Nov 10, 2021 at 02:26:54PM -0800, Vagrant Cascadian wrote: >> > On 2021-09-02, Patrick Wildt wrote: >> > > The MNT Reform 2 is a modular DIY laptop. In its initial version it >> > > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been >> > > lifted from BoundaryDevices official U-Boot downstream project. ... >> > Both simply hanging with: >> >=20 >> > U-Boot SPL 2021.10 (Jan 01 1970 - 00:00:01 +0000) Still hanging with the below patch... >> There have been a few changes in U-Boot since I sent my patchset, it's >> possible the diff by itself might not be enough. >>=20 >> I will send out a new patchset soon, but the move to Binman doesn't work >> for me yet. It's weird, because I don't see a diff to other i.MX8MQ >> platforms, so I'm still debugging that. Maybe the other i.MX8MQ boards >> don't work with Binman either? >>=20 >> Keep note that the build procedure (how to supply bl31) changes once >> Binman is used. > > I have fixed the issue. My changes depend on Peng's patchset to change > i.MX8MQ to Binman, so I will re-issue a v3 of the patchset as soon as > that is done (to not interfere any further with his patchset). > > 'Attached' you'll find a complete diff you can apply to origin/master, > which includes some of Peng's changes. Let me know how it goes for you. To get it to build, I needed to add this: diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile index 07954bc201..e51b5317fc 100644 =2D-- a/arch/arm/mach-imx/Makefile +++ b/arch/arm/mach-imx/Makefile @@ -161,9 +161,9 @@ spl/u-boot-spl.cfgout: $(IMX_CONFIG) FORCE $(Q)mkdir -p $(dir $@) $(call if_changed_dep,cpp_cfg) =2Dspl/u-boot-spl-ddr.bin: spl/u-boot-spl.bin spl/u-boot-spl.cfgout FORCE +u-boot-spl-ddr.bin: spl/u-boot-spl.bin spl/u-boot-spl.cfgout FORCE =2Dflash.bin: spl/u-boot-spl-ddr.bin u-boot.itb FORCE +flash.bin: u-boot-spl-ddr.bin u-boot.itb FORCE $(call if_changed,mkimage) endif >> > Is the flash.bin step unecessary? I see DDR timing code in the patch >> > series; are corresponding lpddr4*.bin no longer necessary? >>=20 >> The flash.bin has all bits: U-Boot, U-Boot SPL, lpddr4*.bin and bl31.bin >>=20 >> lpddr4*.bin is the firmware for the DDR controller. So you need the >> timing information *and* the firmware. >>=20 >> > I also tried building with an old version of arm-trusted-firmware >> > (v2.2), as that was the most recent upstream version that successfully >> > built. This seems to be a fork of ATF that has support for iMX8MQ, but >> > it is unclear which branch/tag/etc. should be used with the mnt/reform: >> >=20 >> > https://source.codeaurora.org/external/imx/imx-atf >>=20 >> Not sure right now, but I think I was using the one that's build on >> OpenBSD-current, which seems to be arm-trusted-firmware 2.5. I'll >> check it. I can't get atf 2.5 for imx8mq to build on Debian or GNU Guix; it seems that maybe it is no longer supported upstream: https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=3D= e3c07d2f5a082d8bb1684ca026d1789a77b3c870 Though it's not exactly clear what works... >> > It would be nice to include a board README in the next patch revision = to >> > spell out some of the details of exactly which other projects and >> > versions/comments/branches are expected to work with MNT Reform2. >> >=20 >>=20 >> This is nothing specific to the MNT Reform2. It's the same for all >> i.MX8MQ boards. ATF+DDR+U-Boot have to work together, and it doesn't >> matter which board it is. Hence I don't believe providing that kind >> information in a Reform-specific README makes sense. I guess we need a workable README for i.MX8MQ or something, and only boards that differ from that process document the differences? But at the moment, it appears to still be guesswork. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYY7HogAKCRDcUY/If5cW qkCEAPsHEdDJdwu7hsZDLFuZnQ7BXpVQwN5U5SuwZDN8TUUJiQD+NrO6HwsNOMYA cmUwMJic4D1kZAnelEj+kgDuLptPswk= =LA/E -----END PGP SIGNATURE----- --=-=-=--