From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FFDC433F5 for ; Thu, 11 Nov 2021 10:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8396561267 for ; Thu, 11 Nov 2021 10:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231972AbhKKKXm (ORCPT ); Thu, 11 Nov 2021 05:23:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:57490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230256AbhKKKXi (ORCPT ); Thu, 11 Nov 2021 05:23:38 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7651761268; Thu, 11 Nov 2021 10:20:49 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ml7CJ-004nqD-6t; Thu, 11 Nov 2021 10:20:47 +0000 Date: Thu, 11 Nov 2021 10:20:46 +0000 Message-ID: <87pmr7803l.wl-maz@kernel.org> From: Marc Zyngier To: Christian Zigotzky Cc: Bjorn Helgaas , "bhelgaas@google.com >> Bjorn Helgaas" , Alyssa Rosenzweig , lorenzo.pieralisi@arm.com, Rob Herring , Matthew Leaman , Darren Stevens , mad skateman , "R.T.Dickinson" , Christian Zigotzky , axboe@kernel.dk, damien.lemoal@opensource.wdc.com, kw@linux.com, Arnd Bergmann , robert@swiecki.net, Olof Johansson , linuxppc-dev , "linux-pci@vger.kernel.org" Subject: Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates In-Reply-To: References: <78308692-02e6-9544-4035-3171a8e1e6d4@xenosoft.de> <20211110184106.GA1251058@bhelgaas> <87sfw3969l.wl-maz@kernel.org> <8cc64c3b-b0c0-fb41-9836-2e5e6a4459d1@xenosoft.de> <87r1bn88rt.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: chzigotzky@xenosoft.de, helgaas@kernel.org, bhelgaas@google.com, alyssa@rosenzweig.io, lorenzo.pieralisi@arm.com, robh@kernel.org, matthew@a-eon.biz, darren@stevens-zone.net, madskateman@gmail.com, rtd2@xtra.co.nz, info@xenosoft.de, axboe@kernel.dk, damien.lemoal@opensource.wdc.com, kw@linux.com, arnd@arndb.de, robert@swiecki.net, olof@lixom.net, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, 11 Nov 2021 07:47:08 +0000, Christian Zigotzky wrote: > > On 11 November 2021 at 08:13 am, Marc Zyngier wrote: > > On Thu, 11 Nov 2021 05:24:52 +0000, > > Christian Zigotzky wrote: > >> Hello Marc, > >> > >> Here you are: > >> https://forum.hyperion-entertainment.com/viewtopic.php?p=54406#p54406 > > This is not what I asked. I need the actual source file, or at the > > very least the compiled object (the /sys/firmware/fdt file, for > > example). Not an interpretation that I can't feed to the kernel. > > > > Without this, I can't debug your problem. > > > >> We are very happy to have the patch for reverting the bad commit > >> because we want to test the new PASEMI i2c driver with support for the > >> Apple M1 [1] on our Nemo boards. > > You can revert the patch on your own. At this stage, we're not blindly > > reverting things in the tree, but instead trying to understand what > > is happening on your particular system. > > > > Thanks, > > > > M. > > > I added a download link for the fdt file to the post [1]. Please read > also Darren's comments in this post. Thanks for that. The DT looks absolutely bonkers, no wonder that things break with something like that. But Darren's comments made me jump a bit, and I quote them here for everyone to see: [...] The dtb passed by the CFE firmware has a number of issues, which up till now have been fixed by use of patches applied to the mainline kernel. This occasionally causes problems with changes made to mainline. [...] Am I right in understanding that the upstream kernel does not support the machine out of the box, and that you actually have to apply out of tree patches to make it work? That these patches have to do with the IRQ routing? If so, I wonder why upstream should revert a patch to work on a system that isn't supported upstream the first place. I will still try and come up with a solution for you. But asking for the revert of a patch on these grounds is not, IMHO, acceptable. Also, please provide these patches on the list so that I can help you to some extend (and I mean *on the list*, not on a random forum that collects my information). Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AB5C433F5 for ; Thu, 11 Nov 2021 10:21:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 088ED61267 for ; Thu, 11 Nov 2021 10:21:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 088ED61267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hqd6T3m2Qz3c9f for ; Thu, 11 Nov 2021 21:21:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=maz@kernel.org; receiver=) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hqd5w24GLz2xXC for ; Thu, 11 Nov 2021 21:20:52 +1100 (AEDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7651761268; Thu, 11 Nov 2021 10:20:49 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ml7CJ-004nqD-6t; Thu, 11 Nov 2021 10:20:47 +0000 Date: Thu, 11 Nov 2021 10:20:46 +0000 Message-ID: <87pmr7803l.wl-maz@kernel.org> From: Marc Zyngier To: Christian Zigotzky Subject: Re: [PASEMI] Nemo board doesn't recognize any ATA disks with the pci-v5.16 updates In-Reply-To: References: <78308692-02e6-9544-4035-3171a8e1e6d4@xenosoft.de> <20211110184106.GA1251058@bhelgaas> <87sfw3969l.wl-maz@kernel.org> <8cc64c3b-b0c0-fb41-9836-2e5e6a4459d1@xenosoft.de> <87r1bn88rt.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: chzigotzky@xenosoft.de, helgaas@kernel.org, bhelgaas@google.com, alyssa@rosenzweig.io, lorenzo.pieralisi@arm.com, robh@kernel.org, matthew@a-eon.biz, darren@stevens-zone.net, madskateman@gmail.com, rtd2@xtra.co.nz, info@xenosoft.de, axboe@kernel.dk, damien.lemoal@opensource.wdc.com, kw@linux.com, arnd@arndb.de, robert@swiecki.net, olof@lixom.net, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, Rob Herring , lorenzo.pieralisi@arm.com, "R.T.Dickinson" , Arnd Bergmann , kw@linux.com, "linux-pci@vger.kernel.org" , damien.lemoal@opensource.wdc.com, Olof Johansson , Darren Stevens , Bjorn Helgaas , mad skateman , "bhelgaas@google.com >> Bjorn Helgaas" , robert@swiecki.net, Matthew Leaman , linuxppc-dev , Alyssa Rosenzweig , Christian Zigotzky Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 11 Nov 2021 07:47:08 +0000, Christian Zigotzky wrote: > > On 11 November 2021 at 08:13 am, Marc Zyngier wrote: > > On Thu, 11 Nov 2021 05:24:52 +0000, > > Christian Zigotzky wrote: > >> Hello Marc, > >> > >> Here you are: > >> https://forum.hyperion-entertainment.com/viewtopic.php?p=54406#p54406 > > This is not what I asked. I need the actual source file, or at the > > very least the compiled object (the /sys/firmware/fdt file, for > > example). Not an interpretation that I can't feed to the kernel. > > > > Without this, I can't debug your problem. > > > >> We are very happy to have the patch for reverting the bad commit > >> because we want to test the new PASEMI i2c driver with support for the > >> Apple M1 [1] on our Nemo boards. > > You can revert the patch on your own. At this stage, we're not blindly > > reverting things in the tree, but instead trying to understand what > > is happening on your particular system. > > > > Thanks, > > > > M. > > > I added a download link for the fdt file to the post [1]. Please read > also Darren's comments in this post. Thanks for that. The DT looks absolutely bonkers, no wonder that things break with something like that. But Darren's comments made me jump a bit, and I quote them here for everyone to see: [...] The dtb passed by the CFE firmware has a number of issues, which up till now have been fixed by use of patches applied to the mainline kernel. This occasionally causes problems with changes made to mainline. [...] Am I right in understanding that the upstream kernel does not support the machine out of the box, and that you actually have to apply out of tree patches to make it work? That these patches have to do with the IRQ routing? If so, I wonder why upstream should revert a patch to work on a system that isn't supported upstream the first place. I will still try and come up with a solution for you. But asking for the revert of a patch on these grounds is not, IMHO, acceptable. Also, please provide these patches on the list so that I can help you to some extend (and I mean *on the list*, not on a random forum that collects my information). Thanks, M. -- Without deviation from the norm, progress is not possible.