All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Jonas Dreßler" <verdre@v0yd.nl>
Cc: "Amitkumar Karwar" <amitkarwar@gmail.com>,
	"Ganapathi Bhat" <ganapathi.bhat@nxp.com>,
	"Xinming Hu" <huxinming820@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Tsuchiya Yuto" <kitakar@gmail.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2 1/2] mwifiex: pcie: add DMI-based quirk implementation for Surface devices
Date: Sat, 31 Jul 2021 11:50:29 +0300	[thread overview]
Message-ID: <87pmuyeuju.fsf@codeaurora.org> (raw)
In-Reply-To: <20210709145831.6123-2-verdre@v0yd.nl> ("Jonas \=\?utf-8\?Q\?Dre\?\= \=\?utf-8\?Q\?\=C3\=9Fler\=22's\?\= message of "Fri, 9 Jul 2021 16:58:30 +0200")

Jonas Dreßler <verdre@v0yd.nl> writes:

> This commit adds the ability to apply device-specific quirks to the
> mwifiex driver. It uses DMI matching similar to the quirks brcmfmac uses
> with dmi.c. We'll add identifiers to match various MS Surface devices,
> which this is primarily meant for, later.
>
> This commit is a slightly modified version of a previous patch sent in
> by Tsuchiya Yuto.
>
> Co-developed-by: Tsuchiya Yuto <kitakar@gmail.com>
> Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
> Signed-off-by: Jonas Dreßler <verdre@v0yd.nl>

[...]

> --- /dev/null
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie_quirks.c
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: GPL-2.0

I prefer having a consistent license within a driver. So please either
convert mwifiex to use SPDX in every file or use the same license boiler
plate as used in the driver.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2021-07-31  8:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 14:58 [PATCH v2 0/2] mwifiex: Add quirks for MS Surface devices Jonas Dreßler
2021-07-09 14:58 ` [PATCH v2 1/2] mwifiex: pcie: add DMI-based quirk implementation for " Jonas Dreßler
2021-07-31  8:50   ` Kalle Valo [this message]
2021-07-09 14:58 ` [PATCH v2 2/2] mwifiex: pcie: add reset_d3cold quirk for Surface gen4+ devices Jonas Dreßler
2021-07-09 15:18   ` Pali Rohár
2021-07-09 15:33     ` Jonas Dreßler
2021-07-09 16:12       ` Pali Rohár
2021-07-09 17:03         ` Maximilian Luz
2021-07-09 17:30           ` Pali Rohár
2021-07-09 18:16             ` Maximilian Luz
2021-07-09 18:44               ` Pali Rohár
2021-07-09 19:27                 ` Maximilian Luz
2021-07-09 19:44                   ` Pali Rohár
2021-07-09 20:54                     ` Maximilian Luz
2021-07-09 21:25                       ` Pali Rohár
2021-07-09 22:25                         ` Maximilian Luz
2021-07-09 22:54                           ` Pali Rohár
2021-07-10  0:00                             ` Maximilian Luz
2021-07-10  0:07                               ` Pali Rohár
2021-07-10  0:18                                 ` Maximilian Luz
2021-07-10  0:38                                   ` Pali Rohár
2021-07-10  1:07                                     ` Maximilian Luz
2021-07-11 16:53                                       ` Jonas Dreßler
2021-07-11 17:01                                         ` Pali Rohár
2021-07-11 16:31             ` Jonas Dreßler
2021-07-09 16:01     ` Andy Shevchenko
2021-07-09 16:31       ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmuyeuju.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=amitkarwar@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=ganapathi.bhat@nxp.com \
    --cc=huxinming820@gmail.com \
    --cc=kitakar@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=verdre@v0yd.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.