From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 572F6177 for ; Tue, 6 Jul 2021 10:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625569063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; b=Tpitbp8kRSV2Hc2y6VIhqDekGY7ZfeSw1kRC+BpUzdAdWDjVolk9floMPAIccWCKebta0U 41FDt47yB0fzRf/2Kg6HJo1mf3TAQLqXEk9QilWjSmo7/7k26EWUm7t8rCvaA0yK9jrXp0 lpxxx/yL6IbqFrmFw/bhdsMwYLpf2fo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-5mCOs4Y3P-6VHTb8_rh9-g-1; Tue, 06 Jul 2021 06:57:41 -0400 X-MC-Unique: 5mCOs4Y3P-6VHTb8_rh9-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 481AE100B3AC; Tue, 6 Jul 2021 10:57:36 +0000 (UTC) Received: from localhost (ovpn-113-13.ams2.redhat.com [10.36.113.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A0A60CC6; Tue, 6 Jul 2021 10:57:19 +0000 (UTC) From: Cornelia Huck To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?utf-8?Q?Rafa=C5=82_Mi=C5=82eck?= =?utf-8?Q?i?= , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov , Ulf Hansson , Lee Jones , Tomas Winkler , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , Jon Mason , Allen Hubbe , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84sk?= =?utf-8?Q?i?= , Bjorn Helgaas , Dominik Brodowski , Maximilian Luz , Hans de Goede , Mark Gross , Matt Porter , Alexandre Bounine , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Thorsten Scherer , Srinivas Kandagatla , Andy Gross , Mark Brown , Stephen Boyd , Michael Buesch , Sven Van Asbroeck , Johan Hovold , Alex Elder , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Rob Herring , Jiri Slaby , Heikki Krogerus , "Michael S. Tsirkin" , Jason Wang , Kirti Wankhede , Alex Williamson , Martyn Welch , Manohar Vanga , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Johannes Berg , Jaroslav Kysela , Takashi Iwai , Marc Zyngier , Tyrel Datwyler , Vladimir Zapolskiy , Samuel Holland , Qinglang Miao , Alexey Kardashevskiy , Kai-Heng Feng , Joey Pabalan , Pali =?utf-8?Q?Roh=C3=A1r?= , Adrian Hunter , Frank Li , Mike Christie , Bodo Stroesser , Hannes Reinecke , David Woodhouse , SeongJae Park , Julien Grall , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH] bus: Make remove callback return void In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Organization: Red Hat GmbH References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 06 Jul 2021 12:57:17 +0200 Message-ID: <87pmvvhfqq.fsf@redhat.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jul 06 2021, Uwe Kleine-K=C3=B6nig = wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. Yay! > > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return void" that is not yet applied, see > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutro= nix.de. > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > surprised if I still missed to convert a driver. So it would be great to > get this into next early after the merge window closes. I'm afraid you missed the s390-specific busses in drivers/s390/cio/ (css/ccw/ccwgroup). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFB0C07E96 for ; Thu, 8 Jul 2021 10:11:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 282A561451 for ; Thu, 8 Jul 2021 10:11:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 282A561451 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B070316AD; Thu, 8 Jul 2021 12:10:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B070316AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1625739079; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; h=From:To:Subject:In-Reply-To:References:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e/t9E4G3Htr0j/I/B7TBoPA9cr2KrDWZOJRhssdjt+v1wJVF2OJf9+ixbzq6TrcUG thT3dxSPy4q/dzYBq71OD2IGLvQXUpu7HYMw1AfWacJiB9oZlfQ2k5/2N/vMmBCbgm WOhUBmbqiAqQvwhQgSCYPlCUlM7EpJr5w+T7vHcI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B820AF80539; Thu, 8 Jul 2021 12:04:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 50947F80249; Tue, 6 Jul 2021 12:57:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 19AD9F80134 for ; Tue, 6 Jul 2021 12:57:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 19AD9F80134 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ddpffMRC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625569064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; b=ddpffMRC6H7CVti+/4ID0Wal6QZkLW8s42ZWLh3d3BNDUndKasjSO9wV3/HXFbQPGNyLfD 5/EmR3xwxJ0lOnQUa3WSd+7zsnWjXPfsZxGYA5yVN/EIDh7K5gYL+fbWVHy9NSgXoXjHqR 88/Mb9J3r/vyLtUBHtH3dQeFXfiJk+Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-IdDyg1WcNQy2D-iZerGLfA-1; Tue, 06 Jul 2021 06:57:42 -0400 X-MC-Unique: IdDyg1WcNQy2D-iZerGLfA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47CA0343CD; Tue, 6 Jul 2021 10:57:36 +0000 (UTC) Received: from localhost (ovpn-113-13.ams2.redhat.com [10.36.113.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A0A60CC6; Tue, 6 Jul 2021 10:57:19 +0000 (UTC) From: Cornelia Huck To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Subject: Re: [PATCH] bus: Make remove callback return void In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Organization: Red Hat GmbH References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 06 Jul 2021 12:57:17 +0200 Message-ID: <87pmvvhfqq.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 08 Jul 2021 12:04:26 +0200 Cc: nvdimm@lists.linux.dev, Alexey Kardashevskiy , Benjamin Herrenschmidt , Samuel Iglesias Gonsalvez , Jens Taprogge , Ulf Hansson , Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Mike Christie , Wei Liu , Maxim Levitsky , Samuel Holland , Michael Ellerman , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Tomas Winkler , Julien Grall , Ohad Ben-Cohen , Alex Williamson , Alex Elder , linux-parisc@vger.kernel.org, Geoff Levand , linux-fpga@vger.kernel.org, linux-usb@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Thorsten Scherer , kernel@pengutronix.de, Jon Mason , linux-ntb@googlegroups.com, Wu Hao , David Woodhouse , Krzysztof =?utf-8?Q?Wilczy=C5=84sk?= =?utf-8?Q?i?= , Alexandre Belloni , Manohar Vanga , linux-wireless@vger.kernel.org, Dominik Brodowski , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, Kai-Heng Feng , Stefano Stabellini , Stephen Hemminger , Ira Weiny , Helge Deller , =?utf-8?Q?Rafa=C5=82_Mi=C5=82eck?= =?utf-8?Q?i?= , industrypack-devel@lists.sourceforge.net, linux-mips@vger.kernel.org, Len Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, Maxime Ripard , Johan Hovold , greybus-dev@lists.linaro.org, Bjorn Helgaas , Dave Jiang , Boris Ostrovsky , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Johannes Thumshirn , Mathieu Poirier , Stephen Boyd , Wolfram Sang , Joey Pabalan , Yehezkel Bernat , Pali =?utf-8?Q?Roh=C3=A1r?= , Bodo Stroesser , Alison Schofield , Heikki Krogerus , Tyrel Datwyler , Alexander Shishkin , Tom Rix , Jason Wang , SeongJae Park , linux-hyperv@vger.kernel.org, platform-driver-x86@vger.kernel.org, Frank Li , netdev@vger.kernel.org, Qinglang Miao , Jiri Slaby , Rob Herring , Lorenzo Pieralisi , Mark Gross , linux-staging@lists.linux.dev, Dexuan Cui , Jernej Skrabec , Kishon Vijay Abraham I , Chen-Yu Tsai , linux-input@vger.kernel.org, Matt Porter , Allen Hubbe , Alex Dubov , Haiyang Zhang , Jiri Kosina , Vladimir Zapolskiy , Ben Widawsky , Moritz Fischer , linux-cxl@vger.kernel.org, Michael Buesch , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , "Martin K. Petersen" , Martyn Welch , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev, Stefan Richter , Sudeep Holla , "David S. Miller" , Sven Van Asbroeck , kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Bjorn Andersson , Kirti Wankhede , Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Lee Jones , Arnd Bergmann , linux-scsi@vger.kernel.org, Vishal Verma , Russell King , Andy Gross , linux-serial@vger.kernel.org, Jakub Kicinski , Michael Jamet , William Breathitt Gray , Hans de Goede , Hannes Reinecke , Adrian Hunter , Juergen Gross , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Alexandre Bounine , Vinod Koul , Mark Brown , Marc Zyngier , dmaengine@vger.kernel.org, Johannes Berg , Maximilian Luz X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jul 06 2021, Uwe Kleine-K=C3=B6nig = wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. Yay! > > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return void" that is not yet applied, see > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutro= nix.de. > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > surprised if I still missed to convert a driver. So it would be great to > get this into next early after the merge window closes. I'm afraid you missed the s390-specific busses in drivers/s390/cio/ (css/ccw/ccwgroup). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB071C07E96 for ; Tue, 6 Jul 2021 12:52:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 767C6601FD for ; Tue, 6 Jul 2021 12:52:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 767C6601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GK2X01PPcz3dkF for ; Tue, 6 Jul 2021 22:52:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OP4A90nD; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OP4A90nD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=216.205.24.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=cohuck@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OP4A90nD; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OP4A90nD; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GJzzg53P9z2yyl for ; Tue, 6 Jul 2021 20:57:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625569065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; b=OP4A90nDzTdDH9pCXS7i40kzev43201L9fvpI05/FOaAr4ypll9zerTW1tnWG2pVUobSLV 5YFAi7Lu1vHtT/b1ik2su9r4VEpddHnvDOEQAzXUOJoJQZpoOkbqUTBZG6gMdSg7YoZmEg +KZpcKWJmRVHRXrJDWx6RU5iQ5QNt1U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625569065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; b=OP4A90nDzTdDH9pCXS7i40kzev43201L9fvpI05/FOaAr4ypll9zerTW1tnWG2pVUobSLV 5YFAi7Lu1vHtT/b1ik2su9r4VEpddHnvDOEQAzXUOJoJQZpoOkbqUTBZG6gMdSg7YoZmEg +KZpcKWJmRVHRXrJDWx6RU5iQ5QNt1U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-5mCOs4Y3P-6VHTb8_rh9-g-1; Tue, 06 Jul 2021 06:57:41 -0400 X-MC-Unique: 5mCOs4Y3P-6VHTb8_rh9-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 481AE100B3AC; Tue, 6 Jul 2021 10:57:36 +0000 (UTC) Received: from localhost (ovpn-113-13.ams2.redhat.com [10.36.113.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A0A60CC6; Tue, 6 Jul 2021 10:57:19 +0000 (UTC) From: Cornelia Huck To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Subject: Re: [PATCH] bus: Make remove callback return void In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Organization: Red Hat GmbH References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 06 Jul 2021 12:57:17 +0200 Message-ID: <87pmvvhfqq.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 06 Jul 2021 22:48:04 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Alexey Kardashevskiy , Samuel Iglesias Gonsalvez , Jens Taprogge , Ulf Hansson , Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Mike Christie , Wei Liu , Maxim Levitsky , Samuel Holland , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Tomas Winkler , Julien Grall , Ohad Ben-Cohen , Alex Williamson , Alex Elder , linux-parisc@vger.kernel.org, Geoff Levand , linux-fpga@vger.kernel.org, linux-usb@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Thorsten Scherer , kernel@pengutronix.de, Jon Mason , linux-ntb@googlegroups.com, Wu Hao , David Woodhouse , Krzysztof =?utf-8?Q?Wilczy=C5=84sk?= =?utf-8?Q?i?= , Alexandre Belloni , Manohar Vanga , linux-wireless@vger.kernel.org, Dominik Brodowski , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , target-devel@vger.kernel.org, Srinivas Kandagatla , linux-i2c@vger.kernel.org, Kai-Heng Feng , Stefano Stabellini , Stephen Hemminger , Ira Weiny , Helge Deller , =?utf-8?Q?Rafa=C5=82_Mi=C5=82eck?= =?utf-8?Q?i?= , industrypack-devel@lists.sourceforge.net, linux-mips@vger.kernel.org, Len Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, Maxime Ripard , Johan Hovold , greybus-dev@lists.linaro.org, Bjorn Helgaas , Dave Jiang , Boris Ostrovsky , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Johannes Thumshirn , Mathieu Poirier , Stephen Boyd , Wolfram Sang , Joey Pabalan , Yehezkel Bernat , Pali =?utf-8?Q?Roh=C3=A1r?= , Bodo Stroesser , Alison Schofield , Heikki Krogerus , Tyrel Datwyler , Alexander Shishkin , Tom Rix , Jason Wang , SeongJae Park , linux-hyperv@vger.kernel.org, platform-driver-x86@vger.kernel.org, Frank Li , netdev@vger.kernel.org, Qinglang Miao , Jiri Slaby , Rob Herring , Lorenzo Pieralisi , Mark Gross , linux-staging@lists.linux.dev, Dexuan Cui , Jernej Skrabec , Kishon Vijay Abraham I , Chen-Yu Tsai , linux-input@vger.kernel.org, Allen Hubbe , Alex Dubov , Haiyang Zhang , Jiri Kosina , Vladimir Zapolskiy , Ben Widawsky , Moritz Fischer , linux-cxl@vger.kernel.org, Michael Buesch , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , "Martin K. Petersen" , Martyn Welch , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev, Stefan Richter , Sudeep Holla , "David S. Miller" , Sven Van Asbroeck , kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Bjorn Andersson , Kirti Wankhede , Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Lee Jones , Arnd Bergmann , linux-scsi@vger.kernel.org, Vishal Verma , Russell King , Andy Gross , linux-serial@vger.kernel.org, Jakub Kicinski , Michael Jamet , William Breathitt Gray , Hans de Goede , Hannes Reinecke , Adrian Hunter , Juergen Gross , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Alexandre Bounine , Vinod Koul , Mark Brown , Marc Zyngier , dmaengine@vger.kernel.org, Johannes Berg , Maximilian Luz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 06 2021, Uwe Kleine-K=C3=B6nig = wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. Yay! > > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return void" that is not yet applied, see > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutro= nix.de. > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > surprised if I still missed to convert a driver. So it would be great to > get this into next early after the merge window closes. I'm afraid you missed the s390-specific busses in drivers/s390/cio/ (css/ccw/ccwgroup). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7CEDC11F6C for ; Tue, 6 Jul 2021 10:57:49 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 898A161A14 for ; Tue, 6 Jul 2021 10:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 898A161A14 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4E385404AF; Tue, 6 Jul 2021 10:57:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gtdzm-tQWCTs; Tue, 6 Jul 2021 10:57:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9D3B440450; Tue, 6 Jul 2021 10:57:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7976BC001A; Tue, 6 Jul 2021 10:57:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 97915C000E for ; Tue, 6 Jul 2021 10:57:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 753D340192 for ; Tue, 6 Jul 2021 10:57:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iqRKP-jQPgpe for ; Tue, 6 Jul 2021 10:57:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5AE68400D0 for ; Tue, 6 Jul 2021 10:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625569063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; b=Tpitbp8kRSV2Hc2y6VIhqDekGY7ZfeSw1kRC+BpUzdAdWDjVolk9floMPAIccWCKebta0U 41FDt47yB0fzRf/2Kg6HJo1mf3TAQLqXEk9QilWjSmo7/7k26EWUm7t8rCvaA0yK9jrXp0 lpxxx/yL6IbqFrmFw/bhdsMwYLpf2fo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-5mCOs4Y3P-6VHTb8_rh9-g-1; Tue, 06 Jul 2021 06:57:41 -0400 X-MC-Unique: 5mCOs4Y3P-6VHTb8_rh9-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 481AE100B3AC; Tue, 6 Jul 2021 10:57:36 +0000 (UTC) Received: from localhost (ovpn-113-13.ams2.redhat.com [10.36.113.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A0A60CC6; Tue, 6 Jul 2021 10:57:19 +0000 (UTC) From: Cornelia Huck To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Subject: Re: [PATCH] bus: Make remove callback return void In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Organization: Red Hat GmbH References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 06 Jul 2021 12:57:17 +0200 Message-ID: <87pmvvhfqq.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: nvdimm@lists.linux.dev, Benjamin Herrenschmidt , Samuel Iglesias Gonsalvez , Jens Taprogge , Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , Wei Liu , Maxim Levitsky , Samuel Holland , Michael Ellerman , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Tomas Winkler , Julien Grall , Ohad Ben-Cohen , Alex Elder , linux-parisc@vger.kernel.org, Geoff Levand , linux-fpga@vger.kernel.org, linux-usb@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Thorsten Scherer , kernel@pengutronix.de, Jon Mason , linux-ntb@googlegroups.com, Wu Hao , David Woodhouse , Krzysztof =?utf-8?Q?Wilczy=C5=84sk?= =?utf-8?Q?i?= , Alexandre Belloni , Manohar Vanga , linux-wireless@vger.kernel.org, Dominik Brodowski , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , target-devel@vger.kernel.org, Srinivas Kandagatla , linux-i2c@vger.kernel.org, Kai-Heng Feng , Stefano Stabellini , Stephen Hemminger , Ira Weiny , Helge Deller , =?utf-8?Q?Rafa=C5=82_Mi=C5=82eck?= =?utf-8?Q?i?= , industrypack-devel@lists.sourceforge.net, linux-mips@vger.kernel.org, Len Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, Maxime Ripard , Johan Hovold , greybus-dev@lists.linaro.org, Bjorn Helgaas , Dave Jiang , Boris Ostrovsky , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Johannes Thumshirn , Mathieu Poirier , Stephen Boyd , Wolfram Sang , Joey Pabalan , Yehezkel Bernat , Pali =?utf-8?Q?Roh=C3=A1r?= , Bodo Stroesser , Alison Schofield , Heikki Krogerus , Tyrel Datwyler , Alexander Shishkin , Tom Rix , SeongJae Park , linux-hyperv@vger.kernel.org, platform-driver-x86@vger.kernel.org, Frank Li , netdev@vger.kernel.org, Qinglang Miao , Jiri Slaby , Rob Herring , Lorenzo Pieralisi , Mark Gross , linux-staging@lists.linux.dev, Dexuan Cui , Jernej Skrabec , Kishon Vijay Abraham I , Chen-Yu Tsai , linux-input@vger.kernel.org, Matt Porter , Allen Hubbe , Alex Dubov , Haiyang Zhang , Jiri Kosina , Vladimir Zapolskiy , Ben Widawsky , Moritz Fischer , linux-cxl@vger.kernel.org, Michael Buesch , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , "Martin K. Petersen" , Martyn Welch , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev, Stefan Richter , Sudeep Holla , "David S. Miller" , Sven Van Asbroeck , kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Bjorn Andersson , Kirti Wankhede , Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Lee Jones , Arnd Bergmann , linux-scsi@vger.kernel.org, Vishal Verma , Russell King , Andy Gross , linux-serial@vger.kernel.org, Jakub Kicinski , Michael Jamet , William Breathitt Gray , Hans de Goede , Adrian Hunter , Juergen Gross , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Alexandre Bounine , Vinod Koul , Mark Brown , Marc Zyngier , dmaengine@vger.kernel.org, Johannes Berg , Maximilian Luz X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBKdWwgMDYgMjAyMSwgVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0Bw ZW5ndXRyb25peC5kZT4gd3JvdGU6Cgo+IFRoZSBkcml2ZXIgY29yZSBpZ25vcmVzIHRoZSByZXR1 cm4gdmFsdWUgb2YgdGhpcyBjYWxsYmFjayBiZWNhdXNlIHRoZXJlCj4gaXMgb25seSBsaXR0bGUg aXQgY2FuIGRvIHdoZW4gYSBkZXZpY2UgZGlzYXBwZWFycy4KPgo+IFRoaXMgaXMgdGhlIGZpbmFs IGJpdCBvZiBhIGxvbmcgbGFzdGluZyBjbGVhbnVwIHF1ZXN0IHdoZXJlIHNldmVyYWwKPiBidXNl cyB3ZXJlIGNvbnZlcnRlZCB0byBhbHNvIHJldHVybiB2b2lkIGZyb20gdGhlaXIgcmVtb3ZlIGNh bGxiYWNrLgo+IEFkZGl0aW9uYWxseSBzb21lIHJlc291cmNlIGxlYWtzIHdlcmUgZml4ZWQgdGhh dCB3ZXJlIGNhdXNlZCBieSBkcml2ZXJzCj4gcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUgaW4gdGhl IGV4cGVjdGF0aW9uIHRoYXQgdGhlIGRyaXZlciB3b24ndCBnbwo+IGF3YXkuCj4KPiBXaXRoIHN0 cnVjdCBidXNfdHlwZTo6cmVtb3ZlIHJldHVybmluZyB2b2lkIGl0J3MgcHJldmVudGVkIHRoYXQg bmV3bHkKPiBpbXBsZW1lbnRlZCBidXNlcyByZXR1cm4gYW4gaWdub3JlZCBlcnJvciBjb2RlIGFu ZCBzbyBkb24ndCBhbnRpY2lwYXRlCj4gd3JvbmcgZXhwZWN0YXRpb25zIGZvciBkcml2ZXIgYXV0 aG9ycy4KCllheSEKCj4KPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVp bmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+IEhlbGxvLAo+Cj4gdGhpcyBwYXRjaCBk ZXBlbmRzIG9uICJQQ0k6IGVuZHBvaW50OiBNYWtlIHN0cnVjdCBwY2lfZXBmX2RyaXZlcjo6cmVt b3ZlCj4gcmV0dXJuIHZvaWQiIHRoYXQgaXMgbm90IHlldCBhcHBsaWVkLCBzZWUKPiBodHRwczov L2xvcmUua2VybmVsLm9yZy9yLzIwMjEwMjIzMDkwNzU3LjU3NjA0LTEtdS5rbGVpbmUta29lbmln QHBlbmd1dHJvbml4LmRlLgo+Cj4gSSB0ZXN0ZWQgaXQgdXNpbmcgYWxsbW9kY29uZmlnIG9uIGFt ZDY0IGFuZCBhcm0sIGJ1dCBJIHdvdWxkbid0IGJlCj4gc3VycHJpc2VkIGlmIEkgc3RpbGwgbWlz c2VkIHRvIGNvbnZlcnQgYSBkcml2ZXIuIFNvIGl0IHdvdWxkIGJlIGdyZWF0IHRvCj4gZ2V0IHRo aXMgaW50byBuZXh0IGVhcmx5IGFmdGVyIHRoZSBtZXJnZSB3aW5kb3cgY2xvc2VzLgoKSSdtIGFm cmFpZCB5b3UgbWlzc2VkIHRoZSBzMzkwLXNwZWNpZmljIGJ1c3NlcyBpbiBkcml2ZXJzL3MzOTAv Y2lvLwooY3NzL2Njdy9jY3dncm91cCkuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRp b25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRp b24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A7CC19F38 for ; Fri, 30 Jul 2021 19:40:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22B8A600CD for ; Fri, 30 Jul 2021 19:40:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 22B8A600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UjIMinz04QRXFF50d/+VI0Y8vzpq/66YG123rbjBJE8=; b=KHq2CFIQfbCwjG OsqYJJyNUxUnakNxoHlhjLrluu20PBY1BtVkQ56U3IlhfdoQFAAfHxxULPbkL314kZUtN7QiTZ1UU AukwGOa2KlD5pc4uRMQHdNh7r8Q3GoUH2Wg0X1LOEDOZVgRlhd2wzKVZ2fFOUcRy+mP9xJrjfmhDs lF873L27tWkrsxQHDTDgnlcvN/lJQuN/7KnWNJYU0bJdFJutFPvPcsBaj3wCbQa4qCVJH/3lVxF50 0mL3LNLnE7DXRt/6k6mpoZHEdR2HCN30AQD0JJI0vbFLBmjPs/Qjg9osckPsdN12lQltrx1XjXAG5 mcKMUQehLgrS05StSvyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9YMr-00A8Oj-Lm; Fri, 30 Jul 2021 19:40:25 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0ilu-00B8Rg-2G for linux-i3c@lists.infradead.org; Tue, 06 Jul 2021 10:57:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625569063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUyu+xoe1E6BsQbSDzUeyLIXRBJKwC/I/FCZr8qcsPA=; b=Tpitbp8kRSV2Hc2y6VIhqDekGY7ZfeSw1kRC+BpUzdAdWDjVolk9floMPAIccWCKebta0U 41FDt47yB0fzRf/2Kg6HJo1mf3TAQLqXEk9QilWjSmo7/7k26EWUm7t8rCvaA0yK9jrXp0 lpxxx/yL6IbqFrmFw/bhdsMwYLpf2fo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-5mCOs4Y3P-6VHTb8_rh9-g-1; Tue, 06 Jul 2021 06:57:41 -0400 X-MC-Unique: 5mCOs4Y3P-6VHTb8_rh9-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 481AE100B3AC; Tue, 6 Jul 2021 10:57:36 +0000 (UTC) Received: from localhost (ovpn-113-13.ams2.redhat.com [10.36.113.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 95A0A60CC6; Tue, 6 Jul 2021 10:57:19 +0000 (UTC) From: Cornelia Huck To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Geoff Levand , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Rafael J. Wysocki" , Len Brown , William Breathitt Gray , =?utf-8?Q?Rafa=C5=82_Mi=C5=82eck?= =?utf-8?Q?i?= , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams , Dave Jiang , Vinod Koul , Stefan Richter , Sudeep Holla , Cristian Marussi , Wu Hao , Tom Rix , Moritz Fischer , Jiri Kosina , Benjamin Tissoires , Srinivas Pandruvada , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Alexander Shishkin , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Samuel Iglesias Gonsalvez , Jens Taprogge , Johannes Thumshirn , Mauro Carvalho Chehab , Maxim Levitsky , Alex Dubov , Ulf Hansson , Lee Jones , Tomas Winkler , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , Jon Mason , Allen Hubbe , Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84sk?= =?utf-8?Q?i?= , Bjorn Helgaas , Dominik Brodowski , Maximilian Luz , Hans de Goede , Mark Gross , Matt Porter , Alexandre Bounine , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Thorsten Scherer , Srinivas Kandagatla , Andy Gross , Mark Brown , Stephen Boyd , Michael Buesch , Sven Van Asbroeck , Johan Hovold , Alex Elder , Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Rob Herring , Jiri Slaby , Heikki Krogerus , "Michael S. Tsirkin" , Jason Wang , Kirti Wankhede , Alex Williamson , Martyn Welch , Manohar Vanga , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Johannes Berg , Jaroslav Kysela , Takashi Iwai , Marc Zyngier , Tyrel Datwyler , Vladimir Zapolskiy , Samuel Holland , Qinglang Miao , Alexey Kardashevskiy , Kai-Heng Feng , Joey Pabalan , Pali =?utf-8?Q?Roh=C3=A1r?= , Adrian Hunter , Frank Li , Mike Christie , Bodo Stroesser , Hannes Reinecke , David Woodhouse , SeongJae Park , Julien Grall , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH] bus: Make remove callback return void In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Organization: Red Hat GmbH References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 06 Jul 2021 12:57:17 +0200 Message-ID: <87pmvvhfqq.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_035746_422734_B906144F X-CRM114-Status: GOOD ( 25.99 ) X-Mailman-Approved-At: Fri, 30 Jul 2021 12:40:21 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdWwgMDYgMjAyMSwgVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0Bw ZW5ndXRyb25peC5kZT4gd3JvdGU6Cgo+IFRoZSBkcml2ZXIgY29yZSBpZ25vcmVzIHRoZSByZXR1 cm4gdmFsdWUgb2YgdGhpcyBjYWxsYmFjayBiZWNhdXNlIHRoZXJlCj4gaXMgb25seSBsaXR0bGUg aXQgY2FuIGRvIHdoZW4gYSBkZXZpY2UgZGlzYXBwZWFycy4KPgo+IFRoaXMgaXMgdGhlIGZpbmFs IGJpdCBvZiBhIGxvbmcgbGFzdGluZyBjbGVhbnVwIHF1ZXN0IHdoZXJlIHNldmVyYWwKPiBidXNl cyB3ZXJlIGNvbnZlcnRlZCB0byBhbHNvIHJldHVybiB2b2lkIGZyb20gdGhlaXIgcmVtb3ZlIGNh bGxiYWNrLgo+IEFkZGl0aW9uYWxseSBzb21lIHJlc291cmNlIGxlYWtzIHdlcmUgZml4ZWQgdGhh dCB3ZXJlIGNhdXNlZCBieSBkcml2ZXJzCj4gcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUgaW4gdGhl IGV4cGVjdGF0aW9uIHRoYXQgdGhlIGRyaXZlciB3b24ndCBnbwo+IGF3YXkuCj4KPiBXaXRoIHN0 cnVjdCBidXNfdHlwZTo6cmVtb3ZlIHJldHVybmluZyB2b2lkIGl0J3MgcHJldmVudGVkIHRoYXQg bmV3bHkKPiBpbXBsZW1lbnRlZCBidXNlcyByZXR1cm4gYW4gaWdub3JlZCBlcnJvciBjb2RlIGFu ZCBzbyBkb24ndCBhbnRpY2lwYXRlCj4gd3JvbmcgZXhwZWN0YXRpb25zIGZvciBkcml2ZXIgYXV0 aG9ycy4KCllheSEKCj4KPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVp bmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+IEhlbGxvLAo+Cj4gdGhpcyBwYXRjaCBk ZXBlbmRzIG9uICJQQ0k6IGVuZHBvaW50OiBNYWtlIHN0cnVjdCBwY2lfZXBmX2RyaXZlcjo6cmVt b3ZlCj4gcmV0dXJuIHZvaWQiIHRoYXQgaXMgbm90IHlldCBhcHBsaWVkLCBzZWUKPiBodHRwczov L2xvcmUua2VybmVsLm9yZy9yLzIwMjEwMjIzMDkwNzU3LjU3NjA0LTEtdS5rbGVpbmUta29lbmln QHBlbmd1dHJvbml4LmRlLgo+Cj4gSSB0ZXN0ZWQgaXQgdXNpbmcgYWxsbW9kY29uZmlnIG9uIGFt ZDY0IGFuZCBhcm0sIGJ1dCBJIHdvdWxkbid0IGJlCj4gc3VycHJpc2VkIGlmIEkgc3RpbGwgbWlz c2VkIHRvIGNvbnZlcnQgYSBkcml2ZXIuIFNvIGl0IHdvdWxkIGJlIGdyZWF0IHRvCj4gZ2V0IHRo aXMgaW50byBuZXh0IGVhcmx5IGFmdGVyIHRoZSBtZXJnZSB3aW5kb3cgY2xvc2VzLgoKSSdtIGFm cmFpZCB5b3UgbWlzc2VkIHRoZSBzMzkwLXNwZWNpZmljIGJ1c3NlcyBpbiBkcml2ZXJzL3MzOTAv Y2lvLwooY3NzL2Njdy9jY3dncm91cCkuCgoKLS0gCmxpbnV4LWkzYyBtYWlsaW5nIGxpc3QKbGlu dXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1pM2MK