From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB96C433ED for ; Wed, 12 May 2021 10:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 886A0613D3 for ; Wed, 12 May 2021 10:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbhELKKX (ORCPT ); Wed, 12 May 2021 06:10:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:60466 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbhELKKV (ORCPT ); Wed, 12 May 2021 06:10:21 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 09DDDAF3B; Wed, 12 May 2021 10:09:12 +0000 (UTC) Received: from localhost (brahms [local]) by brahms (OpenSMTPD) with ESMTPA id aa6435b1; Wed, 12 May 2021 10:10:46 +0000 (UTC) From: Luis Henriques To: David Howells Cc: Dominique Martinet , Eric Van Hensbergen , Latchesar Ionkov , linux-fsdevel@vger.kernel.org, v9fs-developer@lists.sourceforge.net Subject: Re: 9p: fscache duplicate cookie References: <871rae24kv.fsf@suse.de> <87czu45gcs.fsf@suse.de> <87zgx83vj9.fsf@suse.de> <87r1ii4i2a.fsf@suse.de> <875yzq270z.fsf@suse.de> <2508106.1620737077@warthog.procyon.org.uk> Date: Wed, 12 May 2021 11:10:45 +0100 In-Reply-To: <2508106.1620737077@warthog.procyon.org.uk> (David Howells's message of "Tue, 11 May 2021 13:44:37 +0100") Message-ID: <87pmxwz2hm.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org David Howells writes: > Luis Henriques wrote: > >> + if (data->inode < inode) >> + node = node->rb_left; >> + else if (data->inode > inode) >> + node = node->rb_right; > > If you're just using a plain integer as the key into your debug tree, an > xarray, IDA or IDR might be easier to use. Yep, xarray actually crossed my mind but rbtrees were still fresh in my memory. I'll look into the xarray API next time (which is likely to be much simpler, I know). Cheers, -- Luis