From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B5AC433DB for ; Fri, 19 Feb 2021 11:51:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CC2964EB3 for ; Fri, 19 Feb 2021 11:51:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CC2964EB3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD4Ja-0002t6-QS for qemu-devel@archiver.kernel.org; Fri, 19 Feb 2021 06:51:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD4IE-0001EL-QM for qemu-devel@nongnu.org; Fri, 19 Feb 2021 06:49:54 -0500 Received: from mx2.suse.de ([195.135.220.15]:48708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD4ID-0004Dm-45 for qemu-devel@nongnu.org; Fri, 19 Feb 2021 06:49:54 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D47BAC6E; Fri, 19 Feb 2021 11:49:50 +0000 (UTC) Received: from localhost (brahms [local]) by brahms (OpenSMTPD) with ESMTPA id 6912d8ed; Fri, 19 Feb 2021 11:50:54 +0000 (UTC) From: Luis Henriques To: Vivek Goyal Subject: Re: [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl References: <20210217233046.81418-1-vgoyal@redhat.com> Date: Fri, 19 Feb 2021 11:50:54 +0000 In-Reply-To: <20210217233046.81418-1-vgoyal@redhat.com> (Vivek Goyal's message of "Wed, 17 Feb 2021 18:30:43 -0500") Message-ID: <87pn0wgtsx.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=195.135.220.15; envelope-from=lhenriques@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, miklos@szeredi.hu, qemu-devel@nongnu.org, stefanha@redhat.com, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vivek Goyal writes: > Hi, > > This is V2 of the patches. Changes since v1 are. > > - Rebased on top of latest master. > - Took care of Miklos's comments to block acl xattrs if user > explicitly disabled posix acl. > > Luis Henriques reported that fstest generic/099 fails with virtiofs. > Little debugging showed that we don't enable acl support. So this > patch series provides option to enable/disable posix acl support. By > default it is disabled. > > I have run blogbench and pjdfstests with posix acl enabled and > things work fine. > > Luis, can you please apply these patches, and run virtiofsd with > "-o posix_acl" and see if it fixes the failure you are seeing. I > ran the steps you provided manually and it fixes the issue for > me. Sorry for the delay. I've finally tested these patches and they indeed fix the problem I reported. My only question about this fix is why is this option not enabled by default, since this is the documented behavior in acl(5) and umask(2)? In fact, why is this an option at all? Cheers, -- Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Henriques References: <20210217233046.81418-1-vgoyal@redhat.com> Date: Fri, 19 Feb 2021 11:50:54 +0000 In-Reply-To: <20210217233046.81418-1-vgoyal@redhat.com> (Vivek Goyal's message of "Wed, 17 Feb 2021 18:30:43 -0500") Message-ID: <87pn0wgtsx.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Virtio-fs] [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vivek Goyal Cc: virtio-fs@redhat.com, miklos@szeredi.hu, qemu-devel@nongnu.org Vivek Goyal writes: > Hi, > > This is V2 of the patches. Changes since v1 are. > > - Rebased on top of latest master. > - Took care of Miklos's comments to block acl xattrs if user > explicitly disabled posix acl. > > Luis Henriques reported that fstest generic/099 fails with virtiofs. > Little debugging showed that we don't enable acl support. So this > patch series provides option to enable/disable posix acl support. By > default it is disabled. > > I have run blogbench and pjdfstests with posix acl enabled and > things work fine. > > Luis, can you please apply these patches, and run virtiofsd with > "-o posix_acl" and see if it fixes the failure you are seeing. I > ran the steps you provided manually and it fixes the issue for > me. Sorry for the delay. I've finally tested these patches and they indeed fix the problem I reported. My only question about this fix is why is this option not enabled by default, since this is the documented behavior in acl(5) and umask(2)? In fact, why is this an option at all? Cheers, -- Luis