From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CD0C433DF for ; Fri, 31 Jul 2020 10:06:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB0B1208E4 for ; Fri, 31 Jul 2020 10:06:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="j8Ac/NWY"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="0CQ1YWAd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732326AbgGaKGy (ORCPT ); Fri, 31 Jul 2020 06:06:54 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:57074 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732140AbgGaKGx (ORCPT ); Fri, 31 Jul 2020 06:06:53 -0400 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1596190011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YC/hy5UukrQWbwN2wHfj+RwU5XRQ5rQoGBNALt8r51I=; b=j8Ac/NWYZU1HM9hgVANOh1TqR8nhB4yIBOmgcHlJBdu7tE2ruU1I6jPgwA4r2UCQMPlRg8 6rNEYA/1/1CzgQ5J1xRhvm7YGDv+KmwbK/PVCNIU3CcjCqRIkgXrJi1CUxaYZk5OiuNbt9 ZzfC8FakpUYUvf8Uv4iONqtDOMrf8K/Y9z3y9VFaMp979eGqCQVr+luglZMAweVY71SD8K RhnmunL0idzfYRu/bEQiumxhlDPAQwWgRNGtSHe7Cuc6RvwFdfd10vFGlwxtW3LziJhu8u LQ0wC1Q/0+PRSX34Y7dFU9+JcuGoD3IdjyhxAv9bfvLcEKErMp30Wg98Iw9Puw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1596190011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YC/hy5UukrQWbwN2wHfj+RwU5XRQ5rQoGBNALt8r51I=; b=0CQ1YWAdsACb6Q4Ol4Jjb6PBBQVkNW0UmRjT957GpEQO/pRtCA8YOtPqTjbqaB4FIPCa15 yMDpqxQQPfExu7Dg== To: Petr Machata Cc: Richard Cochran , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Heiner Kallweit , Russell King , Grygorii Strashko , Ivan Khoronzhuk , Samuel Zou , netdev@vger.kernel.org, Russell King Subject: Re: [PATCH v3 1/9] ptp: Add generic ptp v2 header parsing function In-Reply-To: <87lfj1gvgq.fsf@mellanox.com> References: <20200730080048.32553-1-kurt@linutronix.de> <20200730080048.32553-2-kurt@linutronix.de> <87lfj1gvgq.fsf@mellanox.com> Date: Fri, 31 Jul 2020 12:06:50 +0200 Message-ID: <87pn8c0zid.fsf@kurt> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu Jul 30 2020, Petr Machata wrote: > Kurt Kanzenbach writes: > >> @@ -107,6 +107,37 @@ unsigned int ptp_classify_raw(const struct sk_buff = *skb) >> } >> EXPORT_SYMBOL_GPL(ptp_classify_raw); >>=20=20 >> +struct ptp_header *ptp_parse_header(struct sk_buff *skb, unsigned int t= ype) >> +{ >> + u8 *data =3D skb_mac_header(skb); >> + u8 *ptr =3D data; > > One of the "data" and "ptr" variables is superfluous. Yeah. Can be shortened to u8 *ptr =3D skb_mac_header(skb); However, I'll wait a bit before sending the next version. So, that the other maintainers have time to test their drivers. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEooWgvezyxHPhdEojeSpbgcuY8KYFAl8j7ToACgkQeSpbgcuY 8KYDPw//Q6a2p18zlyAjD7GSe/+e+Z5GCzkCit+QFlp9AMG2uZUHIN/2kX+udynJ fw1lYvRkLkO41Vb9ktPapGaWlnQMwfX6AnKWI9loNML6R7jZUnT5XJMtIEeWkz0I VAiHu67jV4jQ8hPdZYaDpgKMvLNYAyCkbrk4sHjLdJAfKE3tFhi2g1TjadHalfWY nWT/TedR+A6+eFLCEvQvhg/k+dh8udMI+lumGmAJBksdTdyAdk35QQ2KwUNzSxPD rCuSdgp5damVeLEW9JeNI24zin5XzZvBWhHbRueIwAslstWVCLEUmoICXgp/srwV LJcL40sohyGnSVyQ+FLvFCm9HOlbXOJfbFG3pBtPrxT9o4UYgQlJ1eKCLKPl6vEW sMLpmWwCjyEMUEg4UVo32tI1vclrsi+LKVOqx4YMFuhCVJUCJJX8Vbhd8KG1yOtV 2gjJ+BhP8rOhkAc7Fzup4u18Yoetnk5/vonb67v7yyUeN/5NJP9w0/Jzg1jhMXEB xlzVBx44vRMh8B9n6vbHhUHWu87kZtHRoXAxqfWXGU1F1t12JzKeUxkFjfnDGa03 SN3lIGPodx9GsiVRKNOj5dK8GbUO0gBDh4vxzQ0s7Pzoj33sAHRbQ0xL37cuaHjE 9Q6rdvv8OflfW9KXaVNwfURCDsTKkONuP/1x/3AcCH5bvaPZTpc= =UxOJ -----END PGP SIGNATURE----- --=-=-=--