From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF5AC433E0 for ; Mon, 13 Jul 2020 06:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9C4520720 for ; Mon, 13 Jul 2020 06:35:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="oOiV1kSc"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="E1asMlFW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729119AbgGMGfq (ORCPT ); Mon, 13 Jul 2020 02:35:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgGMGfp (ORCPT ); Mon, 13 Jul 2020 02:35:45 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3D51C061794; Sun, 12 Jul 2020 23:35:45 -0700 (PDT) From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1594622144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lGwmJIkZOZkMHJGtImhb5KqsxN75lLuiXne9IMeGa/A=; b=oOiV1kScW2I2fOrQI2UkUlnU9FL+ia6y5UCOhe9XKKToyeXoMs7riH3eSbnViK5X/UVodR skTyg0yc7dKwfKEGKZeNW4NG8hoYjoC2bEnRsUUZuDMmA7i6FT81rbeG+F2J+WSFwdqDhk G9Cxv5Jo53WG4gTIW+TDYWLzcAfn5qqg8oGonbIhSN4VCDmDLwE8cxRfnIGNohqqFzU21G YBsS0BgDDX5im9WOrN8zu3+FGSjZ5SgYySHNp7IRfL3xSdTEPnV0uTt6hsajMGaa0RnOBt 2JsmVjrcDV3IByF2wRI4rWlWkyZX20//OXjXUckptY6n7YvtrENR0+ZfqaOqYQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1594622144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lGwmJIkZOZkMHJGtImhb5KqsxN75lLuiXne9IMeGa/A=; b=E1asMlFW5LrXUA2VCU8sD4kjaSOZE8GaMxZVbCXjklrYTfzdiQ6rfV/9GwcUm3+WUQLZmW IVX+ciVo5bYGHxDw== To: Richard Cochran Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Sebastian Andrzej Siewior , Kamil Alkhouri , ilias.apalodimas@linaro.org, Vladimir Oltean Subject: Re: [PATCH v1 4/8] net: dsa: hellcreek: Add support for hardware timestamping In-Reply-To: <20200711203810.GB27467@hoboy> References: <20200710113611.3398-1-kurt@linutronix.de> <20200710113611.3398-5-kurt@linutronix.de> <20200711203810.GB27467@hoboy> Date: Mon, 13 Jul 2020 08:35:43 +0200 Message-ID: <87pn8zncqo.fsf@kurt> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --=-=-= Content-Type: text/plain On Sat Jul 11 2020, Richard Cochran wrote: > On Fri, Jul 10, 2020 at 01:36:07PM +0200, Kurt Kanzenbach wrote: >> +static void hellcreek_get_rxts(struct hellcreek *hellcreek, >> + struct hellcreek_port_hwtstamp *ps, >> + struct sk_buff *skb, struct sk_buff_head *rxq, >> + int port) >> +{ >> + struct skb_shared_hwtstamps *shwt; >> + struct sk_buff_head received; >> + unsigned long flags; >> + >> + /* The latched timestamp belongs to one of the received frames. */ >> + __skb_queue_head_init(&received); >> + >> + /* Lock & disable interrupts */ >> + spin_lock_irqsave(&rxq->lock, flags); >> + >> + /* Add the reception queue "rxq" to the "received" queue an reintialize >> + * "rxq". From now on, we deal with "received" not with "rxq" >> + */ >> + skb_queue_splice_tail_init(rxq, &received); >> + >> + spin_unlock_irqrestore(&rxq->lock, flags); >> + >> + for (; skb; skb = __skb_dequeue(&received)) { >> + unsigned int type; >> + u8 *hdr; >> + u64 ns; >> + >> + /* Get nanoseconds from ptp packet */ >> + type = SKB_PTP_TYPE(skb); >> + hdr = parse_ptp_header(skb, type); >> + ns = hellcreek_get_reserved_field(hdr); > > You might consider clearing the reserved field at this point. Some > user space SW might consider non-zero reserved fields as corrupt! Indeed. Never thought about it. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEooWgvezyxHPhdEojeSpbgcuY8KYFAl8MAL8ACgkQeSpbgcuY 8KY1TA/+KEdPEl04h/iBlEc7pnDGDE0KAnasnn5FoDOCaQdNiK5lUyvV3F0aG6JT 4Y4K8bjNiFVoWczws2xJ7G/fdLL/EoSURiHUaq6tY5ciCRBUbG51H4Q6nBBPY8nR CZqQMcBrki3/fWNB0XICv+iXyvmUEQ6wxBckHKU6cCmVxbiKKcD7m6gTVfrgJD26 261IlZuLxrn4CYtWD/pi897rMMO96SMKKWNuRLsDf0v86IOf8SFP1CTKAF2uGs1Y k6HkoIK65F9EXEECk99tDoW/rzk1SqFEOzFHzVt/Qqa41Np87Jx/Z75O+9ge/qmj IfsOUrgIOkOLiCfWr0poFGR6a5SUFi2m43IOQ8hndWbF08ySWdfXL94ChwUEZAXC XIj9BSJdlZTYaEhygWlyrTWuOjDxDKM276W5PISVMIXfSr5Z02iYe7oAUY1SKagT vMYzeZnTajzcc0JEVjzRdd5dzXrcvQ8ta3OaLtJUSByZ3S0GoFsmhE30gTrt31ye fsi/RTk6/Nkzmt0nwQjBkWyeJLb0g2gs61viRo8e0K/siP3LrlZnj5eC3r0wybOQ GFsJGyI9w3yx/DuXJMyfCu+2tixpvyIpKi+vGYOA7MXO68gUy11wxAtGx8EJyDIl CJt7bj3msEzGQQ/z1p4pFNubCZIaNpV54KjK6sueKJ67zuQ5hOY= =KSHc -----END PGP SIGNATURE----- --=-=-=--