From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE052C433E2 for ; Wed, 27 May 2020 16:09:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DD1720873 for ; Wed, 27 May 2020 16:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fhi/ZH/v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DD1720873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdycw-0000c8-O2 for qemu-devel@archiver.kernel.org; Wed, 27 May 2020 12:09:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdycI-00008I-KC for qemu-devel@nongnu.org; Wed, 27 May 2020 12:09:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49287 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdybo-0007Dw-UB for qemu-devel@nongnu.org; Wed, 27 May 2020 12:09:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590595726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sn6AfBL39USHD1b+hTiVbPfKRNcoYZw5du1Uh0pkzVU=; b=Fhi/ZH/vtH6iVgInIpc2qdhcuixv874Zn/Yz4uJNK9rxsHfFansPSgqIGTob1ptByKryQs ClltkUT4Zqf4PgZ/GxzbGMqTzFlFd7oWR3shdbrJe/Wc0i1UNPMdWeCY0Afb3Yxiz9mHfO FjRErIi4mM2R/hHCvlkVTgipsKGm7Qo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-JkEOzvkEMTq_v4b4w_mtIA-1; Wed, 27 May 2020 12:08:42 -0400 X-MC-Unique: JkEOzvkEMTq_v4b4w_mtIA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 482071B18BC2; Wed, 27 May 2020 16:08:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8FA21A8F1; Wed, 27 May 2020 16:08:40 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 75CB3113864A; Wed, 27 May 2020 18:08:39 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Subject: Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices References: <20200518050408.4579-1-armbru@redhat.com> <20200518050408.4579-10-armbru@redhat.com> <87wo4xxya0.fsf@dusky.pond.sub.org> Date: Wed, 27 May 2020 18:08:39 +0200 In-Reply-To: (Peter Maydell's message of "Wed, 27 May 2020 16:05:15 +0100") Message-ID: <87pnapwebc.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/27 01:25:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Paolo Bonzini , "Daniel P. Berrange" , Laurent Vivier , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Wed, 27 May 2020 at 15:12, Markus Armbruster wrote: >> * PATCH 08: in a realize method. Can't actually fail, so let's use >> &error_abort. >> >> * PATCH 09 (this one): likewise. > > I disagree with these. We're in a realize function, the API > says "on errors, report them via the Error* you got passed", > so we should do that, not blow up. &error_abort only makes > sense if (a) we have no better way to report errors than > to abort (which isn't the case here) or (b) if we can guarantee > that in fact the thing we're doing won't ever fail I detest impossible (and therefore untestable) error paths. > (which we can't here without knowing more about the internal > implementation details of the MOS6522 device than we > really ought to). At least the child devices are all defined in the same file. My second line of defense: my patches are strict improvments. If you want further improvements, I'd prefer you propose them as patches on top of mine.