From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 783D1C33CB1 for ; Tue, 14 Jan 2020 07:56:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 419F3207FF for ; Tue, 14 Jan 2020 07:56:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MU2TSBy7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 419F3207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irH3t-0005qb-FP for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 02:56:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44739) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irH33-0005Bh-CE for qemu-devel@nongnu.org; Tue, 14 Jan 2020 02:55:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irH31-0006Iq-35 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 02:55:36 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:50050 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irH30-0006IF-RI for qemu-devel@nongnu.org; Tue, 14 Jan 2020 02:55:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578988533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4q90mFfpgBnql4cHvswY3fLuXnuX6PeM9otqNKL0iXQ=; b=MU2TSBy7QsItJflIhANrT3oQ+V9DWNg/8uINnA+WlViOQbpCvWdlmGFhSPC+Y+PacXReu6 j1yk2vNRUeEupqDTM7oh8HEBCUC6hej1w1NaYwgKGkCqBPfajPpiHOKJDfQW6niWV1PYJi 1PZ1AxCliwnE6Y/Pialuwo9ZFs5xIxQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-EzU2WDySP7OehJaLvCVKpQ-1; Tue, 14 Jan 2020 02:55:30 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85CAF800D55; Tue, 14 Jan 2020 07:55:29 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-131.ams2.redhat.com [10.36.116.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 391CA80F63; Tue, 14 Jan 2020 07:55:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C2E261138600; Tue, 14 Jan 2020 08:55:27 +0100 (CET) From: Markus Armbruster To: Laurent Vivier Subject: Re: [PATCH v1 12/59] virtfs-proxy-helper.c: remove 'err_out' label in setugid() References: <20200106182425.20312-1-danielhb413@gmail.com> <20200106182425.20312-13-danielhb413@gmail.com> <20200107105113.7a443d51@bahia.lan> <87wo9vxu9n.fsf@dusky.pond.sub.org> Date: Tue, 14 Jan 2020 08:55:27 +0100 In-Reply-To: (Laurent Vivier's message of "Mon, 13 Jan 2020 17:32:31 +0100") Message-ID: <87pnfmlbf4.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: EzU2WDySP7OehJaLvCVKpQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Daniel Henrique Barboza , Greg Kurz , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Laurent Vivier writes: > Le 13/01/2020 =C3=A0 16:15, Markus Armbruster a =C3=A9crit=C2=A0: >> Greg Kurz writes: >>=20 >>> On Mon, 6 Jan 2020 15:23:38 -0300 >>> Daniel Henrique Barboza wrote: >>> >>>> 'err_out' can be removed and be replaced by 'return -errno' >>>> in its only instance in the function. >>>> >>>> CC: Greg Kurz >>>> Signed-off-by: Daniel Henrique Barboza >>>> --- >>> >>> I don't really mind, but I confirm this doesn't change behavior. >>> >>> Acked-by: Greg Kurz >>> >>> What's the plan to get this and the other 9p related patches merged ? >>> Through the trivial tree or each subsystem tree ? >>=20 >> I guess qemu-trivial will eventually pick up whatever hasn't been merged >> by maintainers. >>=20 >> [...] >>=20 > > Yes, but the difficulty will be to sort which ones of the 59 patches > series to collect... Collect them all and let git figure out which ones have been applied already?