From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Mon, 09 Dec 2019 14:03:52 +0000 Subject: Re: [PATCH v3 12/12] auxdisplay: constify fb ops Message-Id: <87pngx4muv.fsf@intel.com> List-Id: References: <31c18e3ce9d6962aabda4799b3051039ff591c92.1575390741.git.jani.nikula@intel.com> In-Reply-To: <31c18e3ce9d6962aabda4799b3051039ff591c92.1575390741.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: Miguel Ojeda Sandonis , intel-gfx@lists.freedesktop.org, Robin van der Gracht , Daniel Vetter On Tue, 03 Dec 2019, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > Cc: Miguel Ojeda Sandonis > Cc: Robin van der Gracht > Reviewed-by: Daniel Vetter > Reviewed-by: Miguel Ojeda > Acked-by: Robin van der Gracht > Signed-off-by: Jani Nikula Miguel, Robin, just to err on the safe side, were you both okay with me merging this through drm-misc? Not very likely to conflict badly. BR, Jani. > --- > drivers/auxdisplay/cfag12864bfb.c | 2 +- > drivers/auxdisplay/ht16k33.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c > index 4074886b7bc8..2002291ab338 100644 > --- a/drivers/auxdisplay/cfag12864bfb.c > +++ b/drivers/auxdisplay/cfag12864bfb.c > @@ -57,7 +57,7 @@ static int cfag12864bfb_mmap(struct fb_info *info, struct vm_area_struct *vma) > return vm_map_pages_zero(vma, &pages, 1); > } > > -static struct fb_ops cfag12864bfb_ops = { > +static const struct fb_ops cfag12864bfb_ops = { > .owner = THIS_MODULE, > .fb_read = fb_sys_read, > .fb_write = fb_sys_write, > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index a2fcde582e2a..d951d54b26f5 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -228,7 +228,7 @@ static int ht16k33_mmap(struct fb_info *info, struct vm_area_struct *vma) > return vm_map_pages_zero(vma, &pages, 1); > } > > -static struct fb_ops ht16k33_fb_ops = { > +static const struct fb_ops ht16k33_fb_ops = { > .owner = THIS_MODULE, > .fb_read = fb_sys_read, > .fb_write = fb_sys_write, -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1315C43603 for ; Mon, 9 Dec 2019 14:04:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DBE22068E for ; Mon, 9 Dec 2019 14:04:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DBE22068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0347D6E451; Mon, 9 Dec 2019 14:04:28 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41A196E451; Mon, 9 Dec 2019 14:04:27 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 06:03:58 -0800 X-IronPort-AV: E=Sophos;i="5.69,294,1571727600"; d="scan'208";a="215101123" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 06:03:55 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 12/12] auxdisplay: constify fb ops In-Reply-To: <31c18e3ce9d6962aabda4799b3051039ff591c92.1575390741.git.jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <31c18e3ce9d6962aabda4799b3051039ff591c92.1575390741.git.jani.nikula@intel.com> Date: Mon, 09 Dec 2019 16:03:52 +0200 Message-ID: <87pngx4muv.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miguel Ojeda Sandonis , intel-gfx@lists.freedesktop.org, Robin van der Gracht , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAwMyBEZWMgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IENj OiBNaWd1ZWwgT2plZGEgU2FuZG9uaXMgPG1pZ3VlbC5vamVkYS5zYW5kb25pc0BnbWFpbC5jb20+ Cj4gQ2M6IFJvYmluIHZhbiBkZXIgR3JhY2h0IDxyb2JpbkBwcm90b25pYy5ubD4KPiBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBSZXZpZXdlZC1i eTogTWlndWVsIE9qZWRhIDxtaWd1ZWwub2plZGEuc2FuZG9uaXNAZ21haWwuY29tPgo+IEFja2Vk LWJ5OiBSb2JpbiB2YW4gZGVyIEdyYWNodCA8cm9iaW5AcHJvdG9uaWMubmw+Cj4gU2lnbmVkLW9m Zi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCk1pZ3VlbCwgUm9iaW4s IGp1c3QgdG8gZXJyIG9uIHRoZSBzYWZlIHNpZGUsIHdlcmUgeW91IGJvdGggb2theSB3aXRoIG1l Cm1lcmdpbmcgdGhpcyB0aHJvdWdoIGRybS1taXNjPyBOb3QgdmVyeSBsaWtlbHkgdG8gY29uZmxp Y3QgYmFkbHkuCgpCUiwKSmFuaS4KCj4gLS0tCj4gIGRyaXZlcnMvYXV4ZGlzcGxheS9jZmFnMTI4 NjRiZmIuYyB8IDIgKy0KPiAgZHJpdmVycy9hdXhkaXNwbGF5L2h0MTZrMzMuYyAgICAgIHwgMiAr LQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMgYi9kcml2ZXJz L2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMKPiBpbmRleCA0MDc0ODg2YjdiYzguLjIwMDIyOTFh YjMzOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMKPiAr KysgYi9kcml2ZXJzL2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMKPiBAQCAtNTcsNyArNTcsNyBA QCBzdGF0aWMgaW50IGNmYWcxMjg2NGJmYl9tbWFwKHN0cnVjdCBmYl9pbmZvICppbmZvLCBzdHJ1 Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgCXJldHVybiB2bV9tYXBfcGFnZXNfemVybyh2bWEs ICZwYWdlcywgMSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgZmJfb3BzIGNmYWcxMjg2NGJm Yl9vcHMgPSB7Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmJfb3BzIGNmYWcxMjg2NGJmYl9vcHMg PSB7Cj4gIAkub3duZXIgPSBUSElTX01PRFVMRSwKPiAgCS5mYl9yZWFkID0gZmJfc3lzX3JlYWQs Cj4gIAkuZmJfd3JpdGUgPSBmYl9zeXNfd3JpdGUsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYXV4 ZGlzcGxheS9odDE2azMzLmMgYi9kcml2ZXJzL2F1eGRpc3BsYXkvaHQxNmszMy5jCj4gaW5kZXgg YTJmY2RlNTgyZTJhLi5kOTUxZDU0YjI2ZjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9hdXhkaXNw bGF5L2h0MTZrMzMuYwo+ICsrKyBiL2RyaXZlcnMvYXV4ZGlzcGxheS9odDE2azMzLmMKPiBAQCAt MjI4LDcgKzIyOCw3IEBAIHN0YXRpYyBpbnQgaHQxNmszM19tbWFwKHN0cnVjdCBmYl9pbmZvICpp bmZvLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgCXJldHVybiB2bV9tYXBfcGFnZXNf emVybyh2bWEsICZwYWdlcywgMSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgZmJfb3BzIGh0 MTZrMzNfZmJfb3BzID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGZiX29wcyBodDE2azMzX2Zi X29wcyA9IHsKPiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAJLmZiX3JlYWQgPSBmYl9zeXNf cmVhZCwKPiAgCS5mYl93cml0ZSA9IGZiX3N5c193cml0ZSwKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70995C04E30 for ; Mon, 9 Dec 2019 14:04:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F1CB2068E for ; Mon, 9 Dec 2019 14:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F1CB2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6B346E456; Mon, 9 Dec 2019 14:04:28 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41A196E451; Mon, 9 Dec 2019 14:04:27 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 06:03:58 -0800 X-IronPort-AV: E=Sophos;i="5.69,294,1571727600"; d="scan'208";a="215101123" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 06:03:55 -0800 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org In-Reply-To: <31c18e3ce9d6962aabda4799b3051039ff591c92.1575390741.git.jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <31c18e3ce9d6962aabda4799b3051039ff591c92.1575390741.git.jani.nikula@intel.com> Date: Mon, 09 Dec 2019 16:03:52 +0200 Message-ID: <87pngx4muv.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v3 12/12] auxdisplay: constify fb ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miguel Ojeda Sandonis , intel-gfx@lists.freedesktop.org, Robin van der Gracht , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVHVlLCAwMyBEZWMgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gTm93IHRoYXQgdGhlIGZib3BzIG1lbWJlciBvZiBzdHJ1Y3QgZmJfaW5mbyBpcyBj b25zdCwgd2UgY2FuIHN0YXJ0Cj4gbWFraW5nIHRoZSBvcHMgY29uc3QgYXMgd2VsbC4KPgo+IENj OiBNaWd1ZWwgT2plZGEgU2FuZG9uaXMgPG1pZ3VlbC5vamVkYS5zYW5kb25pc0BnbWFpbC5jb20+ Cj4gQ2M6IFJvYmluIHZhbiBkZXIgR3JhY2h0IDxyb2JpbkBwcm90b25pYy5ubD4KPiBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBSZXZpZXdlZC1i eTogTWlndWVsIE9qZWRhIDxtaWd1ZWwub2plZGEuc2FuZG9uaXNAZ21haWwuY29tPgo+IEFja2Vk LWJ5OiBSb2JpbiB2YW4gZGVyIEdyYWNodCA8cm9iaW5AcHJvdG9uaWMubmw+Cj4gU2lnbmVkLW9m Zi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCk1pZ3VlbCwgUm9iaW4s IGp1c3QgdG8gZXJyIG9uIHRoZSBzYWZlIHNpZGUsIHdlcmUgeW91IGJvdGggb2theSB3aXRoIG1l Cm1lcmdpbmcgdGhpcyB0aHJvdWdoIGRybS1taXNjPyBOb3QgdmVyeSBsaWtlbHkgdG8gY29uZmxp Y3QgYmFkbHkuCgpCUiwKSmFuaS4KCj4gLS0tCj4gIGRyaXZlcnMvYXV4ZGlzcGxheS9jZmFnMTI4 NjRiZmIuYyB8IDIgKy0KPiAgZHJpdmVycy9hdXhkaXNwbGF5L2h0MTZrMzMuYyAgICAgIHwgMiAr LQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMgYi9kcml2ZXJz L2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMKPiBpbmRleCA0MDc0ODg2YjdiYzguLjIwMDIyOTFh YjMzOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMKPiAr KysgYi9kcml2ZXJzL2F1eGRpc3BsYXkvY2ZhZzEyODY0YmZiLmMKPiBAQCAtNTcsNyArNTcsNyBA QCBzdGF0aWMgaW50IGNmYWcxMjg2NGJmYl9tbWFwKHN0cnVjdCBmYl9pbmZvICppbmZvLCBzdHJ1 Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgCXJldHVybiB2bV9tYXBfcGFnZXNfemVybyh2bWEs ICZwYWdlcywgMSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgZmJfb3BzIGNmYWcxMjg2NGJm Yl9vcHMgPSB7Cj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZmJfb3BzIGNmYWcxMjg2NGJmYl9vcHMg PSB7Cj4gIAkub3duZXIgPSBUSElTX01PRFVMRSwKPiAgCS5mYl9yZWFkID0gZmJfc3lzX3JlYWQs Cj4gIAkuZmJfd3JpdGUgPSBmYl9zeXNfd3JpdGUsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYXV4 ZGlzcGxheS9odDE2azMzLmMgYi9kcml2ZXJzL2F1eGRpc3BsYXkvaHQxNmszMy5jCj4gaW5kZXgg YTJmY2RlNTgyZTJhLi5kOTUxZDU0YjI2ZjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9hdXhkaXNw bGF5L2h0MTZrMzMuYwo+ICsrKyBiL2RyaXZlcnMvYXV4ZGlzcGxheS9odDE2azMzLmMKPiBAQCAt MjI4LDcgKzIyOCw3IEBAIHN0YXRpYyBpbnQgaHQxNmszM19tbWFwKHN0cnVjdCBmYl9pbmZvICpp bmZvLCBzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSkKPiAgCXJldHVybiB2bV9tYXBfcGFnZXNf emVybyh2bWEsICZwYWdlcywgMSk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBzdHJ1Y3QgZmJfb3BzIGh0 MTZrMzNfZmJfb3BzID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGZiX29wcyBodDE2azMzX2Zi X29wcyA9IHsKPiAgCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAJLmZiX3JlYWQgPSBmYl9zeXNf cmVhZCwKPiAgCS5mYl93cml0ZSA9IGZiX3N5c193cml0ZSwKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeA==