From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v7 04/10] drm/i915/dsb: Indexed register
 write function for DSB.
Date: Thu, 19 Sep 2019 19:38:37 +0300
Message-ID: <87pnjwutpu.fsf@intel.com>
References: <20190918075745.17076-1-animesh.manna@intel.com>
 <20190918075745.17076-5-animesh.manna@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 740206F46E
 for <intel-gfx@lists.freedesktop.org>; Thu, 19 Sep 2019 16:38:48 +0000 (UTC)
In-Reply-To: <20190918075745.17076-5-animesh.manna@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Animesh Manna <animesh.manna@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAxOCBTZXAgMjAxOSwgQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5j
b20+IHdyb3RlOgo+IERTQiBjYW4gcHJvZ3JhbSBsYXJnZSBzZXQgb2YgZGF0YSB0aHJvdWdoIGlu
ZGV4ZWQgcmVnaXN0ZXIgd3JpdGUKPiAob3Bjb2RlIDB4OSkgaW4gb25lIHNob3QuIERTQiBmZWF0
dXJlIGNhbiBiZSB1c2VkIGZvciBidWxrIHJlZ2lzdGVyCj4gcHJvZ3JhbW1pbmcgZS5nLiBnYW1t
YSBsdXQgcHJvZ3JhbW1pbmcsIEhEUiBtZXRhIGRhdGEgcHJvZ3JhbW1pbmcuCj4KPiB2MTogaW5p
dGlhbCB2ZXJzaW9uLgo+IHYyOiBzaW1wbGlmaWVkIGNvZGUgYnkgdXNpbmcgQUxJR04oKS4gKENo
cmlzKQo+IHYzOiBhc2NpaSB0YWJsZSBhZGRlZCBhcyBjb2RlIGNvbW1lbnQuIChTaGFzaGFuaykK
PiB2NDogY29zbWV0aWMgY2hhbmdlcyBkb25lLiAoU2hhc2hhbmspCj4KPiBDYzogU2hhc2hhbmsg
U2hhcm1hIDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+IENjOiBJbXJlIERlYWsgPGltcmUu
ZGVha0BpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+
Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBSZXZpZXdlZC1i
eTogU2hhc2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+IFNpZ25lZC1v
ZmYtYnk6IEFuaW1lc2ggTWFubmEgPGFuaW1lc2gubWFubmFAaW50ZWwuY29tPgo+IC0tLQo+ICBk
cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jIHwgNjYgKysrKysrKysrKysr
KysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmgg
fCAgOCArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMKPiBpbmRleCBmOTRjZDZkYzk4YjYuLjJk
ODBlNDUyZTI4NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu
dGVsX2RzYi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2Iu
Ywo+IEBAIC0xMiw4ICsxMiwxMCBAQAo+ICAvKiBEU0Igb3Bjb2Rlcy4gKi8KPiAgI2RlZmluZSBE
U0JfT1BDT0RFX1NISUZUCQkyNAo+ICAjZGVmaW5lIERTQl9PUENPREVfTU1JT19XUklURQkJMHgx
Cj4gKyNkZWZpbmUgRFNCX09QQ09ERV9JTkRFWEVEX1dSSVRFCTB4OQo+ICAjZGVmaW5lIERTQl9C
WVRFX0VOCQkJMHhGCj4gICNkZWZpbmUgRFNCX0JZVEVfRU5fU0hJRlQJCTIwCj4gKyNkZWZpbmUg
RFNCX1JFR19WQUxVRV9NQVNLCQkweGZmZmZmCj4gIAo+ICBzdHJ1Y3QgaW50ZWxfZHNiICoKPiAg
aW50ZWxfZHNiX2dldChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiBAQCAtODYsNiArODgsNzAg
QEAgdm9pZCBpbnRlbF9kc2JfcHV0KHN0cnVjdCBpbnRlbF9kc2IgKmRzYikKPiAgCX0KPiAgfQo+
ICAKPiArdm9pZCBpbnRlbF9kc2JfaW5kZXhlZF9yZWdfd3JpdGUoc3RydWN0IGludGVsX2RzYiAq
ZHNiLCBpOTE1X3JlZ190IHJlZywKPiArCQkJCSB1MzIgdmFsKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50
ZWxfY3J0YyAqY3J0YyA9IGNvbnRhaW5lcl9vZihkc2IsIHR5cGVvZigqY3J0YyksIGRzYik7Cj4g
KwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJhc2Uu
ZGV2KTsKPiArCXUzMiAqYnVmID0gZHNiLT5jbWRfYnVmOwo+ICsJdTMyIHJlZ192YWw7Cj4gKwo+
ICsJaWYgKCFidWYpIHsKPiArCQlJOTE1X1dSSVRFKHJlZywgdmFsKTsKPiArCQlyZXR1cm47Cj4g
Kwl9Cj4gKwo+ICsJaWYgKFdBUk5fT04oZHNiLT5mcmVlX3BvcyA+PSBEU0JfQlVGX1NJWkUpKSB7
Cj4gKwkJRFJNX0RFQlVHX0tNUygiRFNCIGJ1ZmZlciBvdmVyZmxvd1xuIik7Cj4gKwkJcmV0dXJu
Owo+ICsJfQo+ICsKPiArCS8qCj4gKwkgKiBGb3IgZXhhbXBsZSB0aGUgYnVmZmVyIHdpbGwgbG9v
ayBsaWtlIGJlbG93IGZvciAzIGR3b3JkcyBmb3IgYXV0bwo+ICsJICogaW5jcmVtZW50IHJlZ2lz
dGVyOgo+ICsJICogKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tKwo+ICsJICogfCBzaXplID0gMyB8IG9mZnNldCAmfCB2YWx1ZTEgfCB2YWx1
ZTIgfCB2YWx1ZTMgfCB6ZXJvICAgfAo+ICsJICogfCAgICAgICAgICB8IG9wY29kZSAgfCAgICAg
ICAgfCAgICAgICAgfCAgICAgICAgfCAgICAgICAgfAo+ICsJICogKy0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKwo+ICsJICogKyAgICAgICAg
ICArICAgICAgICAgKyAgICAgICAgKyAgICAgICAgKyAgICAgICAgKyAgICAgICAgKwo+ICsJICog
MCAgICAgICAgICA0ICAgICAgICAgOCAgICAgICAgMTIgICAgICAgMTYgICAgICAgMjAgICAgICAg
MjQKPiArCSAqIEJ5dGUKPiArCSAqCj4gKwkgKiBBcyBldmVyeSBpbnN0cnVjdGlvbiBpcyA4IGJ5
dGUgYWxpZ25lZCB0aGUgaW5kZXggb2YgZHNiIGluc3RydWN0aW9uCj4gKwkgKiB3aWxsIHN0YXJ0
IGFsd2F5cyBmcm9tIGV2ZW4gbnVtYmVyIHdoaWxlIGRlYWxpbmcgd2l0aCB1MzIgYXJyYXkuIElm
Cj4gKwkgKiB3ZSBhcmUgd3JpdGluZyBvZGQgbm8gb2YgZHdvcmRzLCBaZXJvcyB3aWxsIGJlIGFk
ZGVkIGluIHRoZSBlbmQgZm9yCj4gKwkgKiBwYWRkaW5nLgo+ICsJICovCj4gKwlyZWdfdmFsID0g
YnVmW2RzYi0+aW5zX3N0YXJ0X29mZnNldCArIDFdICYgRFNCX1JFR19WQUxVRV9NQVNLOwoKZHNi
LT5pbnNfc3RhcnRfb2Zmc2V0IGlzIG5ldmVyIHJlc2V0IGFueXdoZXJlLgoKSW1hZ2luZSB5b3Ug
ZG86CgppbnRlbF9kc2JfaW5kZXhlZF9yZWdfd3JpdGUoZHNiLCBGT08sIDApOwppbnRlbF9kc2Jf
aW5kZXhlZF9yZWdfd3JpdGUoZHNiLCBGT08sIDApOwppbnRlbF9kc2JfcmVnX3dyaXRlKGRzYiwg
QkFSLCAwKTsKaW50ZWxfZHNiX2luZGV4ZWRfcmVnX3dyaXRlKGRzYiwgRk9PLCAwKTsKClRoZSBs
YXN0IG9uZSB3aWxsIHNjcmV3IHVwIHRoZSBwcmV2aW91cyBpbmRleGVkIHdyaXRlcy4KCkJSLApK
YW5pLgoKCj4gKwlpZiAocmVnX3ZhbCAhPSBpOTE1X21taW9fcmVnX29mZnNldChyZWcpKSB7Cj4g
KwkJLyogRXZlcnkgaW5zdHJ1Y3Rpb24gc2hvdWxkIGJlIDggYnl0ZSBhbGlnbmVkLiAqLwo+ICsJ
CWRzYi0+ZnJlZV9wb3MgPSBBTElHTihkc2ItPmZyZWVfcG9zLCAyKTsKPiArCj4gKwkJZHNiLT5p
bnNfc3RhcnRfb2Zmc2V0ID0gZHNiLT5mcmVlX3BvczsKPiArCj4gKwkJLyogVXBkYXRlIHRoZSBz
aXplLiAqLwo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gMTsKPiArCj4gKwkJLyogVXBkYXRl
IHRoZSBvcGNvZGUgYW5kIHJlZy4gKi8KPiArCQlidWZbZHNiLT5mcmVlX3BvcysrXSA9IChEU0Jf
T1BDT0RFX0lOREVYRURfV1JJVEUgIDw8Cj4gKwkJCQkJRFNCX09QQ09ERV9TSElGVCkgfAo+ICsJ
CQkJCWk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZyk7Cj4gKwo+ICsJCS8qIFVwZGF0ZSB0aGUgdmFs
dWUuICovCj4gKwkJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSB2YWw7Cj4gKwl9IGVsc2Ugewo+ICsJ
CS8qIFVwZGF0ZSB0aGUgbmV3IHZhbHVlLiAqLwo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0g
dmFsOwo+ICsKPiArCQkvKiBVcGRhdGUgdGhlIHNpemUuICovCj4gKwkJYnVmW2RzYi0+aW5zX3N0
YXJ0X29mZnNldF0rKzsKPiArCX0KPiArCj4gKwkvKiBpZiBudW1iZXIgb2YgZGF0YSB3b3JkcyBp
cyBvZGQsIHRoZW4gdGhlIGxhc3QgZHdvcmQgc2hvdWxkIGJlIDAuKi8KPiArCWlmIChkc2ItPmZy
ZWVfcG9zICYgMHgxKQo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zXSA9IDA7Cj4gK30KPiArCj4gIHZv
aWQgaW50ZWxfZHNiX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3Qg
cmVnLCB1MzIgdmFsKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IGNvbnRhaW5l
cl9vZihkc2IsIHR5cGVvZigqY3J0YyksIGRzYik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw
bGF5L2ludGVsX2RzYi5oCj4gaW5kZXggMDY4NmQ2N2IzNGQ1Li5kNmNlZDQ0MjI4MTQgMTAwNjQ0
Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuaAo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmgKPiBAQCAtMzAsMTEgKzMw
LDE5IEBAIHN0cnVjdCBpbnRlbF9kc2Igewo+ICAJICogYW5kIGhlbHAgaW4gY2FsY3VsYXRpbmcg
dGFpbCBvZiBjb21tYW5kIGJ1ZmZlci4KPiAgCSAqLwo+ICAJaW50IGZyZWVfcG9zOwo+ICsKPiAr
CS8qCj4gKwkgKiBpbnNfc3RhcnRfb2Zmc2V0IHdpbGwgaGVscCB0byBzdG9yZSBzdGFydCBhZGRy
ZXNzCj4gKwkgKiBvZiB0aGUgZHNiIGluc3R1Y3Rpb24gb2YgYXV0by1pbmNyZW1lbnQgcmVnaXN0
ZXIuCj4gKwkgKi8KPiArCXUzMiBpbnNfc3RhcnRfb2Zmc2V0Owo+ICB9Owo+ICAKPiAgc3RydWN0
IGludGVsX2RzYiAqCj4gIGludGVsX2RzYl9nZXQoc3RydWN0IGludGVsX2NydGMgKmNydGMpOwo+
ICB2b2lkIGludGVsX2RzYl9wdXQoc3RydWN0IGludGVsX2RzYiAqZHNiKTsKPiAgdm9pZCBpbnRl
bF9kc2JfcmVnX3dyaXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9yZWdfdCByZWcsIHUz
MiB2YWwpOwo+ICt2b2lkIGludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxf
ZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLAo+ICsJCQkJIHUzMiB2YWwpOwo+ICAKPiAgI2VuZGlm
CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=