From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D15C10F03 for ; Thu, 25 Apr 2019 12:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C379020644 for ; Thu, 25 Apr 2019 12:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729670AbfDYMka (ORCPT ); Thu, 25 Apr 2019 08:40:30 -0400 Received: from mga02.intel.com ([134.134.136.20]:20751 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfDYMka (ORCPT ); Thu, 25 Apr 2019 08:40:30 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 05:40:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,393,1549958400"; d="asc'?scan'208";a="138735172" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2019 05:40:22 -0700 From: Felipe Balbi To: Douglas Anderson , Minas Harutyunyan , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , Mark Rutland Subject: Re: [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB In-Reply-To: <20190418001356.124334-4-dianders@chromium.org> References: <20190418001356.124334-1-dianders@chromium.org> <20190418001356.124334-4-dianders@chromium.org> Date: Thu, 25 Apr 2019 15:40:18 +0300 Message-ID: <87pnpas1fx.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Douglas Anderson writes: > Some SoCs with a dwc2 USB controller may need to keep the PHY on to > support remote wakeup. Allow specifying this as a device tree > property. > > Signed-off-by: Douglas Anderson > --- > For relevant prior discussion on this patch, see: > > https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chrom= ium.org > > I didn't make any changes from the prior version since I never found > out what Rob thought of my previous arguments. If folks want a > change, perhaps they could choose from these options: > > 1. Assume that all dwc2 hosts would like to keep their PHY on for > suspend if there's a USB wakeup enabled, thus we totally drop this > binding. This doesn't seem super great to me since I'd bet that > many devices that use dwc2 weren't designed for USB wakeup (they > may not keep enough clocks or rails on) so we might be wasting > power for nothing. > 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make > it more obvious that this property is intended both to document > that wakeup from suspend is possible and that we need the PHY for > said wakeup. > 3. Rename this property to "snps,can-wakeup-from-suspend" and assume > it's implicit that if we can wakeup from suspend that we need to > keep the PHY on. If/when someone shows that a device exists using > dwc2 where we can wakeup from suspend without the PHY they can add > a new property. > > Changes in v2: None > > Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ > 1 file changed, 3 insertions(+) checking file Documentation/devicetree/bindings/usb/dwc2.txt Hunk #1 FAILED at 37. Hunk #2 succeeded at 52 (offset -1 lines). 1 out of 2 hunks FAILED =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlzBqrIACgkQzL64meEa mQYE0w//cCr/Wc2ZD2abiUr+FHaO2iz3BvODX3EHdzur4BMpo/KZK9JnKw4m4RUa L0qSu3RYrcbBW0h/zU+cy41VXKz+WBMJVgpl3TWUJ4AiTLrfQHzDNLvEXssyukkd t3xocK2DAbDh6IMBriCDFsogXcLAuEQmPiuXZmj7fEtdFqymdCuFDijqT7GNCHNq toCH4ajwUlvtjWbutwAUEl+o4Hq91nQqyZfKRhHu6Q43fLXyqQzHdDFKn041J7+f 5bxgb3TGihobUYBNX2cGRgJBXl36fn1E+PlhFIBk7e8/09ZmF+oQaP6eU1n+jbkC S2BSNRO2+Cvnnylp7XTrj88QUyNv+hqiSC3lkmWoyE7IbP7LphW0K0J8h0t70P0t yg+7/HG1m/AhJxSSrBqUXtHdgJeCBoLjOZgRzdNccDS4vzJVId8hsZX17und9Xmg UCuHgLwrF+69vqD4HgVBWhFlh/BawSwgxOmih/VskGPoVIObtyxCqKqflPoEiAYT DtF0S6fWKk0Ko+BfCaPTg548QecBuu3uo4DO0XOu3GaYAraV9Sn2VkoJYXTDF+ny lv5+dRw+cY3c7UVgg41kd7Tq1Hbhuuv/IFmIg1yR1qY0gSGuLOjEYKjooa4cIblB AE63sGvm4y81n9AChloTq4x3NabubgLpcr8GCFuSUiDz+zwHiiY= =tY5t -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v2 3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB Date: Thu, 25 Apr 2019 15:40:18 +0300 Message-ID: <87pnpas1fx.fsf@linux.intel.com> References: <20190418001356.124334-1-dianders@chromium.org> <20190418001356.124334-4-dianders@chromium.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190418001356.124334-4-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Minas Harutyunyan , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , Mark Rutland List-Id: devicetree@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Douglas Anderson writes: > Some SoCs with a dwc2 USB controller may need to keep the PHY on to > support remote wakeup. Allow specifying this as a device tree > property. > > Signed-off-by: Douglas Anderson > --- > For relevant prior discussion on this patch, see: > > https://lkml.kernel.org/r/1435017144-2971-3-git-send-email-dianders@chrom= ium.org > > I didn't make any changes from the prior version since I never found > out what Rob thought of my previous arguments. If folks want a > change, perhaps they could choose from these options: > > 1. Assume that all dwc2 hosts would like to keep their PHY on for > suspend if there's a USB wakeup enabled, thus we totally drop this > binding. This doesn't seem super great to me since I'd bet that > many devices that use dwc2 weren't designed for USB wakeup (they > may not keep enough clocks or rails on) so we might be wasting > power for nothing. > 2. Rename this property to "snps,wakeup-from-suspend-with-phy" to make > it more obvious that this property is intended both to document > that wakeup from suspend is possible and that we need the PHY for > said wakeup. > 3. Rename this property to "snps,can-wakeup-from-suspend" and assume > it's implicit that if we can wakeup from suspend that we need to > keep the PHY on. If/when someone shows that a device exists using > dwc2 where we can wakeup from suspend without the PHY they can add > a new property. > > Changes in v2: None > > Documentation/devicetree/bindings/usb/dwc2.txt | 3 +++ > 1 file changed, 3 insertions(+) checking file Documentation/devicetree/bindings/usb/dwc2.txt Hunk #1 FAILED at 37. Hunk #2 succeeded at 52 (offset -1 lines). 1 out of 2 hunks FAILED =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlzBqrIACgkQzL64meEa mQYE0w//cCr/Wc2ZD2abiUr+FHaO2iz3BvODX3EHdzur4BMpo/KZK9JnKw4m4RUa L0qSu3RYrcbBW0h/zU+cy41VXKz+WBMJVgpl3TWUJ4AiTLrfQHzDNLvEXssyukkd t3xocK2DAbDh6IMBriCDFsogXcLAuEQmPiuXZmj7fEtdFqymdCuFDijqT7GNCHNq toCH4ajwUlvtjWbutwAUEl+o4Hq91nQqyZfKRhHu6Q43fLXyqQzHdDFKn041J7+f 5bxgb3TGihobUYBNX2cGRgJBXl36fn1E+PlhFIBk7e8/09ZmF+oQaP6eU1n+jbkC S2BSNRO2+Cvnnylp7XTrj88QUyNv+hqiSC3lkmWoyE7IbP7LphW0K0J8h0t70P0t yg+7/HG1m/AhJxSSrBqUXtHdgJeCBoLjOZgRzdNccDS4vzJVId8hsZX17und9Xmg UCuHgLwrF+69vqD4HgVBWhFlh/BawSwgxOmih/VskGPoVIObtyxCqKqflPoEiAYT DtF0S6fWKk0Ko+BfCaPTg548QecBuu3uo4DO0XOu3GaYAraV9Sn2VkoJYXTDF+ny lv5+dRw+cY3c7UVgg41kd7Tq1Hbhuuv/IFmIg1yR1qY0gSGuLOjEYKjooa4cIblB AE63sGvm4y81n9AChloTq4x3NabubgLpcr8GCFuSUiDz+zwHiiY= =tY5t -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,3/5] Documentation: dt-bindings: Add snps,need-phy-for-wake for dwc2 USB From: Felipe Balbi Message-Id: <87pnpas1fx.fsf@linux.intel.com> Date: Thu, 25 Apr 2019 15:40:18 +0300 To: Douglas Anderson , Minas Harutyunyan , heiko@sntech.de Cc: Alan Stern , Artur Petrosyan , amstan@chromium.org, linux-rockchip@lists.infradead.org, William Wu , linux-usb@vger.kernel.org, Stefan Wahren , Randy Li , zyw@rock-chips.com, mka@chromium.org, ryandcase@chromium.org, Amelie Delaunay , jwerner@chromium.org, dinguyen@opensource.altera.com, Elaine Zhang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , Mark Rutland List-ID: RG91Z2xhcyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPiB3cml0ZXM6Cgo+IFNvbWUg U29DcyB3aXRoIGEgZHdjMiBVU0IgY29udHJvbGxlciBtYXkgbmVlZCB0byBrZWVwIHRoZSBQSFkg b24gdG8KPiBzdXBwb3J0IHJlbW90ZSB3YWtldXAuICBBbGxvdyBzcGVjaWZ5aW5nIHRoaXMgYXMg YSBkZXZpY2UgdHJlZQo+IHByb3BlcnR5Lgo+Cj4gU2lnbmVkLW9mZi1ieTogRG91Z2xhcyBBbmRl cnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgo+IC0tLQo+IEZvciByZWxldmFudCBwcmlvciBk aXNjdXNzaW9uIG9uIHRoaXMgcGF0Y2gsIHNlZToKPgo+IGh0dHBzOi8vbGttbC5rZXJuZWwub3Jn L3IvMTQzNTAxNzE0NC0yOTcxLTMtZ2l0LXNlbmQtZW1haWwtZGlhbmRlcnNAY2hyb21pdW0ub3Jn Cj4KPiBJIGRpZG4ndCBtYWtlIGFueSBjaGFuZ2VzIGZyb20gdGhlIHByaW9yIHZlcnNpb24gc2lu Y2UgSSBuZXZlciBmb3VuZAo+IG91dCB3aGF0IFJvYiB0aG91Z2h0IG9mIG15IHByZXZpb3VzIGFy Z3VtZW50cy4gIElmIGZvbGtzIHdhbnQgYQo+IGNoYW5nZSwgcGVyaGFwcyB0aGV5IGNvdWxkIGNo b29zZSBmcm9tIHRoZXNlIG9wdGlvbnM6Cj4KPiAxLiBBc3N1bWUgdGhhdCBhbGwgZHdjMiBob3N0 cyB3b3VsZCBsaWtlIHRvIGtlZXAgdGhlaXIgUEhZIG9uIGZvcgo+ICAgIHN1c3BlbmQgaWYgdGhl cmUncyBhIFVTQiB3YWtldXAgZW5hYmxlZCwgdGh1cyB3ZSB0b3RhbGx5IGRyb3AgdGhpcwo+ICAg IGJpbmRpbmcuICBUaGlzIGRvZXNuJ3Qgc2VlbSBzdXBlciBncmVhdCB0byBtZSBzaW5jZSBJJ2Qg YmV0IHRoYXQKPiAgICBtYW55IGRldmljZXMgdGhhdCB1c2UgZHdjMiB3ZXJlbid0IGRlc2lnbmVk IGZvciBVU0Igd2FrZXVwICh0aGV5Cj4gICAgbWF5IG5vdCBrZWVwIGVub3VnaCBjbG9ja3Mgb3Ig cmFpbHMgb24pIHNvIHdlIG1pZ2h0IGJlIHdhc3RpbmcKPiAgICBwb3dlciBmb3Igbm90aGluZy4K PiAyLiBSZW5hbWUgdGhpcyBwcm9wZXJ0eSB0byAic25wcyx3YWtldXAtZnJvbS1zdXNwZW5kLXdp dGgtcGh5IiB0byBtYWtlCj4gICAgaXQgbW9yZSBvYnZpb3VzIHRoYXQgdGhpcyBwcm9wZXJ0eSBp cyBpbnRlbmRlZCBib3RoIHRvIGRvY3VtZW50Cj4gICAgdGhhdCB3YWtldXAgZnJvbSBzdXNwZW5k IGlzIHBvc3NpYmxlIGFuZCB0aGF0IHdlIG5lZWQgdGhlIFBIWSBmb3IKPiAgICBzYWlkIHdha2V1 cC4KPiAzLiBSZW5hbWUgdGhpcyBwcm9wZXJ0eSB0byAic25wcyxjYW4td2FrZXVwLWZyb20tc3Vz cGVuZCIgYW5kIGFzc3VtZQo+ICAgIGl0J3MgaW1wbGljaXQgdGhhdCBpZiB3ZSBjYW4gd2FrZXVw IGZyb20gc3VzcGVuZCB0aGF0IHdlIG5lZWQgdG8KPiAgICBrZWVwIHRoZSBQSFkgb24uICBJZi93 aGVuIHNvbWVvbmUgc2hvd3MgdGhhdCBhIGRldmljZSBleGlzdHMgdXNpbmcKPiAgICBkd2MyIHdo ZXJlIHdlIGNhbiB3YWtldXAgZnJvbSBzdXNwZW5kIHdpdGhvdXQgdGhlIFBIWSB0aGV5IGNhbiBh ZGQKPiAgICBhIG5ldyBwcm9wZXJ0eS4KPgo+IENoYW5nZXMgaW4gdjI6IE5vbmUKPgo+ICBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2R3YzIudHh0IHwgMyArKysKPiAgMSBm aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKY2hlY2tpbmcgZmlsZSBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2R3YzIudHh0Ckh1bmsgIzEgRkFJTEVEIGF0IDM3LgpI dW5rICMyIHN1Y2NlZWRlZCBhdCA1MiAob2Zmc2V0IC0xIGxpbmVzKS4KMSBvdXQgb2YgMiBodW5r cyBGQUlMRUQK