All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj
Date: Wed, 02 May 2018 16:14:01 +0200	[thread overview]
Message-ID: <87po2eywk6.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <80ad8147-903b-7a14-9f47-0a4bd435b6f7@redhat.com> (Eric Blake's message of "Wed, 2 May 2018 08:28:46 -0500")

Eric Blake <eblake@redhat.com> writes:

> On 04/27/2018 06:42 AM, Markus Armbruster wrote:
>
>>>> +++ b/include/qapi/qmp/qobject.h
>>>> @@ -72,11 +72,12 @@ static inline void qobject_init(QObject *obj, QType type)
>>>>       obj->base.type = type;
>>>>   }
>>>>   -static inline void qobject_ref_impl(QObject *obj)
>>>> +static inline void *qobject_ref_impl(QObject *obj)
>>>>   {
>>>>       if (obj) {
>>>>           obj->base.refcnt++;
>>>>       }
>>>> +    return obj;
>>>
>>> This hunk is now useless,
>>>
>
>>>> -#define qobject_ref(obj) qobject_ref_impl(QOBJECT(obj))
>>>> +#define qobject_ref(obj) ({                     \
>>>> +    typeof(obj) _o = (obj);                     \
>>>> +    qobject_ref_impl(QOBJECT(_o));              \
>>>> +    _o;                                         \
>>>
>>> since nothing ever uses the return value.
>>>
>>> But that said, I'm still okay with R-b with or without the useless hunk.
>>
>> I intend to drop it on commit.
>
> It's still there on your qapi-next tree; did you forget to remove it?

Thanks for reminding me.  It's gone now.

  reply	other threads:[~2018-05-02 14:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 15:01 [Qemu-devel] [PATCH v6 0/5] Simplify qobject refcount Marc-André Lureau
2018-04-19 15:01 ` [Qemu-devel] [PATCH v6 1/5] qobject: ensure base is at offset 0 Marc-André Lureau
2018-04-19 15:20   ` Eric Blake
2018-04-19 15:23     ` Marc-André Lureau
2018-04-24 12:18       ` Markus Armbruster
2018-04-24 12:34         ` Peter Maydell
2018-04-24 15:24           ` Markus Armbruster
2018-04-26 14:50         ` Markus Armbruster
2018-04-27  8:14   ` Markus Armbruster
2018-04-19 15:01 ` [Qemu-devel] [PATCH v6 2/5] qobject: use a QObjectBase_ struct Marc-André Lureau
2018-04-27  8:24   ` Markus Armbruster
2018-04-27 15:29     ` Eric Blake
2018-04-19 15:01 ` [Qemu-devel] [PATCH v6 3/5] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF Marc-André Lureau
2018-04-19 15:27   ` Eric Blake
2018-04-27  8:59     ` Markus Armbruster
2018-04-19 15:01 ` [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj Marc-André Lureau
2018-04-19 15:32   ` Eric Blake
2018-04-27 11:42     ` Markus Armbruster
2018-05-02 13:28       ` Eric Blake
2018-05-02 14:14         ` Markus Armbruster [this message]
2018-04-27  8:50   ` Markus Armbruster
2018-04-19 15:01 ` [Qemu-devel] [PATCH v6 5/5] qobject: modify qobject_ref() to assert on NULL Marc-André Lureau
2018-04-19 15:39   ` Eric Blake
2018-04-19 16:04     ` Marc-André Lureau
2018-04-19 15:45 ` [Qemu-devel] [PATCH v6 0/5] Simplify qobject refcount Eric Blake
2018-04-19 16:02   ` Marc-André Lureau
2018-05-02  8:31 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po2eywk6.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.