From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbdKFAWi (ORCPT ); Sun, 5 Nov 2017 19:22:38 -0500 Received: from ozlabs.org ([103.22.144.67]:44813 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbdKFAWh (ORCPT ); Sun, 5 Nov 2017 19:22:37 -0500 From: Michael Ellerman To: Shuah Khan , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] selftests: lib.mk: print individual test results to console by default In-Reply-To: References: <20171031000118.30982-1-shuahkh@osg.samsung.com> <87fu9w6qd8.fsf@concordia.ellerman.id.au> Date: Mon, 06 Nov 2017 11:22:35 +1100 Message-ID: <87po8wb6ic.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shuah Khan writes: > On 11/02/2017 08:35 PM, Michael Ellerman wrote: >> Shuah Khan writes: >> >>> Change run_tests to print individual test results to console by default. >>> Introduce "summary" option to print individual test results to a file >>> /tmp/test_name and just print the summary to the console. >>> >>> This change is necessary to support use-cases where test machines get >>> rebooted once tests are run and the console log should contain the full >>> results. >>> >>> In the following example, individual test results with "summary=1" option >>> are written to /tmp/kcmp_test >>> >>> make --silent TARGETS=kcmp kselftest >>> >>> TAP version 13 >>> selftests: kcmp_test >>> ======================================== >>> pid1: 30126 pid2: 30127 FD: 2 FILES: 2 VM: 1 FS: 2 SIGHAND: 2 IO: >>> 0 SYSVSEM: 0 INV: -1 >>> PASS: 0 returned as expected >>> PASS: 0 returned as expected >>> FAIL: 0 expected but -1 returned (Invalid argument) >>> Pass 2 Fail 1 Xfail 0 Xpass 0 Skip 0 Error 0 >>> 1..3 >>> Bail out! >>> Pass 2 Fail 1 Xfail 0 Xpass 0 Skip 0 Error 0 >>> 1..3 >>> Pass 0 Fail 0 Xfail 0 Xpass 0 Skip 0 Error 0 >>> 1..0 >>> ok 1..1 selftests: kcmp_test [PASS] >>> >>> make --silent TARGETS=kcmp summary=1 kselftest >>> TAP version 13 >>> selftests: kcmp_test >>> ======================================== >>> ok 1..1 selftests: kcmp_test [PASS] >>> >>> Signed-off-by: Shuah Khan >>> --- >>> tools/testing/selftests/lib.mk | 6 +++++- >>> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> This looks good to me as a minimal fix, thanks. >> >> Acked-by: Michael Ellerman > > Thanks Michael, bummer I can't add your Ack, I sent pull request > to Linus yesterday so this fix makes it into the release. No worries about the ack. Thanks for getting it merged. cheers