From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdCRArH (ORCPT ); Fri, 17 Mar 2017 20:47:07 -0400 Received: from anholt.net ([50.246.234.109]:42210 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbdCRArG (ORCPT ); Fri, 17 Mar 2017 20:47:06 -0400 From: Eric Anholt To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm/pl111: Initial drm/kms driver for pl111 In-Reply-To: <20170317230949.GK21222@n2100.armlinux.org.uk> References: <20170317224742.17219-1-eric@anholt.net> <20170317224742.17219-3-eric@anholt.net> <20170317230949.GK21222@n2100.armlinux.org.uk> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 17 Mar 2017 17:45:34 -0700 Message-ID: <87pohfv2dt.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Russell King - ARM Linux writes: > On Fri, Mar 17, 2017 at 03:47:42PM -0700, Eric Anholt wrote: >> This is a modesetting driver for the pl111 CLCD display controller >> found on various ARM platforms such as the Versatile Express. The >> driver has only been tested on the bcm911360_entphn platform so far, >> with PRIME-based buffer sharing between vc4 and clcd. >>=20 >> It reuses the existing devicetree binding, while not using quite as >> many of its properties as the fbdev driver does (those are left for >> future work). > > As we're multiplatform on ARM, and this is using the PL11x AMBA IDs, > we must ensure that it's compatible with everything that the fbdev > driver is compatible with... however, I suspect that's not worth the > effort (unless Linus W wants it?) > > If we make it PL111 specific, then we don't need to handle Integrator > CP, or the Versatile PB/AB weirdness. The only thing left is the > power etc enable bits on Realview which uses the PL111. See the > code for Realview in drivers/video/fbdev/amba-clcd-versatile.c. Restricting to PL111 for now sounds good to me. Those Realview bits look like they're turning on a power domain -- shouldn't we represent those as a regulator or a power domain? If we did, then plugging that into a panel driver sounds straightforward. (that's assuming that they're powering panel. not the controller -- I can't quite tell from the code I've browsed so far) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljMgy4ACgkQtdYpNtH8 nujFaQ//fCmNLrCkIBzqi4A73/aEL5FPj5xlMA6lsl4TUBojCNgtFulM/z7AWwEO EEvx1c4mKLOXJPv4svPH7H7rS8vbXL8hcFUyf60ObjgAxuv2fD8QxrF/F0mpXPIq PkdpXnAg6JcIP76f8Yj5iQIgP/FAU5seXYU7IiedG0qM2w6PJaz1fpY+44scj9Ky 2zsGc2CFwo+IRaqge1B8UXRDCmcrgHuhimKA5m2tYT07Xdr9qboSmMEsBn77P7ou P+j/y+dQbaHmnMyEnEgwZFMYTOvWxZKX/ACD201izlBnHTQQRwgTmv1/n/UOv2x+ RLR9VgFQDjoUc1MbHMkUR81J1Gztid5aT9FouIpLrkY0LJCq3/ZYZomi9Eld8rz5 jmMhbzVpfVKJytiy8X9ft0tOkVVoPJ5KxlWUPP4CzQnz1s5RKTKADc6/m0itLreu SlOlMgyw4u0qaEtMcWY4LVh0P9tLkdU5mP/bgvYgG0EXqmNBHWkSS1TJY8sc8Xm6 ICDrsq+4Fxuw6LUn5qjz+A+clY48tYE4dFFeCxB26amgxjroDa4nqKKphadeSj9C Ohy+fRiEn+KVeZHeCgU/6qe9ThE84ZdyWKYzWeUmnu7JlFM8zEald6htYsBQFXIh 7k0geyv+B4QMzLWlXtEqomUYGE2ReGHE/pySV6jLzGhiDkg8N34= =zNBn -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 2/2] drm/pl111: Initial drm/kms driver for pl111 Date: Fri, 17 Mar 2017 17:45:34 -0700 Message-ID: <87pohfv2dt.fsf@eliezer.anholt.net> References: <20170317224742.17219-1-eric@anholt.net> <20170317224742.17219-3-eric@anholt.net> <20170317230949.GK21222@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0733776248==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 912926E217 for ; Sat, 18 Mar 2017 00:45:41 +0000 (UTC) In-Reply-To: <20170317230949.GK21222@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0733776248== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Russell King - ARM Linux writes: > On Fri, Mar 17, 2017 at 03:47:42PM -0700, Eric Anholt wrote: >> This is a modesetting driver for the pl111 CLCD display controller >> found on various ARM platforms such as the Versatile Express. The >> driver has only been tested on the bcm911360_entphn platform so far, >> with PRIME-based buffer sharing between vc4 and clcd. >>=20 >> It reuses the existing devicetree binding, while not using quite as >> many of its properties as the fbdev driver does (those are left for >> future work). > > As we're multiplatform on ARM, and this is using the PL11x AMBA IDs, > we must ensure that it's compatible with everything that the fbdev > driver is compatible with... however, I suspect that's not worth the > effort (unless Linus W wants it?) > > If we make it PL111 specific, then we don't need to handle Integrator > CP, or the Versatile PB/AB weirdness. The only thing left is the > power etc enable bits on Realview which uses the PL111. See the > code for Realview in drivers/video/fbdev/amba-clcd-versatile.c. Restricting to PL111 for now sounds good to me. Those Realview bits look like they're turning on a power domain -- shouldn't we represent those as a regulator or a power domain? If we did, then plugging that into a panel driver sounds straightforward. (that's assuming that they're powering panel. not the controller -- I can't quite tell from the code I've browsed so far) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljMgy4ACgkQtdYpNtH8 nujFaQ//fCmNLrCkIBzqi4A73/aEL5FPj5xlMA6lsl4TUBojCNgtFulM/z7AWwEO EEvx1c4mKLOXJPv4svPH7H7rS8vbXL8hcFUyf60ObjgAxuv2fD8QxrF/F0mpXPIq PkdpXnAg6JcIP76f8Yj5iQIgP/FAU5seXYU7IiedG0qM2w6PJaz1fpY+44scj9Ky 2zsGc2CFwo+IRaqge1B8UXRDCmcrgHuhimKA5m2tYT07Xdr9qboSmMEsBn77P7ou P+j/y+dQbaHmnMyEnEgwZFMYTOvWxZKX/ACD201izlBnHTQQRwgTmv1/n/UOv2x+ RLR9VgFQDjoUc1MbHMkUR81J1Gztid5aT9FouIpLrkY0LJCq3/ZYZomi9Eld8rz5 jmMhbzVpfVKJytiy8X9ft0tOkVVoPJ5KxlWUPP4CzQnz1s5RKTKADc6/m0itLreu SlOlMgyw4u0qaEtMcWY4LVh0P9tLkdU5mP/bgvYgG0EXqmNBHWkSS1TJY8sc8Xm6 ICDrsq+4Fxuw6LUn5qjz+A+clY48tYE4dFFeCxB26amgxjroDa4nqKKphadeSj9C Ohy+fRiEn+KVeZHeCgU/6qe9ThE84ZdyWKYzWeUmnu7JlFM8zEald6htYsBQFXIh 7k0geyv+B4QMzLWlXtEqomUYGE2ReGHE/pySV6jLzGhiDkg8N34= =zNBn -----END PGP SIGNATURE----- --=-=-=-- --===============0733776248== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0733776248==--