From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v3 6/7] ASoC: add audio-graph-card document
Date: Mon, 13 Mar 2017 06:07:43 +0000
Message-ID: <87pohlhfvh.wl%kuninori.morimoto.gx@renesas.com>
References: <87fuiwmeya.wl%kuninori.morimoto.gx@renesas.com>
        <8760jsmers.wl%kuninori.morimoto.gx@renesas.com>
        <20170312114355.q2sftbljlvkvgc7j@rob-hp-laptop>
Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
Return-path: <devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <20170312114355.q2sftbljlvkvgc7j@rob-hp-laptop>
Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Linux-ALSA <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>, Simon <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>, Linux-DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
List-Id: devicetree@vger.kernel.org


Hi Rob

Thank you for your feedback

> > +- audio-graph-card,name
> > +- audio-graph-card,format
> > +- audio-graph-card,frame-master
> > +- audio-graph-card,bitclock-master
> > +- audio-graph-card,bitclock-inversion
> > +- audio-graph-card,frame-inversion
> > +- audio-graph-card,dai-tdm-slot-num
> > +- audio-graph-card,dai-tdm-slot-width
> 
> Sorry, I meant we should drop prefix ("audio-graph-card,") as these are 
> common properties and don't need a vendor prefix. We generally only do 
> prefixes when properties are vendor specifc and these are common. The 
> "simple-audio-card,*" prefix was a bit of an odd pattern.
> 
> Though if we do drop the prefix, just 'name' and 'format' are a bit 
> vague. Maybe dai-format instead of format. For name, I'm not sure how 
> that gets used. Does it really need to be per port? For user visible 
> names for things like identifying connectors on boards we use 'label', 
> so maybe that is appropriate here.

OK
In v4, I removed audio-graph-card prefix.
It has new label, and dai-format property

> > +- compatible				: "asoc-audio-graph-card";
> 
> Just audio-graph-card. asoc is a Linux term.

fixed in v4

> > +	dai-controller@0 {
> 
> These should be audio-codec@...

fixed in v4

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html