From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn9Qi-0004JJ-3t for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:13:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn9Qc-0000w5-D1 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:13:07 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40402 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn9Qc-0000vy-7C for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:13:02 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8MJCxJi014379 for ; Thu, 22 Sep 2016 15:13:01 -0400 Received: from e28smtp05.in.ibm.com (e28smtp05.in.ibm.com [125.16.236.5]) by mx0b-001b2d01.pphosted.com with ESMTP id 25mjyrxthf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 22 Sep 2016 15:13:01 -0400 Received: from localhost by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Sep 2016 00:42:18 +0530 From: Nikunj A Dadhania In-Reply-To: <87wpi3omwl.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> References: <1474526262-27011-1-git-send-email-david@gibson.dropbear.id.au> <87wpi3omwl.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> Date: Fri, 23 Sep 2016 00:42:09 +0530 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87ponvoik6.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 00/44] ppc-for-2.8 queue 20160922 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , David Gibson Cc: "qemu-ppc@nongnu.org" , QEMU Developers Nikunj A Dadhania writes: > Peter Maydell writes: > >> On 22 September 2016 at 07:36, David Gibson wrote: >>> The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: >>> >>> build-sys: fix make install regression (2016-09-20 11:32:43 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160922 >>> >>> for you to fetch changes up to 2832da4b6fc549d5feb2cf9fe53ad98cee894327: >>> >>> monitor: fix crash for platforms without a CPU 0 (2016-09-22 15:53:01 +1000) >>> >>> ---------------------------------------------------------------- >>> ppc patch queue 2016-09-22 >>> >>> This is my second pull request of ppc and spapr related patches for >>> qemu-2.8. Included here are >>> * TCG implementations for more POWER9 instructions >>> * Some preliminary XICS fixes in preparataion for the pnv machine type >>> * A significant ADB (Macintosh kbd/mouse) cleanup >>> * Some conversions to use trace instead of debug macros >>> * Fixes to correctly handle global TLB flush synchronization in >>> TCG. This is already a bug, but it will have much more impact >>> when we get MTTCG >>> * Add more qtest testcases for Power >>> * Some MAINTAINERS updates >>> * Assorted bugfixes >>> >>> This touches some test files and monitor.c which are technically >>> outside the ppc code, but coming through this tree because the changes >>> are primarily of interest to ppc. >>> >>> ---------------------------------------------------------------- >> >> I'm afraid this fails to build with clang: >> >> /home/petmay01/linaro/qemu-for-merges/target-ppc/translate.c:532:16: >> error: unused function 'L' [-Werro >> r,-Wunused-function] >> EXTRACT_HELPER(L, 16, 2); >> ^ >> 1 error generated. > > +/* darn */ > +static void gen_darn(DisasContext *ctx) > +{ > + int l = L(ctx->opcode); > > Used here, false positive ? It is not a false positive, below would be needed in "[PULL 34/44] target-ppc: implement darn instruction" as gen_darn is within TARGET_PPC64: diff --git a/target-ppc/translate.c b/target-ppc/translate.c index eb681de..4f33915 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -528,8 +528,10 @@ EXTRACT_HELPER(FPW, 16, 1); /* addpcis */ EXTRACT_HELPER_DXFORM(DX, 10, 6, 6, 5, 16, 1, 1, 0, 0) +#if defined(TARGET_PPC64) /* darn */ EXTRACT_HELPER(L, 16, 2); +#endif /*** Jump target decoding ***/ /* Immediate address */ Regards, Nikunj