From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XK92i-0007F6-F7
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 12:47:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XK92d-0002aR-Kd
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 12:47:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49979)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XK92d-0002aM-BF
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 12:47:19 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <20140820153431.15111.3916.stgit@fimbulvetr.bsc.es>
Date: Wed, 20 Aug 2014 18:47:11 +0200
In-Reply-To: <20140820153431.15111.3916.stgit@fimbulvetr.bsc.es>
	(=?utf-8?Q?=22Llu=C3=ADs?=
	Vilanova"'s message of "Wed, 20 Aug 2014 17:34:32 +0200")
Message-ID: <87ppfvqfao.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] trace: [qmp] Add QAPI/QMP commands to
	query and control event tracing state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?Q?Llu=C3=ADs?= Vilanova <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> writes:

> Also removes old "trace-event", "trace-file" and "info trace-events" HMP
> commands.

We gain the ability to control trace via QMP, but lose the ability to
control it via HMP, correct?

>
> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  hmp-commands.hx     |   35 -----------------------
>  monitor.c           |   61 ----------------------------------------
>  qapi-schema.json    |    3 ++
>  qmp-commands.hx     |   27 ++++++++++++++++++
>  trace/Makefile.objs |    1 +
>  trace/commands.json |   44 +++++++++++++++++++++++++++++

There's no precedence for keeping schema bits anywhere but in qapi/.
If we decide we want to keep them with their related C parts instead, we
should do so consistently, not just for trace.

>  trace/control.c     |   13 ---------
>  trace/control.h     |    7 -----
>  trace/qmp.c         |   77 +++++++++++++++++++++++++++++++++++++++++++++=
++++++
>  trace/simple.c      |   10 +------
>  trace/simple.h      |    3 --
>  11 files changed, 154 insertions(+), 127 deletions(-)
>  create mode 100644 trace/commands.json
>  create mode 100644 trace/qmp.c
[...]