From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name
Date: Thu, 12 Jun 2014 16:33:11 +0200 [thread overview]
Message-ID: <87ppietcyg.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20140612083209.GA22189@redhat.com> (Michael S. Tsirkin's message of "Thu, 12 Jun 2014 11:32:09 +0300")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Thu, Jun 12, 2014 at 10:27:53AM +0200, Markus Armbruster wrote:
>> "Michael S. Tsirkin" <mst@redhat.com> writes:
>>
>> > Names with spaces in them are nasty, let's not go there.
>>
>> Yes, they are, but please use '-' instead of '_'. I can see just a few
>> devices with '_' in their name, but more than a hundred with '-'.
>
> No problem, I made this change.
> Result pushed to the pci branch, pls take a look there.
>
> Thanks!
The change is good, but I have more questions now.
What about "ICH9 SMB" in hw/i2c/smbus_ich9.c?
Technically, device names are ABI. These two are onboard devices, so
changing their names can't break -device / device_add use. It still
could break -global use. Do we care?
If yes, the obvious fix is to keep the old name as alias.
next prev parent reply other threads:[~2014-06-12 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 15:46 [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name Michael S. Tsirkin
2014-06-12 8:27 ` Markus Armbruster
2014-06-12 8:32 ` Michael S. Tsirkin
2014-06-12 14:33 ` Markus Armbruster [this message]
2014-06-12 14:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppietcyg.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@amazon.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.